diff options
| author | Jubilee <46493976+workingjubilee@users.noreply.github.com> | 2024-06-12 03:57:20 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-06-12 03:57:20 -0700 |
| commit | 322af5c274301353b66b1bbb6f6d14232bf71438 (patch) | |
| tree | ee492d588d873731ba72d296d795273592e06abb /tests/codegen/patchable-function-entry/patchable-function-entry-both-flags.rs | |
| parent | e7b07ea7a182299bb13e5ffd321d210212beb489 (diff) | |
| parent | a49fe0a58c81f2fe10c5cf0cc5b22113253de893 (diff) | |
| download | rust-322af5c274301353b66b1bbb6f6d14232bf71438.tar.gz rust-322af5c274301353b66b1bbb6f6d14232bf71438.zip | |
Rollup merge of #125980 - kjetilkjeka:nvptx_remove_direct_passmode, r=davidtwco
Nvptx remove direct passmode This PR does what should have been done in #117671. That is fully avoid using the `PassMode::Direct` for `extern "C" fn` for `nvptx64-nvidia-cuda` and enable the compatibility test. `@RalfJung` [pointed me in the right direction](https://github.com/rust-lang/rust/issues/117480#issuecomment-2137712501) for solving this issue. There are still some ABI bugs after this PR is merged. These ABI tests are created based on what is actually correct, and since they continue passing with even more of them enabled things are improving. I don't have the time to tackle all the remaining issues right now, but I think getting these improvements merged is very valuable in themselves and plan to tackle more of them long term. This also doesn't remove the use of `PassMode::Direct` for `extern "ptx-kernel" fn`. This was also not trivial to make work. And since the ABI is hidden behind an unstable feature it's less urgent. I don't know if it's correct to request `@RalfJung` as a reviewer (due to team structures), but he helped me a lot to figure out this stuff. If that's not appropriate then `@davidtwco` would be a good candidate since he know about this topic from #117671 r? `@RalfJung`
Diffstat (limited to 'tests/codegen/patchable-function-entry/patchable-function-entry-both-flags.rs')
0 files changed, 0 insertions, 0 deletions