about summary refs log tree commit diff
path: root/tests/codegen/patchable-function-entry/patchable-function-entry-both-flags.rs
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-05-09 11:59:04 +0000
committerbors <bors@rust-lang.org>2024-05-09 11:59:04 +0000
commit48bcef3a32dcc87a22200d0cf2be87288a231b38 (patch)
treec53e3ea125e938d6c03734da095f1be6a765d95f /tests/codegen/patchable-function-entry/patchable-function-entry-both-flags.rs
parent85b17d4e11a2690c6546705f9136a99d293ad0b5 (diff)
parenta3ed9fe95506529494895f71321c5332583ad2ba (diff)
downloadrust-48bcef3a32dcc87a22200d0cf2be87288a231b38.tar.gz
rust-48bcef3a32dcc87a22200d0cf2be87288a231b38.zip
Auto merge of #17208 - Wilfred:log_error_from_threads, r=Veykril
fix: Report both IO errors and main_loop errors

If rust-analyzer receives a malformed LSP request, the IO thread terminates with a meaningful error, but then closes the channel.

Once the channel has closed, the main_loop also terminates, but it only has RecvError and can't show a meaningful error. As a result, rust-analyzer would incorrectly claim that the client forgot to shutdown.

```
$ buggy_lsp_client | rust-analyzer
Error: client exited without proper shutdown sequence
```

Instead, include both error messages when the server shuts down.
Diffstat (limited to 'tests/codegen/patchable-function-entry/patchable-function-entry-both-flags.rs')
0 files changed, 0 insertions, 0 deletions