about summary refs log tree commit diff
path: root/tests/coverage/branch/lazy-boolean.cov-map
diff options
context:
space:
mode:
authorbors <bors@rust-lang.org>2024-12-09 17:05:29 +0000
committerbors <bors@rust-lang.org>2024-12-09 17:05:29 +0000
commita224f3807e58afc9353510f1d556c607d367545d (patch)
treebb1431a8c64bc9290251036b31654e4dd730d143 /tests/coverage/branch/lazy-boolean.cov-map
parentf6cb952dc115fd1311b02b694933e31d8dc8b002 (diff)
parent38bfd88db788210d2481e3c74b2c63006f658cc8 (diff)
downloadrust-a224f3807e58afc9353510f1d556c607d367545d.tar.gz
rust-a224f3807e58afc9353510f1d556c607d367545d.zip
Auto merge of #134064 - jieyouxu:revert-131669, r=ChrisDenton
Revert #131669 due to ICEs

Revert [lint: change help for pointers to dyn types in FFI #131669](https://github.com/rust-lang/rust/pull/131669) due to ICE reports:

- <https://github.com/rust-lang/rust/issues/134059> (real-world)
- <https://github.com/rust-lang/rust/issues/134060> (fuzzing)

Closes #134060.

The revert criteria I used to assess whether to post this revert was:

1. It's not trivial to fix-forward. (1) The implementation itself is tricky due to `tcx.is_sized` query not being very trivial. (2) It will need more extensive test coverage for different ty kinds.
2. It is impacting real-world crates, i.e. #134059.
3. `improper_ctypes_definitions` is a warn-by-default lint.

This revert is without prejudice to relanding the changes. The changes can be re-landed with those cases addressed and stronger test coverage.

A rough regression test corresponding to the fuzzed example reported in #134060 is added to check that the revert worked, it is not sufficient for the lint test coverage when the lint improvements are to be relanded. Please feel free to improve the test in the reland.

r? `@workingjubilee` (or compiler)
cc `@niacdoial` (PR author)
Diffstat (limited to 'tests/coverage/branch/lazy-boolean.cov-map')
0 files changed, 0 insertions, 0 deletions