summary refs log tree commit diff
path: root/tests/rustdoc-gui/copy-code.goml
diff options
context:
space:
mode:
authorJieyou Xu <jieyouxu@outlook.com>2025-07-18 00:10:46 +0800
committerJosh Stone <jistone@redhat.com>2025-07-24 11:02:01 -0700
commit2e832047c6bf348ba44fd57b21bada846d62f156 (patch)
tree2239e5eb288c561ba48135ba5ed537b743b51e9d /tests/rustdoc-gui/copy-code.goml
parent43056c1614241ed06597a79b5e8f6464e6c8e11d (diff)
downloadrust-2e832047c6bf348ba44fd57b21bada846d62f156.tar.gz
rust-2e832047c6bf348ba44fd57b21bada846d62f156.zip
Mitigate `#[align]` name resolution ambiguity regression with a rename
From `#[align]` -> `#[rustc_align]`. Attributes starting with `rustc`
are always perma-unstable and feature-gated by `feature(rustc_attrs)`.

See regression RUST-143834.

For the underlying problem where even introducing new feature-gated
unstable built-in attributes can break user code such as

```rs
macro_rules! align {
    () => {
        /* .. */
    };
}

pub(crate) use align; // `use` here becomes ambiguous
```

refer to RUST-134963.

Since the `#[align]` attribute is still feature-gated by
`feature(fn_align)`, we can rename it as a mitigation. Note that
`#[rustc_align]` will obviously mean that current unstable user code
using `feature(fn_aling)` will need additionally `feature(rustc_attrs)`,
but this is a short-term mitigation to buy time, and is expected to be
changed to a better name with less collision potential.

See
<https://rust-lang.zulipchat.com/#narrow/channel/238009-t-compiler.2Fmeetings/topic/.5Bweekly.5D.202025-07-17/near/529290371>
where mitigation options were considered.

(cherry picked from commit 69b71e44107b4905ec7ad84ccb3edf4f14b3df69)
Diffstat (limited to 'tests/rustdoc-gui/copy-code.goml')
0 files changed, 0 insertions, 0 deletions