diff options
| author | Michael Howell <michael@notriddle.com> | 2024-05-04 22:31:30 -0700 |
|---|---|---|
| committer | Michael Howell <michael@notriddle.com> | 2024-05-05 08:15:08 -0700 |
| commit | eeb59f16a5f40e14dc29b95155b7f2569329e3ec (patch) | |
| tree | f21c11f6feeb2baf5eb4c169af03966f0e32c41f /tests/rustdoc-gui | |
| parent | 06e88c306a180067b6798901c26828d8ed7b0963 (diff) | |
| download | rust-eeb59f16a5f40e14dc29b95155b7f2569329e3ec.tar.gz rust-eeb59f16a5f40e14dc29b95155b7f2569329e3ec.zip | |
rustdoc: dedup search form HTML
This change constructs the search form HTML using JavaScript, instead of plain HTML. It uses a custom element because - the [parser]'s insert algorithm runs the connected callback synchronously, so we won't get layout jank - it requires very little HTML, so it's a real win in size [parser]: https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token This shrinks the standard library by about 60MiB, by my test.
Diffstat (limited to 'tests/rustdoc-gui')
| -rw-r--r-- | tests/rustdoc-gui/javascript-disabled.goml | 2 | ||||
| -rw-r--r-- | tests/rustdoc-gui/sidebar-source-code-display.goml | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tests/rustdoc-gui/javascript-disabled.goml b/tests/rustdoc-gui/javascript-disabled.goml index a7579ef7ec1..c6a7ad94b3f 100644 --- a/tests/rustdoc-gui/javascript-disabled.goml +++ b/tests/rustdoc-gui/javascript-disabled.goml @@ -4,7 +4,7 @@ javascript: false go-to: "file://" + |DOC_PATH| + "/test_docs/struct.Foo.html" show-text: true -assert-css: (".sub", {"display": "none"}) +assert-false: ".sub" // Even though JS is disabled, we should still have themes applied. Links are never black-colored // if styles are applied so we check that they are not. diff --git a/tests/rustdoc-gui/sidebar-source-code-display.goml b/tests/rustdoc-gui/sidebar-source-code-display.goml index 3bfbe820b8d..7ce3be8a5b3 100644 --- a/tests/rustdoc-gui/sidebar-source-code-display.goml +++ b/tests/rustdoc-gui/sidebar-source-code-display.goml @@ -4,7 +4,7 @@ javascript: false go-to: "file://" + |DOC_PATH| + "/src/test_docs/lib.rs.html" // Since the javascript is disabled, there shouldn't be a toggle. wait-for-css: (".sidebar", {"display": "none"}) -assert-css: ("#sidebar-button", {"display": "none"}) +assert-false: "#sidebar-button" // Let's retry with javascript enabled. javascript: true |