diff options
| author | Jacob Pratt <jacob@jhpratt.dev> | 2024-11-17 22:30:51 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-11-17 22:30:51 -0500 |
| commit | 6c4a7b6ff3dab45dfb07f8a7c4730255223e87eb (patch) | |
| tree | ab4ae80e529e6f89472348487a5224e9dfc43dbb /tests | |
| parent | 8600e579d58d2d5c23e423782c311f2193723543 (diff) | |
| parent | 7765f23ea14d16fb0182b475a0ec96891058ae24 (diff) | |
| download | rust-6c4a7b6ff3dab45dfb07f8a7c4730255223e87eb.tar.gz rust-6c4a7b6ff3dab45dfb07f8a7c4730255223e87eb.zip | |
Rollup merge of #133143 - kornelski:let-mut-global, r=compiler-errors
Diagnostics for let mut in item context The diagnostics for `let` at the top level did not account for `let mut`, which [made the error unclear](https://users.rust-lang.org/t/create-a-vector-of-constants-outside-main/121251/1). I've made the diagnostic always display a link to valid items. I've added dedicated help for `let mut` case that suggests using a `Mutex` (to steer novice users away from the `static mut` trap). Unfortunately, neither the Rust book, nor libstd docs have dedicated section listing all other types for interior-mutable `static`s.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/ui/parser/suggest-const-for-global-var.stderr | 7 | ||||
| -rw-r--r-- | tests/ui/parser/suggest-static-for-global-var-mut.rs | 5 | ||||
| -rw-r--r-- | tests/ui/parser/suggest-static-for-global-var-mut.stderr | 11 |
3 files changed, 22 insertions, 1 deletions
diff --git a/tests/ui/parser/suggest-const-for-global-var.stderr b/tests/ui/parser/suggest-const-for-global-var.stderr index 235e621d882..6ac7fe8f092 100644 --- a/tests/ui/parser/suggest-const-for-global-var.stderr +++ b/tests/ui/parser/suggest-const-for-global-var.stderr @@ -2,7 +2,12 @@ error: expected item, found keyword `let` --> $DIR/suggest-const-for-global-var.rs:1:1 | LL | let X: i32 = 12; - | ^^^ consider using `const` or `static` instead of `let` for global variables + | ^^^ + | | + | `let` cannot be used for global variables + | help: consider using `static` or `const` instead of `let` + | + = note: for a full list of items that can appear in modules, see <https://doc.rust-lang.org/reference/items.html> error: aborting due to 1 previous error diff --git a/tests/ui/parser/suggest-static-for-global-var-mut.rs b/tests/ui/parser/suggest-static-for-global-var-mut.rs new file mode 100644 index 00000000000..c63b09bb7a7 --- /dev/null +++ b/tests/ui/parser/suggest-static-for-global-var-mut.rs @@ -0,0 +1,5 @@ +let mut _data = vec![1,2,3]; +//~^ ERROR expected item, found keyword `let` + +fn main() { +} diff --git a/tests/ui/parser/suggest-static-for-global-var-mut.stderr b/tests/ui/parser/suggest-static-for-global-var-mut.stderr new file mode 100644 index 00000000000..4b00d1a24f3 --- /dev/null +++ b/tests/ui/parser/suggest-static-for-global-var-mut.stderr @@ -0,0 +1,11 @@ +error: expected item, found keyword `let` + --> $DIR/suggest-static-for-global-var-mut.rs:1:1 + | +LL | let mut _data = vec![1,2,3]; + | ^^^ `let` cannot be used for global variables + | + = help: consider using `static` and a `Mutex` instead of `let mut` + = note: for a full list of items that can appear in modules, see <https://doc.rust-lang.org/reference/items.html> + +error: aborting due to 1 previous error + |