diff options
| author | Samuel Tardieu <sam@rfc1149.net> | 2025-07-15 12:52:37 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-07-15 12:52:37 +0200 |
| commit | f03a56f7065e2785d84926be08582f939b2886d6 (patch) | |
| tree | 9ee443d5e72b22c0c5dfabe3e332bfb31d3c1972 /triagebot.toml | |
| parent | 4e72ed79d44faf05ce948e20154d072af0fabc44 (diff) | |
| parent | 0a899e0e8ad99d2e7afd1dd8e8466d6a14a04787 (diff) | |
| download | rust-f03a56f7065e2785d84926be08582f939b2886d6.tar.gz rust-f03a56f7065e2785d84926be08582f939b2886d6.zip | |
Rollup merge of #143630 - jieyouxu:drop-suggest, r=Mark-Simulacrum
Drop `./x suggest`
This PR removes the current `./x suggest` implementation (rust-lang/rust#109933, rust-lang/rust#106249) and associated docs for several reasons:
1. Primarily, `./x suggest` is another "flow" in bootstrap that incurs extra complexity and more invariants that bootstrap has to maintain. This causes more friction when trying to investigate and fix staging problems. As far as I know, this flow has not been actively maintained in quite a while, and I'm not aware of interest in maintaining it. Bootstrap really could use less implementation complexity with a very limited maintenance bandwidth.
2. The current `./x suggest` implementation "bypasses" the usual stage defaults for the various check/build/test/etc. flows, and it's not really possible to have a stage default because `./x suggest --run` produces a *sequence* of suggestions like [`./x check`, `./x test library/std`, ..] and then tries to run all of them in sequence, based on which files are modified.
3. We've not seen a lot of interest both in using it or extending static/dynamic test suggestions. Last extensions were rust-lang/rust#117961 and rust-lang/rust#120763. I'm not convinced the extra implementation complexity is worth it. This was discussed in:
- [#t-infra/bootstrap > Dropping the current `./x suggest` flow implementation](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Dropping.20the.20current.20.60.2E.2Fx.20suggest.60.20flow.20implementation/with/527456699)
- [#t-compiler > Dropping current `./x suggest` implementation](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Dropping.20current.20.60.2E.2Fx.20suggest.60.20implementation/with/527528696)
Closes rust-lang/rust#109933 (the current implementation is being removed).
Closes rust-lang/rust#143569 (by removing `./x suggest` altogether).
Diffstat (limited to 'triagebot.toml')
| -rw-r--r-- | triagebot.toml | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/triagebot.toml b/triagebot.toml index 75e794c700d..2f8114aeb3b 100644 --- a/triagebot.toml +++ b/triagebot.toml @@ -506,7 +506,6 @@ trigger_files = [ "src/tools/remote-test-server", "src/tools/remote-test-client", "src/tools/rustdoc-gui-test", - "src/tools/suggest-tests", ] [autolabel."A-tidy"] |