diff options
Diffstat (limited to 'clippy_lints/src/entry.rs')
| -rw-r--r-- | clippy_lints/src/entry.rs | 46 |
1 files changed, 23 insertions, 23 deletions
diff --git a/clippy_lints/src/entry.rs b/clippy_lints/src/entry.rs index 3e0a6e11be6..0dc970fcafe 100644 --- a/clippy_lints/src/entry.rs +++ b/clippy_lints/src/entry.rs @@ -8,30 +8,30 @@ use rustc::{declare_tool_lint, lint_array}; use rustc_errors::Applicability; use syntax::source_map::Span; -/// **What it does:** Checks for uses of `contains_key` + `insert` on `HashMap` -/// or `BTreeMap`. -/// -/// **Why is this bad?** Using `entry` is more efficient. -/// -/// **Known problems:** Some false negatives, eg.: -/// ```rust -/// let k = &key; -/// if !m.contains_key(k) { -/// m.insert(k.clone(), v); -/// } -/// ``` -/// -/// **Example:** -/// ```rust -/// if !m.contains_key(&k) { -/// m.insert(k, v) -/// } -/// ``` -/// can be rewritten as: -/// ```rust -/// m.entry(k).or_insert(v); -/// ``` declare_clippy_lint! { + /// **What it does:** Checks for uses of `contains_key` + `insert` on `HashMap` + /// or `BTreeMap`. + /// + /// **Why is this bad?** Using `entry` is more efficient. + /// + /// **Known problems:** Some false negatives, eg.: + /// ```rust + /// let k = &key; + /// if !m.contains_key(k) { + /// m.insert(k.clone(), v); + /// } + /// ``` + /// + /// **Example:** + /// ```rust + /// if !m.contains_key(&k) { + /// m.insert(k, v) + /// } + /// ``` + /// can be rewritten as: + /// ```rust + /// m.entry(k).or_insert(v); + /// ``` pub MAP_ENTRY, perf, "use of `contains_key` followed by `insert` on a `HashMap` or `BTreeMap`" |
