summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2019-05-13Auto merge of #60785 - alexcrichton:error-type-id-destabilize-stable, ↵ 1.34.2bors-2/+13
r=pietroalbini [stable] Destabilize the `Error::type_id` function This commit destabilizes the `Error::type_id` function in the standard library. This does so by effectively reverting #58048, restoring the `#[unstable]` attribute. The security mailing list has recently been notified of a vulnerability relating to the stabilization of this function. First stabilized in Rust 1.34.0, a stable function here allows users to implement a custom return value for this function: struct MyType; impl Error for MyType { fn type_id(&self) -> TypeId { // Enable safe casting to `String` by accident. TypeId::of::<String>() } } This, when combined with the `Error::downcast` family of functions, allows safely casting a type to any other type, clearly a memory safety issue! A formal announcement has been made to the [security mailing list](https://groups.google.com/forum/#!topic/rustlang-security-announcements/aZabeCMUv70) as well as [the blog](https://blog.rust-lang.org/2019/05/13/Security-advisory.html) This commit simply destabilizes the `Error::type_id` which, although breaking for users since Rust 1.34.0, is hoped to have little impact and has been deemed sufficient to mitigate this issue for the stable channel. The long-term fate of the `Error::type_id` API will be discussed at #60784.
2019-05-13bump rust to 1.34.2Pietro Albini-1/+1
2019-05-13add release notes for rust 1.34.2Pietro Albini-0/+8
2019-05-13Destabilize the `Error::type_id` functionAlex Crichton-1/+4
This commit destabilizes the `Error::type_id` function in the standard library. This does so by effectively reverting #58048, restoring the `#[unstable]` attribute. The security mailing list has recently been notified of a vulnerability relating to the stabilization of this function. First stabilized in Rust 1.34.0, a stable function here allows users to implement a custom return value for this function: struct MyType; impl Error for MyType { fn type_id(&self) -> TypeId { // Enable safe casting to `String` by accident. TypeId::of::<String>() } } This, when combined with the `Error::downcast` family of functions, allows safely casting a type to any other type, clearly a memory safety issue! A security announcement will be shortly posted to the security mailing list as well as the Rust Blog, and when those links are available they'll be filled in for this PR as well. This commit simply destabilizes the `Error::type_id` which, although breaking for users since Rust 1.34.0, is hoped to have little impact and has been deemed sufficient to mitigate this issue for the stable channel. The long-term fate of the `Error::type_id` API will be discussed at #60784.
2019-04-24Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum 1.34.1bors-16/+45
[stable] 1.34.1 point release The release date is April 25th. Included in this point release: * #59891: Fix the link to sort_by_cached_key * #59989: Fix links to Atomic* in RELEASES.md * https://github.com/rust-lang/rust-clippy/pull/3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747 * https://github.com/rust-lang/rust-clippy/pull/3821: do not trigger redundant_closure when there is a difference in borrow... * https://github.com/rust-lang/rust-clippy/pull/3844: Fix two missing_const_for_fn false positives
2019-04-24Try previous build image on AppVeyorMark Rousskov-0/+4
2019-04-23bump to rust 1.34.1Pietro Albini-1/+1
2019-04-23update release notes for 1.34.1Pietro Albini-0/+11
2019-04-23update clippyPietro Albini-5/+19
2019-04-23Fix links to Atomic* in RELEASES.mdDmitry Murzin-9/+9
2019-04-23Fix the link to sort_by_cached_keyJosh Stone-1/+1
It's a primitive slice method, not a standalone function.
2019-04-10Auto merge of #59843 - pietroalbini:stable-extras, r=Mark-Simulacrum 1.34.0bors-1/+3
[stable] Cherry-pick stdlib fix Cherry-picked: * #59835: Re-export NonZero signed variant in std r? @Mark-Simulacrum cc https://github.com/rust-lang/rust/issues/59834 @rust-lang/release
2019-04-10Update ui testLzu Tao-1/+1
2019-04-10Re-export NonZero signed variant in stdLzu Tao-0/+2
2019-04-08Auto merge of #59794 - pietroalbini:stable-next, r=pietroalbinibors-1/+1
[stable] Rust 1.34.0 cc @rust-lang/release r? @ghost
2019-04-08stable 1.34.0 releasePietro Albini-1/+1
2019-04-08Auto merge of #59737 - pietroalbini:beta-rollup, r=pietroalbinibors-116/+869
[beta] Rollup backports Cherry-picked: * #58021: Fix fallout from #57667 * #59599: Updated RELEASES.md for 1.34.0 * #59587: Remove #[doc(hidden)] from Error::type_id * #58994: Hide deprecation warnings inside derive expansions * #58015: Expand docs for `TryFrom` and `TryInto`. * #59770: ci: pin android emulator to 28.0.23 * #59704: ci: Update FreeBSD tarball downloads * #59257: Update CI configuration for building Redox libraries * #59724: Function arguments should never get promoted * #59499: Fix broken download link in the armhf-gnu image * #58330: Add rustdoc JS non-std tests * #58848: Prevent cache issues on version updates r? @ghost
2019-04-08Fix error index CSS file nameGuillaume Gomez-8/+13
2019-04-08Handle RUSTDOC_RESOURCE_SUFFIX env variable for rustdoc buildGuillaume Gomez-0/+11
2019-04-08Add resource suffix for libtest and proc_macro as wellGuillaume Gomez-2/+2
2019-04-08Prevent cache issues on version updatesGuillaume Gomez-8/+7
2019-04-08Make js tests work even with resource-suffix optionGuillaume Gomez-3/+30
2019-04-08Improve codeGuillaume Gomez-1/+4
2019-04-08Move rustdoc-js testing into compiletestGuillaume Gomez-53/+42
2019-04-08Update to last updatesGuillaume Gomez-3/+3
2019-04-08Move documentation build into bootstrapGuillaume Gomez-46/+58
2019-04-08Rename rustdoc js test suitesGuillaume Gomez-100/+93
2019-04-08Add rustdoc JS non-std testsGuillaume Gomez-1/+420
2019-04-08fix broken download link in the armhf-gnu imagePietro Albini-1/+2
2019-04-07Use `curl` instead of `wget`.kennytm-1/+1
2019-04-07bless the ui testsPietro Albini-3/+3
2019-04-07Only run SIMD tests on x86Oliver Scherer-3/+9
2019-04-07Update commentOliver Scherer-1/+1
2019-04-07Add more regression tests for accidental promotionOliver Scherer-2/+39
2019-04-07Function arguments should never get promotedOliver Scherer-1/+19
2019-04-07Update CI configuration for building Redox librariesJeremy Soller-10/+4
2019-04-07ci: Update FreeBSD tarball downloadsAlex Crichton-1/+5
These appear to have disappeared from the original server, so I acquired the contents from a different mirror and uploaded them to our S3 bucket
2019-04-07ci: pin android emulator to 28.0.23Pietro Albini-3/+15
2019-04-07Remove stabilized feature gate in doctestSimon Sapin-1/+0
2019-04-07Vastly simplify TryFrom docs.Simon Heath-28/+8
2019-04-07Incorporated review changes.Simon Heath-17/+35
2019-04-07Slowly figuring out how rustdoc actually works.Simon Heath-0/+3
Unfortunately trying to run doctests on my local machine is not really faster than letting Travis do it...
2019-04-07Fix some links in TryFrom docs.Simon Heath-7/+15
2019-04-07Fix a bunch of heckin' trailing whitespaceSimon Heath-17/+17
2019-04-07Add basic docs to integer TryFrom impl macros.Simon Heath-0/+16
They're not as good as `From` 'cause they don't stringify the types and generate examples and so on, but it's a start.
2019-04-07Started expanding docs for `TryFrom` and `TryInto`.Simon Heath-1/+43
The examples are still lacking for now, both for module docs and for methods/impl's.
2019-04-06Don't report deprecation lints in derive expansionsOliver Scherer-2/+38
2019-04-06Remove #[doc(hidden)] from Error::type_idAaron Power-1/+0
2019-04-06Update RELEASES.mdMazdak Farrokhzad-1/+1
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
2019-04-06Update RELEASES.mdXAMPPRocky-10/+6
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-04-26 09:37:34 +0000