about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2021-01-04Auto merge of #80554 - GuillaumeGomez:more-js-cleanup, r=jyn514bors-18/+12
More js cleanup Part of #79052 (Same kind as #80515). This one is about some small fixes: * Replacing some loops with `onEachLazy`. * Removing unused function arguments. * Turn `buildHelperPopup` into a variable so it can be "replaced" once the function has been called once so it's not called again. r? `@jyn514`
2021-01-04Auto merge of #80418 - oli-obk:this_could_have_been_so_simple, r=RalfJungbors-62/+230
Allow references to interior mutable data behind a feature gate supercedes #80373 by simply not checking for interior mutability on borrows of locals that have `StorageDead` and thus can never be leaked to the final value of the constant tracking issue: https://github.com/rust-lang/rust/issues/80384 r? `@RalfJung`
2021-01-03Auto merge of #77859 - bugadani:no-duplicate-ref-link-error, r=jyn514bors-67/+175
Rustdoc: only report broken ref-style links once This PR assigns the markdown `LinkType` to each parsed link and passes this information into the link collector. If a link can't be resolved in `resolve_with_disambiguator`, the failure is cached for the link types where we only want to report the error once (namely `Shortcut` and `Reference`). Fixes #77681
2021-01-03Auto merge of #80655 - GuillaumeGomez:rollup-ai7soid, r=GuillaumeGomezbors-119/+159
Rollup of 5 pull requests Successful merges: - #80580 (Add suggestion for "ignore" doc code block) - #80591 (remove allow(incomplete_features) from std) - #80617 (Detect invalid rustdoc test commands) - #80628 (reduce borrowing and (de)referencing around match patterns (clippy::match_ref_pats)) - #80646 (Clean up in `each_child_of_item`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
2021-01-03Only report reference-style link errors onceDániel Buga-67/+175
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
2021-01-03Rollup merge of #80646 - bugadani:meta, r=petrochenkovGuillaume Gomez-17/+12
Clean up in `each_child_of_item` This PR hopes to eliminate some of the surprising elements I encountered while reading the function. - `macros_only` is checked against inside the loop body, but if it is `true`, the loop is skipped anyway - only query `span` when relevant - no need to allocate attribute vector
2021-01-03Rollup merge of #80628 - matthiaskrgr:match_ref_pats, r=varkorGuillaume Gomez-91/+89
reduce borrowing and (de)referencing around match patterns (clippy::match_ref_pats)
2021-01-03Rollup merge of #80617 - ↵Guillaume Gomez-1/+11
GuillaumeGomez:detect-invalid-rustdoc-test-commands, r=jyn514 Detect invalid rustdoc test commands Fixes #80570. There are now errors displayed in case of bad command syntax: ``` ---- [rustdoc] rustdoc/remove-url-from-headings.rs stdout ---- error: htmldocck failed! status: exit code: 1 command: "/usr/bin/python" "/home/imperio/rust/rust/src/etc/htmldocck.py" "/home/imperio/rust/rust/build/x86_64-unknown-linux-gnu/test/rustdoc/remove-url-from-headings" "/home/imperio/rust/rust/src/test/rustdoc/remove-url-from-headings.rs" stdout: ------------------------------------------ ------------------------------------------ stderr: ------------------------------------------ 3: Invalid command: `!`@has`,` (try with ``@!has`)` // !`@has` - '//a[`@href="http://a.a"]'` Encountered 1 errors ``` r? `@camelid`
2021-01-03Rollup merge of #80591 - lcnr:incomplete-features, r=RalfJungGuillaume Gomez-4/+2
remove allow(incomplete_features) from std cc https://github.com/rust-lang/rust/pull/80349#issuecomment-753357123 > Now I am somewhat concerned that the standard library uses some of these features... I think it is theoretically ok to use incomplete features in the standard library or the compiler if we know that there is an already working subset and we explicitly document what we have to be careful about. Though at that point it is probably better to try and split the incomplete feature into two separate ones, similar to `min_specialization`. Will be interesting once `feature(const_evaluatable_checked)` works well enough to imo be used in the compiler but not yet well enough to be removed from `INCOMPLETE_FEATURES`. r? `@RalfJung`
2021-01-03Rollup merge of #80580 - GuillaumeGomez:suggestion-ignore-codeblock-warn, ↵Guillaume Gomez-6/+45
r=jyn514 Add suggestion for "ignore" doc code block Part of https://github.com/rust-lang/rust/issues/30032. This PR adds a suggestion to help users when they have a "ignore" doc code block which is invalid rust code. r? `@jyn514`
2021-01-03Stylistic fixes to diagnostic messagesoli-4/+4
2021-01-03Refactor the non-transient cell borrow error diagnosticoli-25/+46
2021-01-03Dangling pointers point to everything and nothingOli Scherer-2/+1
Co-authored-by: Ralf Jung <post@ralfj.de>
2021-01-03Grammar fixesOli Scherer-1/+1
Co-authored-by: Ralf Jung <post@ralfj.de>
2021-01-03Inline resetMouseMoved function directly into "mousemove" event handlerGuillaume Gomez-5/+1
2021-01-03Replace some loops with "onEachLazy" callGuillaume Gomez-13/+11
2021-01-03Create a "is_ignore" variable instead of doing the comparison multiple timesGuillaume Gomez-3/+4
2021-01-03Update now-more-precise operation with a preciser messageoli-16/+16
2021-01-03Apply suggestions from code reviewOli Scherer-4/+9
comment nits Co-authored-by: Ralf Jung <post@ralfj.de>
2021-01-03Move variable into condition where it's usedDániel Buga-1/+1
2021-01-03No need to collect result of get_item_attrsDániel Buga-3/+2
2021-01-03Detect invalid rustdoc test commandsGuillaume Gomez-1/+11
2021-01-03Auto merge of #80590 - camelid:bool-never-docs, r=nagisabors-6/+7
Update `bool` and `!` docs
2021-01-03Clean up convoluted macros_only logicDániel Buga-13/+9
2021-01-03Auto merge of #80247 - tmiasko:indent, r=bjorn3bors-1/+1
Fix indentation of -Z meta-stats output
2021-01-03Auto merge of #80261 - GuillaumeGomez:attr-rework, r=jyn514bors-164/+145
rustdoc DocFragment rework Kind of a follow-up of #80119. A few things are happening in this PR. I'm not sure about the impact on perf though so I'm very interested about that too (if the perf is worse, then we can just close this PR). The idea here is mostly about reducing the memory usage by relying even more on `Symbol` instead of `String`. The only issue is that `DocFragment` has 3 modifications performed on it: 1. Unindenting 2. Collapsing similar comments into one 3. "Beautifying" (weird JS-like comments handling). To do so, I saved the information about unindent and the "collapse" is now on-demand (which is why I'm not sure the perf will be better, it has to be run multiple times...). r? `@jyn514`
2021-01-03Auto merge of #79827 - tmiasko:size-align, r=kennytmbors-0/+6
Describe why `size_align` have not been inlined so far although it is used only in one place.
2021-01-03Auto merge of #80623 - flip1995:clippyup, r=Manishearthbors-251/+650
Update Clippy Biweekly Clippy update. This includes a Cargo.lock update for the recent Clippy version bump. r? `@Manishearth`
2021-01-02Auto merge of #80592 - Skynoodle:snake-case-lint-reserved-identifier, ↵bors-2/+103
r=davidtwco Suggest renaming or escaping when fixing non-snake-case identifiers which would conflict with keywords Fixes #80575
2021-01-02reduce borrowing and (de)referencing around match patterns ↵Matthias Krüger-91/+89
(clippy::match_ref_pats)
2021-01-02Simplify docfragment transformation in unindent testsGuillaume Gomez-14/+1
2021-01-02Remove unused collapse passGuillaume Gomez-19/+3
2021-01-02Improve code for DocFragment reworkGuillaume Gomez-19/+18
2021-01-02Auto merge of #80412 - GuillaumeGomez:fix-search-section-pos, r=jyn514bors-1/+4
Fix search section position on small devices Fixes #79526. This is exactly the same issue fixed in 9c36491538476dd3ff5ec834944aacdaceb12f30 (in https://github.com/rust-lang/rust/pull/79936) but applied to the search section. When the width becomes too small, the search input goes on its own line to get more space, making it go "under" the section following (so either "main" or "search"). The fix is to simply make the section go more under so that it doesn't go over the search input. r? `@jyn514`
2021-01-02Use bootstrap rustc for versioncheck in Clippyflip1995-3/+4
2021-01-02Update rustdoc-ui test outputGuillaume Gomez-2/+4
2021-01-02End of rework of Attributes structGuillaume Gomez-136/+145
2021-01-02Rework DocFragmentGuillaume Gomez-4/+4
2021-01-02Update Cargo.lockflip1995-2/+2
2021-01-02Add snake case lint note about keyword identifiers which cannot be rawSkynoodle-0/+3
2021-01-02Auto merge of #80550 - bugadani:markdown-refactor, r=jyn514bors-103/+111
Cleanup markdown span handling, take 2 This PR includes the cleanups made in #80244 except for the removal of `locate()`. While the biggest conceptual part in #80244 was the removal of `locate()`, it introduced a diagnostic regression. Additional cleanup: - Use `RefCell` to avoid building two separate vectors for the links Work to do: - [ ] Decide if `locate()` can be simplified by assuming `s` is always in `md` - [ ] Should probably add some tests that still provide the undesired diagnostics causing #80381 cc `@jyn514` This is the best I can do without patching Pulldown to provide multiple ranges for reference-style links. Also, since `locate` is probably more efficient than `rfind` (at least it's constant time), I decided to not check the link type and just cover every &str as it was before.
2021-01-02Merge commit '1fcc74cc9e03bc91eaa80ecf92976b0b14b3aeb6' into clippyupflip1995-249/+647
2021-01-02Auto merge of #6536 - flip1995:rustup, r=flip1995bors-16/+28
Rustup r? `@ghost` changelog: none
2021-01-02Bump Clippy version to 0.1.51flip1995-2/+2
2021-01-02Use rustc --version in versioncheckflip1995-9/+6
2021-01-02Bump nightly version to 2021-01-02flip1995-1/+1
2021-01-02Merge remote-tracking branch 'upstream/master' into rustupflip1995-267/+655
2021-01-02Auto merge of #6530 - m-ou-se:2021, r=phanschbors-2/+2
Initial support for Rust 2021. Clippy treated Rust 2021 as Rust 2015, because 2018 was checked with `==` instead of `>=`. This fixes that, such that 2018-specific things are also enabled for 2021. changelog: Added support for Rust 2021.
2021-01-02Auto merge of #80615 - m-ou-se:rollup-xz67at2, r=m-ou-sebors-118/+149
Rollup of 6 pull requests Successful merges: - #80546 (clippy fixes for librustdoc) - #80555 (Improve library tracking issue template) - #80574 (Clean bootstrap artifacts on `x.py clean`) - #80578 (improve unconditional_panic description) - #80599 (`const_generics_defaults`: don't ICE in the unimplemented parts) - #80613 (Diag: print enum variant instead of enum type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
2021-01-02Rollup merge of #80613 - bugadani:issue-80607, r=matthewjasperMara Bos-13/+60
Diag: print enum variant instead of enum type Closes #80607
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-04-26 15:49:48 +0000