about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2025-09-10An associated type is not a projection!Chayim Refael Friedman-1/+31
More correctly, a `TyKind::AssociatedType` is not the same as `TyKind::Projection`. We used to map next-solver `TyKind::Alias` to Chalk's `TyKind::AssociatedType`. This is very incorrect, as `AssociatedType` is assumed to be fully normalized, and caused a lot of type mismatches. Unfortunately fixing this causes a lot of stack overflows, because the next solver doesn't have something akin to `AssociatedType` so we normalize again and again. The reason is that is the lazy-normalization nature of the next solver, which means we need to stop normalizing everything. This will be fixed in the next commit.
2025-09-09Merge pull request #20578 from ShoyuVanilla/inftblChayim Refael Friedman-819/+2071
Migrate `InferenceTable` into next-solver
2025-09-10Fix failing tests and fill-in missing detailsShoyu Vanilla-1428/+914
2025-09-09WIP switch inference table to next-solverjackh726-526/+2292
2025-09-09Merge pull request #20624 from A4-Tacks/fix-syn-lifetime-boundsChayim Refael Friedman-7/+6
Fix LifetimeParam::lifetime_bounds invalid implement
2025-09-09Merge pull request #20638 from Kobzol/book-share-cacheChayim Refael Friedman-0/+10
Add a FAQ entry about RA and Cargo build lock/cache conflicts
2025-09-09Fix LifetimeParam::lifetime_bounds invalid implementA4-Tacks-7/+6
Lifetime node example: ``` LIFETIME_PARAM@15..21 LIFETIME@15..17 LIFETIME_IDENT@15..17 "'a" COLON@17..18 ":" WHITESPACE@18..19 " " TYPE_BOUND_LIST@19..21 TYPE_BOUND@19..21 LIFETIME@19..21 LIFETIME_IDENT@19..21 "'b" ```
2025-09-09Add a FAQ entry about RA and Cargo interactionJakub Beránek-0/+9
2025-09-09Update documentation about how to build the RA bookJakub Beránek-0/+1
2025-09-08Merge pull request #20632 from rmehri01/navigation-on-primsChayim Refael Friedman-139/+244
feat: support navigation on primitives
2025-09-08make TryToNav take Semantics instead of RootDatabaseRyan Mehri-124/+203
2025-09-08add testRyan Mehri-0/+14
2025-09-08impl TryToNav for BuiltinType insteadRyan Mehri-30/+32
2025-09-08Merge pull request #20633 from Wilfred/improve_introChayim Refael Friedman-9/+29
Clarify intro in README and manual
2025-09-08Clarify intro in README and manualWilfred Hughes-9/+29
The first sentence a new user should see should ideally answer the questions: * What is rust-analyzer? * Why might I want to use it? The vast majority of users will be interested in using rust-analyzer inside their favourite editor. We should clarify that rust-analyzer is an LSP implementation and that it supports all the classic IDE features. Whilst it's also true that rust-analyzer is modular and organised into libraries, the first impression should (I think) focus on an overview and the primary use case.
2025-09-08Merge pull request #20631 from Wilfred/remove_register_attrChayim Refael Friedman-62/+14
Remove support for register_attr
2025-09-08feat: support navigation on primitivesRyan Mehri-17/+27
2025-09-08Remove support for register_attrWilfred Hughes-62/+14
This was removed in rustc in 2022: https://github.com/rust-lang/rust/pull/101123 Closes #20525.
2025-09-08Merge pull request #20620 from A4-Tacks/let-else-completionLaurențiu Nicola-17/+220
fix: add `else` keyword completion after `let` statements
2025-09-08Merge pull request #20626 from A4-Tacks/make-record-wsLaurențiu Nicola-36/+39
Improve make::struct_ field_list whitespace
2025-09-07Improve make::struct_ field_list whitespaceA4-Tacks-36/+39
Example --- **Before this PR**: ```rust struct Variant{ field: u32 } ``` **After this PR**: ```rust struct Variant { field: u32 } ```
2025-09-06Add allow `else` keyword completion in LetStmtA4-Tacks-17/+220
Example --- ```rust fn foo() { let _ = 2 el$0 } ``` -> ```rust fn foo() { let _ = 2 else { $0 }; } ```
2025-09-05Merge pull request #20609 from ChayimFriedman2/update-rustcShoyu Vanilla (Flint)-579/+446
internal: Upgrade rustc crates
2025-09-04Upgrade rustc cratesChayim Refael Friedman-579/+446
The main changes are (there are some other small changes): - Using a specific type for trait IDs in the new solver, allowing us to simplify a lot of code. - Add `BoundConst` similar to `BoundTy` and `BoundRegion` (previously consts used `BoundVar` directly), due to a new trait requirement.
2025-09-04Merge pull request #20607 from ChayimFriedman2/ns-dyn-mismatchChayim Refael Friedman-1/+22
internal: Add a regression test for a fixed new trait solver bug
2025-09-04Merge pull request #20606 from ChayimFriedman2/reborrow-config-typoChayim Refael Friedman-1/+1
fix: Fix typo in config
2025-09-04Add a regression test for a fixed new trait solver bugChayim Refael Friedman-1/+22
Not sure what exactly fixed it, but why not.
2025-09-04Fix typo in configChayim Refael Friedman-1/+1
To make it backwards-compatible.
2025-09-03Merge pull request #20586 from ChayimFriedman2/placeholder-nsShoyu Vanilla (Flint)-233/+324
fix: Make sense of the mess that were (are) different kind of generics in the solver
2025-09-02Merge pull request #20587 from ChayimFriedman2/private-inherentLaurențiu Nicola-8/+47
fix: Deduplicate methods in completion by function ID and not by name
2025-09-02Deduplicate methods in completion by function ID and not by nameChayim Refael Friedman-8/+47
Because duplicates can be found with traits. Worse, the inherent methods could be private, and we'll discover that only later. But even if they're not they're different methods, and its seems worthy to present them all to the user.
2025-09-02Make sense of the mess that were (are) different kind of generics in the solverChayim Refael Friedman-233/+324
To the extent possible. Previously they were confused. Sometimes generic params were treated as `Param` and sometimes as `Placeholder`. A completely redundant (in the new solver) mapping of salsa::Id to ints to intern some info where we could just store it uninterned (not in Chalk though, for some weird reason). Plus fix a cute bug in closure substitution that was caught by the assertions of Chalk but the next solver did not have such assertions. Do we need more assertions?
2025-08-30Merge pull request #20579 from Elliot-Roberts/fix-double-target-optionChayim Refael Friedman-5/+2
fix: Avoid `--target` option being given twice to `rustc` when invoked through `cargo rustc` while fetching target data layout
2025-08-30Pass `--target` before `--` for `cargo rustc`Elliot Roberts-5/+2
2025-08-30Merge pull request #20563 from ChayimFriedman2/ns-projection-dyn-auto-traitShoyu Vanilla (Flint)-1/+70
fix: When mapping next-solver's `dyn` type, add `Self` (aka. bound var ^1.0) to auto traits' substitutions
2025-08-29Merge pull request #20569 from ↵David Barsky-3/+3
rust-lang/dependabot/cargo/tracing-subscriber-0.3.20 Bump tracing-subscriber from 0.3.19 to 0.3.20
2025-08-29Bump tracing-subscriber from 0.3.19 to 0.3.20dependabot[bot]-3/+3
Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.19 to 0.3.20. - [Release notes](https://github.com/tokio-rs/tracing/releases) - [Commits](https://github.com/tokio-rs/tracing/compare/tracing-subscriber-0.3.19...tracing-subscriber-0.3.20) --- updated-dependencies: - dependency-name: tracing-subscriber dependency-version: 0.3.20 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
2025-08-29Merge pull request #20560 from ChayimFriedman2/analysis-stats-improveLukas Wirth-3/+52
fix: Add progress bars to more places in analysis-stats
2025-08-28When mapping next-solver's `dyn` type, add `Self` (aka. bound var ^1.0) to ↵Chayim Refael Friedman-1/+70
auto traits' substitutions Chalk represents dyn types as a list of predicate, the self type should be there. The next solver represents them quite differently. The `Self` was forgotten for the auto trait case.
2025-08-28Merge pull request #20561 from ChayimFriedman2/no-table-for-youChayim Refael Friedman-59/+52
minor: Don't require a full `InferenceTable` for `CastTy`
2025-08-28Don't require a full `InferenceTable` for `CastTy`Chayim Refael Friedman-59/+52
A DB is enough.
2025-08-28Add progress bars to more places in analysis-statsChayim Refael Friedman-3/+52
Namely, mir lowering, const eval and IDE things.
2025-08-27Merge pull request #20553 from ChayimFriedman2/ns-highlight-attachChayim Refael Friedman-1/+2
fix: Attach the db in one more place in highlighting
2025-08-28Attach the db in one more place in highlightingChayim Refael Friedman-1/+2
2025-08-27Merge pull request #20547 from ChayimFriedman2/highlight-related-unsafe-scopeLaurențiu Nicola-10/+44
fix: In highlight_related, when on an unsafe block, don't highlight unsafe operations of other unsafe blocks
2025-08-27Merge pull request #20527 from ChayimFriedman2/cache-next-solverShoyu Vanilla (Flint)-66/+140
perf: Cache trait solving across queries in the same revision
2025-08-26In highlight_related, when on an unsafe block, don't highlight unsafe ↵Chayim Refael Friedman-10/+44
operations of other unsafe blocks
2025-08-26Merge pull request #20545 from ChayimFriedman2/ns-foreignLaurențiu Nicola-7/+4
fix: Remove `SolverDefId::ForeignId`
2025-08-26Remove `SolverDefId::ForeignId`Chayim Refael Friedman-7/+4
Replace it with normal `SolverDefId::TypeAliasId`. The split caused a very funny bug where code was getting `TypeAliasId` where it expected `ForeignId`, because `TypeAliasId` had a `From` impl from `hir_def::TypeAliasId` and `ForeignId` had not, plus a careless `into()`. I could've fixed this specific bug but opted to remove the split instead; currently, it just provides more room for bugs, as we don't have typed IDs for the solver anyway, and even when we'll have (hopefully), that doesn't seem like a very useful distinction, for example in hir-def foreign types are just `TypeAliasId` with some flags. Constructing a test for this isn't trivial; the trivial test (creating a foreign type, even proving a trait bound for it) fails to fail before the change, probably because we don't use the new solver everywhere yet so we don't trigger this specific code path.
2025-08-26Merge pull request #20399 from rust-lang/veykril/push-klrwvmzokqwuShoyu Vanilla (Flint)-2/+2
Enable warning logs by default