| Age | Commit message (Collapse) | Author | Lines |
|
|
|
Rollup of 10 pull requests
Successful merges:
- #101936 (Migrating rustc_infer to session diagnostics (part 3))
- #104081 (PhantomData layout guarantees)
- #104543 (Migrate `codegen_ssa` to diagnostics structs - [Part 3])
- #105128 (Add O(1) `Vec -> VecDeque` conversion guarantee)
- #105517 (Fix process-panic-after-fork.rs to pass on newer versions of Android.)
- #105859 (Point out span where we could introduce higher-ranked lifetime)
- #106509 (Detect closures assigned to binding in block)
- #106553 (docs: make `HashSet::retain` doctest more clear)
- #106556 (rustdoc: remove no-op mobile CSS `.content { margin-left: 0 }`)
- #106564 (Change to immutable borrow when cloning element of RepeatN)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
Change to immutable borrow when cloning element of RepeatN
|
|
r=GuillaumeGomez
rustdoc: remove no-op mobile CSS `.content { margin-left: 0 }`
This rule was added to override non-zero left margin on `.content`, which was removed in 135281ed1525db15edd8ebd092aa10aa40df2386 and the margin-left was put on the docblock.
|
|
docs: make `HashSet::retain` doctest more clear
Fixes #106535
Extremely simple fix suggested by ``@compiler-errors`` in the linked issue.
|
|
Detect closures assigned to binding in block
Fix #58497.
|
|
Point out span where we could introduce higher-ranked lifetime
Somewhat addresses #105422, but not really. We don't have that much useful information here since we're still in resolution :^(
Maybe this suggestion isn't worth it. If the reviewer has an idea how we can get a more succinct binder information for a structured suggestion, it would be appreciated.
|
|
Fix process-panic-after-fork.rs to pass on newer versions of Android.
The test process-panic-after-fork.rs was checking that abort() resulted in SIGSEGV on Android. This non-standard behavior was fixed back in 2013, so let's fix the test to also accept the standard behavior on Android.
|
|
Add O(1) `Vec -> VecDeque` conversion guarantee
(See #105072)
|
|
JhonnyBillM:migrate-codegen-ssa-to-diagnostics-structs-pt3, r=davidtwco
Migrate `codegen_ssa` to diagnostics structs - [Part 3]
Completes migrating `codegen_ssa` module except 2 outstanding errors that depend on other crates:
1. [`rustc_middle::mir::interpret::InterpError`](https://github.com/rust-lang/rust/blob/b6097f2e1b2ca62e188ba53cf43bd66b06b36915/compiler/rustc_middle/src/mir/interpret/error.rs#L475): I saw `rustc_middle` is unassigned, I am open to take this work.
2. `codegen_llvm`'s use of `fn span_invalid_monomorphization_error`, which I started to replace in the [last commit](https://github.com/rust-lang/rust/commit/9a31b3cdda78a2c0891828254fe9886e0a1cfd16) of this PR, but would like to know the team's preference on how we should keep replacing the other macros:
2.1. Update macros to expect a `Diagnostic`
2.2. Remove macros and expand the code on each use.
See [some examples of the different options in this experimental commit](https://github.com/JhonnyBillM/rust/commit/64aee83e80857dcfa450f0c6e31d5f29c6d577e6)
_Part 2 - https://github.com/rust-lang/rust/pull/103792_
r? ``@davidtwco``
Cc ``@compiler-errors``
|
|
PhantomData layout guarantees
|
|
Migrating rustc_infer to session diagnostics (part 3)
``@rustbot`` label +A-translation
r? rust-lang/diagnostics
cc https://github.com/rust-lang/rust/issues/100717
Seems like a part of static_impl_trait.rs emits suggestions in a loop, and note.rs needs to have two instances of the same subdiagnostic, so these will need to wait until we have eager translation/list support.
Other than that, there is only error_reporting/mod.rs left to migrate.
|
|
Add regression test for #86106
Closes #86106
r? `@nikic`
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
|
|
Perform SimplifyLocals before ConstProp.
MIR before `ConstProp` may have a lot of dead writes, this makes `ConstProp` do unnecessary work.
r? `@ghost`
|
|
|
|
Detect bindings assigned blocks without tail expressions
Fix #44173.
|
|
Add help diag. for `const = Enum` missing braces around `Enum`
Previously it was not clear why this errored or if it was even supported, as there was no diagnostic that suggested wrapping it in braces.
Thus, add a simple diagnostic that suggests wrapping enum variants in braces.
Fixes #105927
|
|
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
|
|
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
|
|
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
|
|
Rollup of 4 pull requests
Successful merges:
- #106525 (Report WF error for chalk *and* new solver)
- #106533 (Use smaller spans for missing lifetime/generic args)
- #106543 (rustdoc: remove no-op CSS `.rustdoc.source .sidebar { width: 0 }`)
- #106554 (Fix a typo in the explanation of E0588)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
Fix a typo in the explanation of E0588
|
|
r=GuillaumeGomez
rustdoc: remove no-op CSS `.rustdoc.source .sidebar { width: 0 }`
This CSS was added in dc2c9723343c985740be09919236a6e96c4e4433, before 6a5f8b1aef1417d7dc85b5d0a229d2db1930eb7c when the sidebars were merged.
Now that they are merged, the source sidebar is being pushed off-screen anyway, so giving it zero width doesn't do much.
|
|
TaKO8Ki:use-smaller-span-for-missing-lifetime/generic-args, r=compiler-errors
Use smaller spans for missing lifetime/generic args
We can remove ident from suggestions.
|
|
Report WF error for chalk *and* new solver
addressing this nit https://github.com/rust-lang/rust/pull/106385#discussion_r1062571070
No test yet because new solver is currently unusable, lol
r? `@lcnr`
|
|
This rule was added to override non-zero left margin on `.content`,
which was removed in 135281ed1525db15edd8ebd092aa10aa40df2386 and
the margin-left was put on the docblock.
|
|
|
|
|
|
rustdoc: Strip imports of items which are `#[doc(hidden)]`
Closes #106379
|
|
Rollup of 7 pull requests
Successful merges:
- #106287 (Add some docs to `bug`, `span_bug` and `delay_span_bug`)
- #106341 (refactor: clean up `errors.rs` and `error_codes_check.rs`)
- #106453 (Improve include macro documentation)
- #106466 (Fix rustdoc source code rendering for `#[path = "../path/to/mod.rs"]` links)
- #106528 (Tiny formatting fix)
- #106534 (rustdoc-gui: Use new block syntax for define-function in goml scripts)
- #106542 (Add default and latest stable edition to --edition in rustc (attempt 2))
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
Handle non-existent upstream master branches in `x fmt`
People who do have a remote for `rust-lang/rust` but don't have the master branch checked out there used to get this error when running `x fmt`:
> fatal: ambiguous argument 'rust/master': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> rust/master
Which is not exactly helpful.
Now, we fall back to `origin/master` (hoping that at least that remote exists) for that case. If there is still some error, we just fall back to `x fmt .` and print a warning.
r? `@jyn514`
|
|
Add default and latest stable edition to --edition in rustc (attempt 2)
Fixes #106041
No longer leaks string like my first attempt PR, #106094 - uses LazyLock to construct a `&'static str`
It will now output the default edition and latest stable edition in the help message for the `--edition` flag.
Going to request the same reviewer as the first attempt for continuity - r? `@Nilstrieb`
|
|
rustdoc-gui: Use new block syntax for define-function in goml scripts
r? `@notriddle`
|
|
Tiny formatting fix
|
|
Fix rustdoc source code rendering for `#[path = "../path/to/mod.rs"]` links
Fixes #103517
While generating the location for modules source HTML to be saved at, a `..` path component appeared to be translated to `/up/`.
Additionally, while generating the navigation sidebar, `..` path components were ignored. This means that (as in the issue above), a *real* directory structure of:
```
sys/
unix/
mod.rs <-- contains #![path = "../unix/mod.rs]
cmath.rs
```
was rendered as:
```
sys/
unix/
mod.rs
unix/
cmath.rs <-- links to sys/unix/unix/cmath.rs.html, 404
```
While the *files* were stored as
```
sys/
unix/
mod.rs.html
up/
unix/
cmath.rs.html
```
|
|
Improve include macro documentation
As outlined in #106118, the `include!` macro is a SEO problem when it comes to the Rust documentation. Beginners may see it as a replacement to `include` syntax in other languages. I feel like this documentation should quite explicitly link to the modules' documentation.
The primary goal of this PR is to address that issue by adding a warning to the documentation. While I was here, I also added some other parts. This included a `Uses` section and some (intra doc) links to other relevant topics.
I hope this can help beginners to Rust more quickly understand some multi-file project intricacies.
# References
- Syntax for the warning: https://github.com/tokio-rs/tracing/blob/58accc6da3f04af3f6144fbe6d68af7225c70c02/tracing/src/lib.rs#L55
|
|
r=mejrs,klensy,GuillaumeGomez
refactor: clean up `errors.rs` and `error_codes_check.rs`
`errors.rs` is basically unused now, `error_codes_check.rs` is useful but not well commented, etc. It also doesn't check certain things which are certainly not correct. For example, `E0505` has a UI test in `src/test/ui/error-codes/` but that test actually outputs `E0504`?! Other issues like these exist. I've implemented these with "warnings" which are a bit rough around the edges but should be removed eventually.
r? `@GuillaumeGomez` (again not sure if you want to review but its relevant to you)
|
|
r=jyn514
Add some docs to `bug`, `span_bug` and `delay_span_bug`
cc `@mejrs` as you wanted me to do this, does this look good and understandable?
|
|
This CSS was added in dc2c9723343c985740be09919236a6e96c4e4433,
before 6a5f8b1aef1417d7dc85b5d0a229d2db1930eb7c when the sidebars
were merged.
Now that they are merged, the source sidebar is being pushed
off-screen anyway, so giving it zero width doesn't do much.
|
|
Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
|
|
|
|
|
|
Closes #106379
|
|
Correct detection of elided lifetimes in impl-trait.
Fixes https://github.com/rust-lang/rust/issues/106338
r? `@compiler-errors`
cc `@pnkfelix`
|
|
|
|
|
|
|
|
cleanup: handle -Zmutable-noalias like -Zbox-noalias
r? `@bjorn3`
cc `@RalfJung` this will conflict with #106180
|
|
|
|
fix rustdoc ui test
|