about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2020-01-19Treat more strange patternYuki Okushi-21/+14
2020-01-19Auto merge of #5066 - JohnTitor:split-up-1447, r=llogiqbors-280/+279
Split up `if_same_then_else` ui test Part of #2038 changelog: none
2020-01-19Split up `if_same_then_else` ui testYuki Okushi-280/+279
2020-01-19Apply review commentsYuki Okushi-33/+28
2020-01-19Run `update_lints`Yuki Okushi-3/+3
2020-01-19Reduce span rangeYuki Okushi-20/+15
2020-01-19Rename `ok_if_let` to `if_let_some_result`Yuki Okushi-8/+8
2020-01-19Apply review commentsYuki Okushi-13/+12
2020-01-19Add suggestion in `if_let_some_result`Yuki Okushi-13/+101
2020-01-18Auto merge of #5065 - matthiaskrgr:rustup_28, r=matthiaskrgrbors-4/+1
rustup https://github.com/rust-lang/rust/pull/67712 slice_patterns have been stabilized. changelog: none
2020-01-18rustup https://github.com/rust-lang/rust/pull/67712Matthias Krüger-4/+1
slice_patterns have been stabilized.
2020-01-18Auto merge of #5046 - JohnTitor:order-nonminimal-bool, r=flip1995bors-265/+339
Keep the ordering in `nonminimal_bool` lint I believe it shouldn't cause any regression but feel free to let me know if you have a doubtful example. Also, splits up `booleans` ui test. Fixes #5045 changelog: none
2020-01-18Auto merge of #5063 - JohnTitor:allow-correctly, r=flip1995bors-6/+27
Allow `unused_self` lint at the function level Another approach of #5062. Fixes #5053 changelog: Allow `unused_self` lint at the function level
2020-01-18Allow `unused_self` lint at the function levelYuki Okushi-6/+27
2020-01-18Auto merge of #5057 - rust-lang:pedantic_range_plus_one, r=flip1995bors-4/+7
Downgrade range_plus_one to pedantic This fixes #2217 changelog: Downgrade [`range_plus_one`] to `pedantic`
2020-01-18Downgrade range_plus_one to pedanticAndre Bogus-4/+7
2020-01-18Auto merge of #5059 - JohnTitor:rustup-0118, r=llogiqbors-28/+75
Rustup to rust-lang/rust#68204 changelog: none
2020-01-18Rustup to rust-lang/rust#68204Yuki Okushi-28/+75
2020-01-16Auto merge of #5055 - krishna-veerareddy:fix-new-lint-generator-import, r=llogiqbors-5/+8
Fix new lint generator import Fix `rustc_lint` import path and add lifetimes to `LateLintPass` in `new_lint` command. changelog: none
2020-01-16Add lifetimes to `LateLintPass`Krishna Sai Veera Reddy-4/+7
2020-01-16Fix rustc lint import paths generated by `new_lint`Krishna Sai Veera Reddy-1/+1
2020-01-16Auto merge of #4994 - bradsherman:new_lint_gen, r=flip1995bors-32/+381
Autogenerate new lints Add option in clippy_dev to automatically generate boilerplate code for adding new lints example: `./util/dev new_lint --name=iter_nth_zero --type=late` Fixes #4942 changelog: none
2020-01-16Auto merge of #5054 - flip1995:rustup, r=flip1995bors-1/+1
Update custom_ice_message.stderr changelog: none
2020-01-16Update custom_ice_message.stderrflip1995-1/+1
2020-01-15Add lint for default lint descriptionBrad Sherman-4/+99
- Lint for any new lints that have the default lint description from the automation
2020-01-15Update documentation for adding new lintsBrad Sherman-28/+48
- Add instructions for adding new lints with the new automation
2020-01-15Generate new lints easilyBrad Sherman-0/+234
- Add option in clippy_dev to automatically generate boilerplate code for adding new lints
2020-01-15Auto merge of #5034 - ThibsG:MatchWildErrArmImprove5024, r=flip1995bors-88/+166
Match wild err arm improvements This lint should trigger on other identifiers which have `_` prefix (such as `_e`) and only if they are unused in the panic block. _Note_: the `is_unused` function is greatly inspired from `pat_is_wild` function in [loops lints](https://github.com/rust-lang/rust-clippy/blob/43ac9416d935942d6c7d2b2e0c876c551652c4ec/clippy_lints/src/loops.rs#L1689). I've been considering doing some refactoring, maybe in utils. Maybe this PR or a new one. What do you think ? fixes #5024 changelog: none
2020-01-15Auto merge of #5048 - justjavac:patch-1, r=llogiqbors-1/+1
update license year to 2020 Happy new year 2020 changelog: none
2020-01-15update license year to 2020迷渡-1/+1
2020-01-14Auto merge of #5023 - rust-lang:doc-main, r=phanschbors-3/+7
Omit doc safety/errors header checking for main This omits checking `main` methods, which are not usually documented in the way the others are. changelog: none
2020-01-14Omit doc safety/errors header checking for mainAndre Bogus-3/+7
2020-01-14Split up `booleans` ui testYuki Okushi-305/+337
2020-01-13Auto merge of #4543 - xiongmao86:issue4503, r=flip1995bors-3/+132
Fix issue4503 Fixes #4503. changelog: Add a lint checking user are using FileType.is_file() method and suggest using !FileType.is_dir(). - [x] Followed [lint naming conventions][lint_naming] - [x] Added passing UI tests (including committed `.stderr` file) - [x] `cargo test` passes locally - [x] Executed `./util/dev update_lints` - [x] Added lint documentation - [x] Run `./util/dev fmt`
2020-01-14Fix the ordering on `nonminimal_bool`Yuki Okushi-28/+70
2020-01-13Auto merge of #5033 - JohnTitor:split-use-self, r=flip1995bors-332/+342
Split up `use_self` ui test Part of #2038 changelog: none
2020-01-13Extract visitor to utilsThibsG-88/+62
2020-01-13Change note messageThibsG-11/+10
2020-01-13Fix formattingThibsG-6/+7
2020-01-13Better binding name on Err for noteThibsG-27/+37
2020-01-13Match underscore-prefixed variable alsoThibsG-19/+113
2020-01-13Auto merge of #5042 - JohnTitor:rustup-0112, r=phanschbors-178/+209
Rustup to rust-lang/rust#68045 This is blocked because `rustc_lint::context` is not pub module and `CheckLintNameResult` is not marked as `pub use`. changelog: none
2020-01-13Rustup to rust-lang/rust#68045Yuki Okushi-178/+209
2020-01-12Pull master, rebase, and update_lints again.xiongmao86-2/+2
2020-01-12Update lints again.xiongmao86-1/+1
2020-01-12Fix grammar error.xiongmao86-5/+5
2020-01-12Update clippy_lints/src/methods/mod.rsRui-1/+1
Co-Authored-By: Philipp Krones <hello@philkrones.com>
2020-01-12Change lint message.xiongmao86-9/+18
2020-01-12./util/dev update_lints.xiongmao86-4/+3
2020-01-12Fix documents and messages.Rui-4/+4
Update clippy_lints/src/methods/mod.rs