| Age | Commit message (Collapse) | Author | Lines |
|
|
|
|
|
Only emit lint, if `cmp` is actually available on the type being
compared. Don't emit lint in cases where only `PartialOrd` is
implemented.
|
|
Rollup of 5 pull requests
Successful merges:
- #4730 (Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body)
- #4766 (Fix false positive in derive_hash_xor_eq)
- #4811 (Literal Representation Restructure)
- #4820 (doc: fix the comment above the lint function)
- #4830 (use more efficient code to generate repeated string)
Failed merges:
r? @ghost
changelog: none
|
|
use more efficient code to generate repeated string
see https://rust.godbolt.org/z/z9vrFP for comparison
changelog: none
|
|
doc: fix the comment above the lint function
it's a simple comment fix.
---
changelog: none
|
|
Literal Representation Restructure
This pull request restructures the literal_representation module to be easier to understand and maintain. I split the changes into a lot of commits to make reviewing easier.
changelog: none
|
|
Fix false positive in derive_hash_xor_eq
This fixes a false positive in derive_hash_xor_eq where the lint was
triggering on user-defined traits called `Hash`.
changelog: Fix false positive in `derive_hash_xor_eq`
Fixes #4658
|
|
Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body
changelog: Fix check_infinite_loop (while_immutable_condition) by checking for break or return inside loop body
fixes #4648
|
|
Rollup of 4 Pull requests with new lints
Rollup of pull requests
- #4816 (New lint: zst_offset)
- #4814 (New lint: Implement ifs_same_cond_fn)
- #4807 (Add `large_stack_arrays` lint)
- #4806 (Issue/4623)
changelog: add [`zst_offset`] lint
changelog: New lint: [`ifs_same_cond_fn`]
cahngelog: Add new lint [large_stack_arrays]
changelog: added lint [`tabs_in_doc_comments`]
|
|
|
|
|
|
|
|
rollup-new-lints
|
|
|
|
|
|
Rustup to rustc 1.41.0-nightly (35ef33a8 2019-11-21)
I don't have the right fix for the fmtstr tests, and I'm also hitting problems caused by https://github.com/messense/rustc-test/issues/3
List of rustups:
- rust-lang/rust#66271 (syntax: Keep string literals in ABIs and `asm!` more precisely)
- rust-lang/rust#65355 (Stabilize `!` in Rust 1.41.0)
- rust-lang/rust#66515 (Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm`)
- rust-lang/rust#66389 (Specific labels when referring to "expected" and "found" types)
- rust-lang/rust#66074 ([mir-opt] Turn on the `ConstProp` pass by default)
changelog: none
|
|
|
|
ICEs because of rustc, not Clippy
|
|
|
|
|
|
This introduces some FNs. But a building Clippy is more important for now
|
|
|
|
Fixes #4835
|
|
Stablized in rust-lang/rust#65355
|
|
Run ./util/dev
Revert changelog entry
Rename lint to same_functions_in_if_condition and add a doc example
Add testcases with different arg in fn invocation
|
|
|
|
|
|
Co-Authored-By: Mateusz Mikuła <mati865@users.noreply.github.com>
|
|
see https://rust.godbolt.org/z/z9vrFP for comparison
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Rustup rust-lang/rust#66233
changelog: none
|
|
|
|
|
|
Simplify calculation in grouping. Add test case to ensure `count()`
can't be zero in that branch.
|
|
added documentation
minor style fix
change as to ::from
add ignore to doc
include threshold in lint message/make suggestion more apparent/use Scalar api instead of matching
style fix
shange snippet_opt to snippet
|
|
clippy-driver display help on empty command line arguments
changelog: fixes #4716, now displaying help if clippy-driver is run with no arguments.
|
|
no more must-use-candidate impls
This should help with #4779.
changelog: don't trigger [`must_use_candidate`] on trait impls
|
|
Export function for formatting literals and remove crate visibility from
other items.
|
|
Rename `grouping_hint` to `format` and use the term consistently.
|
|
Rename DigitInfo to NumericLiteral
|
|
Only store valid suffixes (and not mistyped suffixes) in DigitInfo.
Check for mistyped suffixes later and not when DigitInfo is created.
This opens the door to more sophisticated mistyped suffix checks later.
|
|
Store the digit parts directly in DigitInfo since we need them anyway.
|
|
Replace `do_lint` with `get_group_size`. Return `None` if there are no
groups.
|
|
Add `group_digits` helper function.
|