about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2020-04-18submodules: update clippy from 6651c1b9 to 891e1a85Matthias Krüger-20/+10
Changes: ```` Polished lint and tests Added final lint and tests Added basic lint and tests fix redundant_pattern_matching lint add lint futures_not_send Integrate more idiomatic rust changes. Fix issue #4892. cargo dev fmt Cleanup: Rename 'db' variable to 'diag' question_mark: don't add `as_ref()` for a call expression unit_arg suggestion may be incorrect readme: update to cargo clippy --fix command CI: performing system upgrade fixes broken apt deps on ubuntu 32bit Do not lint in macros for match lints [fix] Minor typo in GH Actions 'clippy_dev' Reenable rustfmt integration test Add test to map_flatten with an Option Lint map_flatten if caller is an Option Apply suggestions from code review manually fixing formatting at this point lol fmt rename field revert the damn fmt changes add some tests split it up for testing but the merge broke tests dogfood tasted bad fix rustfmt issue boycott manish check for unstable options Start work on clippy-fix as subcommand ````
2020-04-18Auto merge of #71147 - cuviper:min-llvm8, r=Mark-Simulacrumbors-195/+67
Update the minimum external LLVM to 8 LLVM 8 was released on March 20, 2019, over a year ago.
2020-04-17Auto merge of #71264 - Dylan-DPC:rollup-njgbey7, r=Dylan-DPCbors-81/+160
Rollup of 6 pull requests Successful merges: - #70467 (Use `call` instead of `invoke` for functions that cannot unwind ) - #71070 (rustbuild: Remove stage 0 LLD flavor workaround for MSVC) - #71167 (big-O notation: parenthesis for function calls, explicit multiplication) - #71238 (Miri: fix typo) - #71242 (Format Mailmap To Work With GitHub) - #71243 (Account for use of `try!()` in 2018 edition and guide users in the right direction) Failed merges: r? @ghost
2020-04-17Rollup merge of #71243 - Duddino:Fix2, r=estebankDylan DPC-1/+73
Account for use of `try!()` in 2018 edition and guide users in the right direction fixes #71155
2020-04-17Rollup merge of #71242 - XAMPPRocky:mailmap, r=Dylan-DPCDylan DPC-2/+2
Format Mailmap To Work With GitHub r? @Mark-Simulacrum
2020-04-17Rollup merge of #71238 - RalfJung:miri-typo, r=oli-obkDylan DPC-1/+1
Miri: fix typo r? @oli-obk at least I think this should be "without", right?
2020-04-17Rollup merge of #71167 - RalfJung:big-o, r=shepmasterDylan DPC-47/+46
big-O notation: parenthesis for function calls, explicit multiplication I saw `O(n m log n)` in the docs and found that really hard to parse. In particular, I don't think we should use blank space as syntax for *both* multiplication and function calls, that is just confusing. This PR makes both multiplication and function calls explicit using Rust-like syntax. If you prefer, I can also leave one of them implicit, but I believe explicit is better here. While I was at it I also added backticks consistently.
2020-04-17Rollup merge of #71070 - petrochenkov:nolldaround, r=Mark-SimulacrumDylan DPC-21/+0
rustbuild: Remove stage 0 LLD flavor workaround for MSVC
2020-04-17Rollup merge of #70467 - wesleywiser:invoke-vs-call, r=nagisaDylan DPC-9/+38
Use `call` instead of `invoke` for functions that cannot unwind The `FnAbi` now knows if the function is allowed to unwind. If a function isn't allowed to unwind, we can use a `call` instead of an `invoke`. This resolves an issue when calling LLVM intrinsics which cannot unwind LLVM will generate an error if you attempt to invoke them so we need to ignore cleanup blocks in codegen and generate a call instead. Fixes #69911 r? @eddyb cc @rust-lang/wg-ffi-unwind
2020-04-17Auto merge of #71255 - Dylan-DPC:rollup-u5yl04z, r=Dylan-DPCbors-56/+87
Rollup of 5 pull requests Successful merges: - #69642 (Use query to determine whether function needs const checking) - #71239 (Rename `asm` test directory in favor of `llvm_asm`) - #71246 (Implement `Clone` for `liballoc::collections::linked_list::Cursor`.) - #71247 (Remove unnecessary variable intialization) - #71254 (Minor fix and addition to doc comments) Failed merges: r? @ghost
2020-04-17Rollup merge of #71254 - JOE1994:add_comment, r=jonas-schievinkDylan DPC-3/+4
Minor fix and addition to doc comments 1. Fixed doc comment of struct 'rustc_middle::mir::Location' Currently, the general explanation of the struct appears at the field explanation section. I moved and changed the doc comments slightly, so that the general explanation would appear in the proper location in docs. 2. Added doc comment explaining 'rustc_mir::util::pretty::write_mir_fn' Unlike other counterparts, brief explanation for this function was missing, so I added one. Thank you for reviewing this PR :)
2020-04-17Rollup merge of #71247 - ldm0:minor, r=estebankDylan DPC-10/+11
Remove unnecessary variable intialization Minor fix.
2020-04-17Rollup merge of #71246 - crlf0710:linked_list_cursor, r=AmanieuDylan DPC-0/+8
Implement `Clone` for `liballoc::collections::linked_list::Cursor`. This implements `Clone` for linked list `Cursor`. Implementing `Copy` is also possible here, but i'm not sure whether i should also do it. r? @Amanieu
2020-04-17Rollup merge of #71239 - JohnTitor:llvm-asm, r=AmanieuDylan DPC-19/+19
Rename `asm` test directory in favor of `llvm_asm` r? @Amanieu
2020-04-17Rollup merge of #69642 - ecstatic-morse:issue-69615, r=oli-obkDylan DPC-24/+45
Use query to determine whether function needs const checking Resolves #69615. The HIR const-checker was checking the `constness` of a function's `fn_sig` to determine whether a function needed const-checking. Now that const trait impls are a thing, this is no longer enough. All code should use the `is_const_fn_raw` query instead, which takes the constness of the impl block into account. r? @oli-obk
2020-04-17Improved try_macro_suggestion functionDuddino-4/+2
2020-04-17Minor fix and addition to doc commentsJOE1994-3/+4
1. Fixed doc comment of struct 'rustc_middle::mir::Location' Currently, the general explanation of the struct appears at the field explanation section. I moved and changed the doc comments slightly, so that the general explanation would appear in the proper location in docs. 2. Added doc comment explaining 'rustc_mir::util::pretty::write_mir_fn' Unlike other counterparts, brief explanation for this function was missing, so I added one. Thank you for reviewing this PR :)
2020-04-17Improved try_macro_suggestionDuddino-4/+5
2020-04-17Moved is_try check into try_macro_suggestionDuddino-4/+3
2020-04-17Implement `Clone` for `liballoc::collections::linked_list::Cursor`.Charles Lew-0/+8
2020-04-17Remove unnecessary variable intializationDonough Liu-10/+11
2020-04-17Account for use of `try!()` in 2018 edition and guide users in the right ↵Duddino-0/+74
direction
2020-04-17Auto merge of #71049 - eddyb:const-err, r=oli-obkbors-408/+193
Add `ConstKind::Error` and convert `ErrorHandled::Reported` to it. By replicating the `ty::Error` approach to encoding "an error has occurred", all of the mechanisms that skip redundant/downstream errors are engaged and help out (see the reduction in test output). This PR also adds `ErrorHandled::Linted` for the lint case because using `ErrorHandled::Reported` *without* having emitted an error that is *guaranteed* to stop compilation, is incorrect now. r? @oli-obk cc @rust-lang/wg-const-eval @varkor @yodaldevoid
2020-04-17Format Mailmap To Work With GitHubXAMPPRocky-2/+2
2020-04-17Rename `asm` test directory in favor of `llvm_asm`Yuki Okushi-19/+19
2020-04-17Miri: fix typoRalf Jung-1/+1
2020-04-17Auto merge of #70629 - anyska:fields-variant, r=oli-obkbors-23/+59
rustc_target::abi: add Primitive variant to FieldsShape. Originally suggested by @eddyb.
2020-04-17Auto merge of #71230 - Dylan-DPC:rollup-rofigbv, r=Dylan-DPCbors-97/+513
Rollup of 7 pull requests Successful merges: - #70578 (Add long error explanation for E0657) - #70910 (Hides default fns inside Fuse impl to avoid exposing it to any crate) - #71164 (reword Miri validity errors: undefined -> uninitialized) - #71182 (Add some regression tests) - #71206 (Miri error messages: avoid try terminology) - #71220 (Dogfood or_patterns in the standard library) - #71225 (Fix typo in Default trait docs: Provides -> Provide) Failed merges: r? @ghost
2020-04-17Rollup merge of #71225 - leocassarani:patch-1, r=jonas-schievinkDylan DPC-1/+1
Fix typo in Default trait docs: Provides -> Provide An earlier commit (99ed06e) accidentally changed this paragraph from the original, imperative `Provide` to the present tense `Provides`. The latter is indeed the standard for Rustdoc comments relating to a function or method, but this snippet is introducing the `Default` trait in general terms and not talking about any particular function. I believe this change was likely made in error and should be reverted.
2020-04-17Rollup merge of #71220 - cuviper:std_or_patterns, r=Mark-SimulacrumDylan DPC-16/+14
Dogfood or_patterns in the standard library We can start using `or_patterns` in the standard library as a step toward stabilization. cc #54883 @Centril
2020-04-17Rollup merge of #71206 - RalfJung:dont-try, r=oli-obkDylan DPC-5/+5
Miri error messages: avoid try terminology r? @oli-obk
2020-04-17Rollup merge of #71182 - JohnTitor:regression-tests, r=Mark-SimulacrumDylan DPC-0/+64
Add some regression tests Closes #24843 Closes #28575 Closes #54067 Closes #66868 Closes #67893 Closes #68813
2020-04-17Rollup merge of #71164 - RalfJung:uninit-not-undef, r=oli-obkDylan DPC-11/+126
reword Miri validity errors: undefined -> uninitialized I don't think we say "undefined value" or anything like that anywhere in the docs or so, but we do use the term "uninitialized memory", so I think we should do the same here. Longer-term, I think we should also internally rename "undef" to "uninit". r? @oli-obk
2020-04-17Rollup merge of #70910 - rakshith-ravi:master, r=cuviperDylan DPC-63/+244
Hides default fns inside Fuse impl to avoid exposing it to any crate Fixes #70796 @cuviper I've added some default, private traits to do the job for us. If required, I can expose them to a specific visibility if you want to call these functions for #70332 r? @cuviper
2020-04-17Rollup merge of #70578 - PankajChaudhary5:master, r=GuillaumeGomezDylan DPC-1/+59
Add long error explanation for E0657 Added proper error explanation for issue E0657 in the Rust compiler. Part of #61137 r? @GuillaumeGomez
2020-04-17Auto merge of #71131 - ↵bors-22/+121
pnkfelix:issue-69798-dont-reuse-post-lto-products-when-exports-change, r=nagisa Do not reuse post LTO products when exports change Do not reuse post lto products when exports change Generalizes code from PR #67020, which handled case when imports change. Fix #69798
2020-04-16Fix typo in Default trait docs: Provides -> ProvideLeo Cassarani-1/+1
An earlier commit (99ed06e) accidentally changed this paragraph from the original, imperative "Provide" to the present tense "Provides". The latter is indeed the standard for Rustdoc comments relating to a function or method, but this snippet is introducing the Default trait in general terms and not talking about any particular function. I believe this change was likely made in error and should be reverted.
2020-04-16Auto merge of #71223 - Dylan-DPC:rollup-z5itu39, r=Dylan-DPCbors-45/+80
Rollup of 5 pull requests Successful merges: - #70611 (Add long error explanation for E0708 #61137) - #71197 (Don't use the HirId to NodeId map in MIR) - #71211 (Update cargo) - #71219 (Minor fixes to doc comments of 'VecDeque') - #71221 (Dogfood or_patterns in rustdoc) Failed merges: r? @ghost
2020-04-16Rollup merge of #71221 - cuviper:rustdoc_or_patterns, r=Mark-SimulacrumDylan DPC-30/+33
Dogfood or_patterns in rustdoc We can start using `or_patterns` in `rustdoc` as a step toward stabilization. cc #54883 @Centril
2020-04-16Rollup merge of #71219 - JOE1994:patch-4, r=Mark-SimulacrumDylan DPC-6/+6
Minor fixes to doc comments of 'VecDeque' 1. Changed descriptions of `fn get` & `fn get_mut`. Since both of these functions are returning references, and not the owned value, I thought the doc comments could be fixed to be consistent with doc comments of `fn front` & `fn front_mut`. 2. Other changes are minor fixes or additions for clarification. Thank you for taking a look :)
2020-04-16Rollup merge of #71211 - ehuss:update-cargo, r=ehussDylan DPC-0/+0
Update cargo 3 commits in 74e3a7d5b756d7c0e94399fc29fcd154e792c22a..ebda5065ee8a1e46801380abcbac21a25bc7e755 2020-04-13 20:41:52 +0000 to 2020-04-16 14:28:43 +0000 - Don't use debug display for error object. (rust-lang/cargo#8119) - Add backwards-compatibility for old cargo-tree flags. (rust-lang/cargo#8115) - Try to avoid panics on buggy (?) clocks (rust-lang/cargo#8114)
2020-04-16Rollup merge of #71197 - ljedrz:unsafe_unused, r=ecstatic-morseDylan DPC-7/+13
Don't use the HirId to NodeId map in MIR Another step towards not having to build a `HirId` to `NodeId` map other than for doc and RLS purposes. We are currently sorting `unsafe` blocks by `NodeId` in `check_unsafety`; change it to sorting by `Span` instead; this passes the tests, but better ideas are welcome. In addition, simplify the split between the used and unused `unsafe` blocks for readability and less sorting. cc https://github.com/rust-lang/rust/issues/50928
2020-04-16Rollup merge of #70611 - pawanbisht62:doc/61137-add-long-error-code-e0708, ↵Dylan DPC-2/+28
r=GuillaumeGomez Add long error explanation for E0708 #61137 Add long explanation for the E0708 error code Part of #61137 r? @GuillaumeGomez
2020-04-17Avoid emitting stderr for nowYuki Okushi-24/+2
2020-04-17Add test for issue-67893Yuki Okushi-0/+45
2020-04-17Add test for issue-54067Yuki Okushi-0/+12
2020-04-17Add test for issue-28575Yuki Okushi-0/+20
2020-04-17Add test for issue-24843Yuki Okushi-0/+9
2020-04-16Dogfood or_patterns in rustdocJosh Stone-30/+33
2020-04-16Minor fixes to doc comments of 'VecDequeue'Youngsuk Kim-6/+6
1. Changed descriptions of `fn get` & `fn get_mut`. Since both of these functions are returning references, and not the owned value, I thought the doc comments could be fixed to be consistent with doc comments of `fn front` & `fn front_mut`. 2. Other changes are minor fixes or additions for clarification. Thank you for taking a look :)