| Age | Commit message (Collapse) | Author | Lines |
|
Nilstrieb:integers-are-not-fn-ptrs-remember-this-dear-transmuter, r=compiler-errors
Never consider int and float vars for `FnPtr` candidates
This solves a regression where `0.0.cmp()` was ambiguous when a custom trait with a `cmp` method was in scope.
For integers it shouldn't be a problem in practice so I wasn't able to add a test.
I'm not sure whether there could be more issues hidden in the shadows as mentioned in the issue, but this should at least fix the problematic regression immediately.
fixes #109892
r? oli-obk
|
|
Update book, rustc-dev-guide, rust-by-example
Changes from `rust-lang/book`:
* https://github.com/rust-lang/book/pull/3598
Changes from `rust-lang/rust-by-example`:
* https://github.com/rust-lang/rust-by-example/pull/1695
* https://github.com/rust-lang/rust-by-example/pull/1694
* https://github.com/rust-lang/rust-by-example/pull/1693
* https://github.com/rust-lang/rust-by-example/pull/1688
* https://github.com/rust-lang/rust-by-example/pull/1696
Changes from `rust-lang/rustc-dev-guide`:
* https://github.com/rust-lang/rustc-dev-guide/pull/1655
* https://github.com/rust-lang/rustc-dev-guide/pull/1657
* https://github.com/rust-lang/rustc-dev-guide/pull/1659
* https://github.com/rust-lang/rustc-dev-guide/compare/d436bf134e2262dcd3527877964c9df589bf631c...fca8af6c154c6cde2512f1331cf2704f214a818e
r? `@ehuss`
|
|
Add links to <cell.rs>
`UnsafeCell` page could benefit too from having links to these most popular structs in the module.
|
|
Update contributing links for rustc-dev-guide changes
Companion PR to https://github.com/rust-lang/rustc-dev-guide/pull/1653.
- Remove unused reference link in CONTRIBUTING.md
- Change the contributing_url for triagebot to the getting started page
|
|
Use `&IndexSlice` instead of `&IndexVec` where possible
All the same reasons as for `[T]`: more general, less pointer chasing, and `&mut IndexSlice` emphasizes that it doesn't change *length*.
r? `@ghost`
|
|
This solves a regression where `0.0.cmp()` was ambiguous when a custom
trait with a `cmp` method was in scope.
FOr integers it shouldn't be a problem in practice so I wasn't able to
add a test.
|
|
Update compiler-builtins to 0.1.91 to bring in msp430 shift primitive…
… fixes.
This fixes unsoundness on MSP430 where `compiler-builtins` and LLVM didn't agree on the width of the shift amount argument of the shifting primitives (4 bytes vs 2 bytes). See https://github.com/rust-lang/compiler-builtins/pull/522 for more details.
|
|
|
|
|
|
binary_heap: Optimize Extend implementation.
This PR makes the `Extend` implementation for `BinaryHeap` no longer rely on specialization, so that it always use the bulk rebuild optimization that was previously only available for the `Vec` specialization.
|
|
|
|
Rollup of 7 pull requests
Successful merges:
- #109526 (LIBPATH is used as dylib's path environment variable on AIX)
- #109642 (check for missing codegen backeng config)
- #109722 (Implement read_buf for RustHermit)
- #109856 (fix(middle): emit error rather than delay bug when reaching limit)
- #109868 (Improve PR job names in Github Actions preview)
- #109871 (Include invocation start times)
- #109873 (Move some UI tests into subdirectories)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
Move some UI tests into subdirectories
|
|
Include invocation start times
For multi-invocation builders (e.g., dist-x86_64-linux) this timestamp is necessary to correlate the data in the metrics JSON with other data sources (e.g., logs, cpu-usage CSV, etc.). Such correlation may not be perfect but is sometimes helpful and awkward to do otherwise.
|
|
Improve PR job names in Github Actions preview
Fixes https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/PR.20CI.20job.20names.
Before: `CI / PR (mingw-check, false, ubuntu-20.04-16core-64gb) (pull_request)`
After: `CI / PR - mingw-check (pull_request)`
r? ``@jyn514``
|
|
fix(middle): emit error rather than delay bug when reaching limit
close #109304
|
|
Implement read_buf for RustHermit
In principle, this PR extends rust-lang/rust#108326 for RustyHermit.
|
|
lenko-d:rust_codegen-backends_interacts_confusingly_with_paths, r=Mark-Simulacrum
check for missing codegen backeng config
Fixes [#109610](https://github.com/rust-lang/rust/issues/109610)
|
|
LIBPATH is used as dylib's path environment variable on AIX
See https://4js.com/online_documentation/fjs-fgl-3.00.05-manual-html/c_fgl_installation_017.html.
|
|
`UnsafeCell` page could benefit too from having links to these most popular structs in the module.
|
|
fix `build --stage 2 compiler/rustc` panic
Skip assembling(which causes panic due to not found `.librustc.stamp` file) process
for stage3(since it has problems with sysroot) if full-bootstrap isn't used.
Resolves #90244
|
|
|
|
Move almost all run-make-fulldeps tests to run-make
They pass fine, and this avoids having to build the compiler twice.
There are few enough tests left that I think it should be possible to get rid of this test suite altogether, but I expect this PR to fail at least a few times in bors and want to get it merged before tackling further changes. cc https://github.com/rust-lang/rust/pull/83775
Fixes https://github.com/rust-lang/rust/issues/66085. Fixes https://github.com/rust-lang/rust/issues/83773.
|
|
All the same reasons as for `[T]`: more general, less pointer chasing, and `&mut IndexSlice` emphasizes that it doesn't change *length*.
|
|
to avoid going over the existing limit now that the ui-fulldeps tests have
been moved to ui.
|
|
For multi-invocation builders (e.g., dist-x86_64-linux) this timestamp
is necessary to correlate the data in the metrics JSON with other data
sources (e.g., logs, cpu-usage CSV, etc.). Such correlation may not be
perfect but is sometimes helpful and awkward to do otherwise.
|
|
Before: `CI / PR (mingw-check, false, ubuntu-20.04-16core-64gb) (pull_request)`
After: `CI / PR - mingw-check (pull_request)`
|
|
|
|
Use `FieldIdx` in various things related to aggregates
Shrank `AggregateKind` by 8 bytes on x64, since the active field of a union is tracked as an `Option<FieldIdx>` instead of `Option<usize>`.
Part 3/? of https://github.com/rust-lang/compiler-team/issues/606
[`IndexSlice`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_index/vec/struct.IndexVec.html#deref-methods-IndexSlice%3CI,+T%3E) was added in https://github.com/rust-lang/rust/pull/109787
|
|
Signed-off-by: ozkanonur <work@onurozkan.dev>
|
|
Replace any existing `build/host` symlink
This has two advantages:
1. If `build.build` changes between runs, the symlink is no longer silently wrong.
2. If the entire build directory is moved, the symlink is no longer broken because it points to the wrong absolute path.
|
|
This has two advantages:
1. If `build.build` changes between runs, the symlink is no longer
silently wrong.
2. If the entire build directory is moved, the symlink is no longer
broken because it points to the wrong absolute path.
|
|
Drop array patterns using subslices
Fixes #109004
Drops contiguous subslices of an array when moving elements out with a pattern, which improves perf for large arrays
r? `@compiler-errors`
|
|
Rollup of 4 pull requests
Successful merges:
- #109839 (Improve grammar of Iterator.partition_in_place)
- #109840 (Fix typo in std/src/os/fd/owned.rs)
- #109844 (a couple clippy::complexity fixes)
- #109846 (more clippy::complexity fixes (iter_kv_map, map_flatten, nonminimal_bool))
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
more clippy::complexity fixes (iter_kv_map, map_flatten, nonminimal_bool)
|
|
a couple clippy::complexity fixes
map_identity
filter_next
option_as_ref_deref
unnecessary_find_map
redundant_slicing
unnecessary_unwrap
bool_comparison
derivable_impls
manual_flatten
needless_borrowed_reference
|
|
Fix typo in std/src/os/fd/owned.rs
|
|
Improve grammar of Iterator.partition_in_place
This is my first PR against Rust, please let me know if there's anything I should be providing here! I didn't find any instructions specific to documentation grammar in the [std-dev guide](https://std-dev-guide.rust-lang.org/documentation/summary.html).
|
|
Stabilize `binary_heap_retain`
FCP finished in tracking issue: #71503
|
|
Fix `non_exhaustive_omitted_patterns` on arguments and locals
Fixes #99815
r? `@Nilstrieb`
|
|
Shrank `AggregateKind` by 8 bytes on x64, since the active field of a union is tracked as an `Option<FieldIdx>` instead of `Option<usize>`.
|
|
Add Nilstrieb to mailmap
I saw that I'm on https://thanks.rust-lang.org/ twice (once as `Nilstrieb` and once as `nils`).
This is because I've contributed as both `Nilstrieb` (locally) and `nils` (on github). So I've mailmapped them both to `Nilstrieb` (the less ambiguous of the two).
I am not entirely sure whether I've done this correctly.
|
|
bootstrap: replace `atty` with `is-terminal`, dedupe deps
`atty` reported as [unsound](https://rustsec.org/advisories/RUSTSEC-2021-0145), so replaced with `is-terminal`, also updated few crates to reduce dupes
fd-lock v3.0.8 -> v3.0.11 (https://github.com/yoshuawuyts/fd-lock/compare/v3.0.8...v3.0.11, https://github.com/yoshuawuyts/fd-lock/pull/38)
|
|
|
|
|
|
|
|
map_identity
filter_next
option_as_ref_deref
unnecessary_find_map
redundant_slicing
unnecessary_unwrap
bool_comparison
derivable_impls
manual_flatten
needless_borrowed_reference
|
|
Optimize `LazyCell` size
`LazyCell` can only store either the initializing function or the data it produces, so it does not need to reserve the space for both. Similar to #107329, but uses an `enum` instead of a `union`.
|
|
|
|
Update cargo
9 commits in 145219a9f089f8b57c09f40525374fbade1e34ae..0e474cfd7b16b018cf46e95da3f6a5b2f1f6a9e7
2023-03-27 01:56:36 +0000 to 2023-03-31 23:15:58 +0000
- Add delays to network retries. (rust-lang/cargo#11881)
- Add a note to `cargo logout` that it does not revoke the token. (rust-lang/cargo#11919)
- Sync external-tools JSON docs. (rust-lang/cargo#11918)
- Drop derive feature from serde in cargo-platform (rust-lang/cargo#11915)
- Disable test_profile test on windows-gnu (rust-lang/cargo#11916)
- src/doc/src/reference/build-scripts.md: a{n =>} benchmark target (rust-lang/cargo#11908)
- Documented working directory behaviour for `cargo test`, `cargo bench` and `cargo run` (rust-lang/cargo#11901)
- docs(contrib): Link to office hours doc (rust-lang/cargo#11903)
- chore: Upgrade to clap v4.2 (rust-lang/cargo#11904)
|