about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2025-01-08Merge pull request #18884 from Veykril/push-xwqkorxozzkqLukas Wirth-34/+40
fix: Fix `env`/`option_env` macro check disregarding macro_rules definitions
2025-01-08fix: Fix `env`/`option_env` macro check disregarding macro_rules definitionsLukas Wirth-34/+40
2025-01-08Merge pull request #18855 from Giga-Bowser/migrate-if-letLukas Wirth-154/+433
internal: Migrate `if let` replacement assists to `SyntaxEditor`
2025-01-08Merge pull request #18882 from lnicola/publish-test-fixtureLaurențiu Nicola-2/+4
minor: Fix `test-fixture` autopublishing
2025-01-08Fix test-fixture autopublishingLaurențiu Nicola-2/+4
2025-01-08Merge pull request #18877 from ChayimFriedman2/crazy-hangLaurențiu Nicola-1/+2732
fix: Fix a bug with missing binding in MBE
2025-01-07Fix a bug with missing binding in MBEChayim Refael Friedman-1/+2732
We should immediately mark them as finished, on the first entry. The funny (or sad) part was that this bug was pre-existing, but previously to #18327, it was causing us to generate bindings non-stop, 65535 of them, until we get to the hardcoded repetition limit, and then throw it all away. And it was so Blazingly Fast that nobody noticed. With #18327 however, this is still what happens, except that now instead of *merging* the fragments into the result, we write them on-demand. Meaning that when we hit the limit, we've already written all previous entries. This is a minor change, I thought for myself when I was writing this, and it's actually for the better, so who cares. Minor change? Not so fast. This caused us to emit 65535 repetitions, all of which the MBE infra needs to handle when calling other macros with the expansion, and convert to rowan tree etc., which resulted a *massive* hang. The test (and also `analysis-stats`) used to crash with stack overflow on this macro, because we were dropping some crazily deep rowan tree. Now they work properly. Because I am lazy, and also because I could not find the exact conditions that causes a macro match but with a missing binding, I just copied all macros from tracing. Easy.
2025-01-07Merge pull request #18874 from lnicola/sync-from-rustLaurențiu Nicola-9761/+378307
minor: Sync from downstream
2025-01-07Merge from rust-lang/rustLaurențiu Nicola-9760/+378306
2025-01-07Preparing for merge from rust-lang/rustLaurențiu Nicola-1/+1
2025-01-07Merge pull request #18870 from Veykril/push-vnpsptpolyolLukas Wirth-5/+0
Drop unnecessary tracing::warn
2025-01-07Merge pull request #18867 from Veykril/push-ntmxlropxkrrLukas Wirth-102/+191
internal: target-triple -> target-tuple + version fetching cleanup
2025-01-07Drop unnecessary tracing::warnLukas Wirth-5/+0
We already emit an error
2025-01-07Add some smoke tests to toolchain_infoLukas Wirth-23/+129
2025-01-07Align toolchain version fetching with other toolchain info queryingLukas Wirth-110/+93
Fix --target flag argument order in rustc_cfg fetching
2025-01-07target-triple -> target-tupleLukas Wirth-17/+17
2025-01-07Merge pull request #18788 from Veykril/push-zxystwnotuvqLukas Wirth-252/+159
Remove `rust-analyzer.cargo.sysrootQueryMetadata` config again
2025-01-07Remove `rust-analyzer.cargo.sysrootQueryMetadata` config againLukas Wirth-252/+159
2025-01-07Merge pull request #18864 from alexkirsz/alexkirsz/fix-diagnostics-clearingLukas Wirth-0/+14
fix: Fix diagnostics not clearing between flychecks
2025-01-07Merge pull request #18832 from vishruth-thimmaiah/fix_string_compChayim Refael Friedman-1/+72
fix: do not offer completions within macro strings
2025-01-07Merge pull request #18866 from bobozaur/fix-fetching-on-buildfile-changesLukas Wirth-10/+10
Fix JSON project `PackageRoot` buildfile inclusion
2025-01-07project-model: fix JSON project PackageRoot buildfile inclusionBogdan Mircea-10/+10
2025-01-07fix: do not offer completions within macro stringsVishruth-Thimmaiah-1/+72
2025-01-07lintAlex Kirszenberg-8/+6
2025-01-07fix: Fix diagnostics not clearing between flychecksAlex Kirszenberg-0/+16
2025-01-07Merge pull request #18862 from lnicola/publish-test-utilsLaurențiu Nicola-1/+1
minor: Set test-utils dependency version, since it's now published
2025-01-07Set test-utils dependency version, since it's now being publishedLaurențiu Nicola-1/+1
2025-01-07Auto merge of #135173 - pietroalbini:pa-fix-rvp, r=workingjubileebors-7/+7
Avoid replacing the definition of `CURRENT_RUSTC_VERSION` Before this PR, replace-version-placeholder hardcoded the path defining CURRENT_RUSTC_VERSION (to avoid replacing it). After a refactor moved the file defining it without changing the hardcoded path, the tool started replacing the constant itself with the version number. To avoid this from happening in the future, this changes the definition of the constant to avoid the tool from ever matching it. r? `@workingjubilee`
2025-01-07Merge pull request #18853 from ChayimFriedman2/no-completionLaurențiu Nicola-5/+105
Fix case where completion inside macro that expands to `#[test]` was unavailable
2025-01-07Auto merge of #135183 - jhpratt:rollup-qwg4pm0, r=jhprattbors-123/+812
Rollup of 9 pull requests Successful merges: - #131830 (Add support for wasm exception handling to Emscripten target) - #132345 (Improve diagnostics for `HostEffectPredicate` in the new solver) - #134568 (Release notes for 1.84.0) - #134744 (Don't ice on bad transmute in typeck in new solver) - #135090 (Suggest to replace tuple constructor through projection) - #135116 (rustdoc: Fix mismatched capitalization in sidebar) - #135126 (mark deprecated option as deprecated in rustc_session to remove copypasta and small refactor) - #135139 ([generic_assert] Constify methods used by the formatting system) - #135170 (Update triagebot.toml: celinval vacation is over) r? `@ghost` `@rustbot` modify labels: rollup
2025-01-06Rollup merge of #135170 - celinval:chores-vacation-end, r=jieyouxuJacob Pratt-2/+1
Update triagebot.toml: celinval vacation is over I'm also removing myself from the MIR syntax changes notifications.
2025-01-06Rollup merge of #135139 - c410-f3r:8-years-rfc, r=jhprattJacob Pratt-31/+11
[generic_assert] Constify methods used by the formatting system cc #44838 Starts the "constification" of all the elements required to allow the execution of the formatting system in constant environments. ```rust const _: () = { panic!("{:?}", 1i32); }; ``` Further stuff is blocked by #133999.
2025-01-06Rollup merge of #135126 - klensy:deprecated-and-do-nothing, r=jieyouxuJacob Pratt-34/+78
mark deprecated option as deprecated in rustc_session to remove copypasta and small refactor This marks deprecated options as deprecated via flag in options table in rustc_session, which removes copypasted deprecation text from rustc_driver_impl. This also adds warning for deprecated `-C ar` option, which didn't emitted any warnings before. Makes `inline_threshold` `[UNTRACKED]`, as it do nothing. Adds few tests. See individual commits.
2025-01-06Rollup merge of #135116 - camelid:sidebar-case, r=fmeaseJacob Pratt-3/+3
rustdoc: Fix mismatched capitalization in sidebar Previously, the main content used "Aliased Type", while the sidebar said "Aliased type". Now, they both say "Aliased Type", which is the more common capitalization in Rustdoc. See the following link for an example. https://doc.rust-lang.org/1.83.0/std/io/type.Result.html
2025-01-06Rollup merge of #135090 - compiler-errors:invalid-tuple-ctor-projection, ↵Jacob Pratt-1/+83
r=lqd,jieyouxu Suggest to replace tuple constructor through projection See the code example. when `Self::Assoc` normalizes to a struct that has a tuple constructor, you cannot construct the type via `Self::Assoc(field, field)`. Instead, suggest to replace it with the correct named struct. Fixes #120871
2025-01-06Rollup merge of #134744 - compiler-errors:transmute-non-wf, r=lcnrJacob Pratt-1/+105
Don't ice on bad transmute in typeck in new solver Old trait solver ends up getting its infcx tainted because we try to normalize the type, but the new trait solver doesn't. This means we try to compute the stalled transmute obligations, which tries to normalize a type an ICEs. Let's make this a delayed bug. r? lcnr
2025-01-06Rollup merge of #134568 - BoxyUwU:relnotes_1_84, r=pietroalbiniJacob Pratt-0/+116
Release notes for 1.84.0 cc ``@rust-lang/release`` r? ``@Mark-Simulacrum``
2025-01-06Rollup merge of #132345 - compiler-errors:fx-diag, r=lcnrJacob Pratt-41/+284
Improve diagnostics for `HostEffectPredicate` in the new solver Adds derived cause for host effect predicates. Some diagnostics regress, but that's connected to the fact that our predicate visitor doesn't play well with aliases just yet.
2025-01-06Rollup merge of #131830 - hoodmane:emscripten-wasm-eh, r=workingjubileeJacob Pratt-10/+131
Add support for wasm exception handling to Emscripten target This is a draft because we need some additional setting for the Emscripten target to select between the old exception handling and the new exception handling. I don't know how to add a setting like that, would appreciate advice from Rust folks. We could maybe choose to use the new exception handling if `Ctarget-feature=+exception-handling` is passed? I tried this but I get errors from llvm so I'm not doing it right.
2025-01-06Merge pull request #18858 from davidbarsky/davidbarsky/fix-18854Chayim Refael Friedman-2/+2
fix: clear diagnostics on cancel unconditionally
2025-01-06fix: clear diagnostics on cancel unconditionally, fixing #18854David Barsky-2/+2
2025-01-06Auto merge of #135172 - matthiaskrgr:rollup-8fe3fxi, r=matthiaskrgrbors-163/+269
Rollup of 7 pull requests Successful merges: - #134742 (Use `PostBorrowckAnalysis` in `check_coroutine_obligations`) - #134771 (Report correct `SelectionError` for `ConstArgHasType` in new solver fulfill) - #134951 (Suppress host effect predicates if underlying trait doesn't hold) - #135097 (bootstrap: Consolidate coverage test suite steps into a single step) - #135146 (Don't enable anyhow's `backtrace` feature in opt-dist) - #135153 (chore: remove redundant words in comment) - #135157 (Move the has_errors check in rustdoc back to after TyCtxt is created) r? `@ghost` `@rustbot` modify labels: rollup
2025-01-06rustdoc: Fix mismatched capitalization in sidebarNoah Lev-3/+3
Previously, the main content used "Aliased Type", while the sidebar said "Aliased type". Now, they both say "Aliased Type", which is the more common capitalization in Rustdoc. See the following link for an example. https://doc.rust-lang.org/1.83.0/std/io/type.Result.html
2025-01-06internal: Migrate `if let` <=> `match` assists to `SyntaxEditor`Giga Bowser-45/+53
2025-01-06internal: Migrate `replace_let_with_if_let` assist to `SyntaxEditor`Giga Bowser-15/+12
2025-01-06internal: Add some pattern constructors to `SyntaxFactory`Giga Bowser-0/+26
2025-01-06internal: Add some expr constructors to `SyntaxFactory`Giga Bowser-2/+175
2025-01-06internal: Add some path constructors to `SyntaxFactory`Giga Bowser-1/+77
2025-01-06internal: `make::expr_match` should return `ast::MatchExpr`Giga Bowser-9/+9
2025-01-06internal: Generally improve `make::match_arm`Giga Bowser-56/+53
`make::match_arm` should take a single `ast::Pat`, and callers can handle creating an `ast::OrPat` if need be. It should also take a proper `ast::MatchGuard`, instead of making one itself.