| Age | Commit message (Collapse) | Author | Lines |
|
|
|
|
|
|
|
clippy-subtree-update
|
|
r? @ghost
changelog: none
|
|
|
|
|
|
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#136906 (Add checking for unnecessary delims in closure body)
- rust-lang/rust#143652 (docs: document trait upcasting rules in `Unsize` trait)
- rust-lang/rust#143657 (Resolver: refact macro map into external and local maps)
- rust-lang/rust#143659 (Use "Innermost" & "Outermost" terminology for `AttributeOrder`)
- rust-lang/rust#143663 (fix: correct typo in attr_parsing_previously_accepted message key)
- rust-lang/rust#143666 (Re-expose nested bodies in rustc_borrowck::consumers)
- rust-lang/rust#143668 (Fix VxWorks build errors)
- rust-lang/rust#143670 (Add a new maintainer to the wasm32-wasip1 target)
- rust-lang/rust#143675 (improve lint doc text)
- rust-lang/rust#143683 (Assorted `run-make-support` maintenance)
- rust-lang/rust#143695 (Auto-add `S-waiting-on-author` when the PR is/switches to draft state)
- rust-lang/rust#143706 (triagebot.toml: ping lolbinarycat if tidy extra checks were modified)
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
triagebot.toml: ping lolbinarycat if tidy extra checks were modified
I rewrote a large chunk of this module, and plan to do further changes to it (namely moving rustdoc_js checks into it), so it would be nice to keep up with and provide feedback on any changes to it, at least for the immediate future.
r? `@Kobzol`
|
|
Auto-add `S-waiting-on-author` when the PR is/switches to draft state
This PR adds the `S-waiting-on-author` as a `new_draft` when the PR is/switches to draft state.
Related to https://github.com/rust-lang/triagebot/issues/2102 & https://github.com/rust-lang/triagebot/pull/2104
cc `@jieyouxu`
r? `@Kobzol`
|
|
Assorted `run-make-support` maintenance
This PR should contain no functional changes.
- Commit 1: Removes the support library's CHANGELOG. In the very beginning, I thought maybe we would try to version this library. But this is a purely internal test support library, and it's just extra busywork trying to maintain changelog/versions. It's also hopelessly outdated.
- Commit 2: Resets version number to `0.0.0`. Ditto on busywork.
- Commit 3: Bump `run-make-support` to Edition 2024. The support library was already "compliant" with Edition 2024.
- Commit 4: Slightly organizes the support library dependencies.
- Commit 5: Previously, I tried hopelessly to maintain some manual formatting, but that was annoying because it required skipping rustfmt (so export ordering etc. could not be extra formatted). Give up, and do some rearrangements / module prefix tricks to get the `lib.rs` looking at least *reasonable*. IMO this is not a strict improvement, but I rather regain the ability to auto-format it with rustfmt.
- Commit {6,7}: Noticed in rust-lang/rust#143669 that we apparently had *both* {`is_msvc`, `is_windows_msvc`}. This PR removes `is_msvc` in favor of `is_windows_msvc` to make it unambiguous (and only retain one way of gating) as there are some UEFI targets which are MSVC but not Windows.
Best reviewed commit-by-commit.
r? `@Kobzol`
|
|
improve lint doc text
|
|
r=alexcrichton
Add a new maintainer to the wasm32-wasip1 target
cc: `@alexcrichton`
|
|
Fix VxWorks build errors
fixes rust-lang/rust#143442
r? ``@Noratrieb``
|
|
Re-expose nested bodies in rustc_borrowck::consumers
After https://github.com/rust-lang/rust/pull/138499, it's not possible anymore to get borrowck information for nested bodies via `get_body_with_borrowck_facts`. This PR re-exposes nested bodies by returning a map containing the typeck root and all its nested bodies. To collect the bodies, a map is added to `BorrowCheckRootCtxt`, and a body is inserted every time `do_mir_borrowck` is called.
r? ``@lcnr``
|
|
fix: correct typo in attr_parsing_previously_accepted message key
|
|
Use "Innermost" & "Outermost" terminology for `AttributeOrder`
Follow-up to rust-lang/rust#143603.
https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/attribute.20parsing.20rework/near/527768926
Also remove some outdated comments. cc `@jdonszelmann`
|
|
Resolver: refact macro map into external and local maps
Puts `MacroData` inside of the `ResolverArena` and splits `macro_map` into 2 maps: `local_macro_map` and `external_macro_map`. This way `get_macro_by_def_id` can take a `&Resolver` instead of a mutable one.
Part of [#gsoc > Project: Parallel Macro Expansion](https://rust-lang.zulipchat.com/#narrow/channel/421156-gsoc/topic/Project.3A.20Parallel.20Macro.20Expansion/with/516965603)
r? `@petrochenkov`
|
|
docs: document trait upcasting rules in `Unsize` trait
The trait upcasting feature stabilized in 1.86 added new `Unsize` implementation, but this wasn't reflected in the trait's documentation.
|
|
Add checking for unnecessary delims in closure body
Fixes #136741
|
|
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#141996 (Fix `proc_macro::Ident`'s handling of `$crate`)
- rust-lang/rust#142950 (mbe: Rework diagnostics for metavariable expressions)
- rust-lang/rust#143011 (Make lint `ambiguous_glob_imports` deny-by-default and report-in-deps)
- rust-lang/rust#143265 (Mention as_chunks in the docs for chunks)
- rust-lang/rust#143270 (tests/codegen/enum/enum-match.rs: accept negative range attribute)
- rust-lang/rust#143298 (`tests/ui`: A New Order [23/N])
- rust-lang/rust#143396 (Move NaN tests to floats/mod.rs)
- rust-lang/rust#143398 (tidy: add support for `--extra-checks=auto:` feature)
- rust-lang/rust#143644 (Add triagebot stdarch mention ping)
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
Add triagebot stdarch mention ping
r? ````@Amanieu````
|
|
tidy: add support for `--extra-checks=auto:` feature
in preparation for rust-lang/rust#142924
also heavily refactored the parsing of the `--extra-checks` argument to warn about improper usage.
cc ```@GuillaumeGomez```
r? ```@Kobzol```
|
|
Move NaN tests to floats/mod.rs
This PR moves NaN tests to `floats/mod.rs`, as discussed in rust-lang/rust#141726. Since this is my first PR against Rust, I'm keeping it as small as possible, but I intend to work my way through the remaining tests and can do that work in this PR if that's preferable.
r? RalfJung
|
|
`tests/ui`: A New Order [23/N]
> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.
Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang/rust#133895.
r? ``@tgross35``
|
|
tests/codegen/enum/enum-match.rs: accept negative range attribute
The test current fails when `rustc` is built with HEAD LLVM: https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/38097/steps/canvas?sid=0197c492-5661-4c42-8ae7-3d789e85c6ca
I suspect the change was caused by https://github.com/llvm/llvm-project/commit/545cdca4883552b147a0f1adfac713f76fc22305
``@rustbot`` label llvm-main
|
|
Mention as_chunks in the docs for chunks
and `as_rchunks_mut` from `rchunks_exact_mut`, and such.
As suggested in https://github.com/rust-lang/rust/issues/76354#issuecomment-3015376438 (but does not close that issue).
|
|
r=petrochenkov
Make lint `ambiguous_glob_imports` deny-by-default and report-in-deps
This pr aims to finish the second part of rust-lang/rust#114095. It converts the `ambiguous_glob_imports` lint from a warning to an error.
Currently, only the lint definition and the related tests are changed, a crater run should provide us with information on whether we should go for this.
|
|
mbe: Rework diagnostics for metavariable expressions
Make the diagnostics for metavariable expressions more user-friendly. This mostly addresses syntactic errors; I will be following up with improvements to `concat(..)`.
|
|
Fix `proc_macro::Ident`'s handling of `$crate`
This PR is addresses a few minor bugs, all relating to `proc_macro::Ident`'s support for `$crate`. `Ident` currently supports `$crate` (as can be seen in the `mixed-site-span` test), but:
* `proc_macro::Symbol::can_be_raw` is out of sync with `rustc_span::Symbol::can_be_raw`
* former doesn't cover `$crate` while the latter does cover `kw::DollarCrate`
* `Ident::new` rejects `$crate`
* This conflicts with the [reference definition](https://doc.rust-lang.org/nightly/reference/macros-by-example.html#r-macro.decl.meta.specifier) of `ident` which includes `$crate`.
* This also conflicts with the documentation on [`Display for Ident`](https://doc.rust-lang.org/proc_macro/struct.Ident.html#impl-Display-for-Ident) which says the output "should be losslessly convertible back into the same identifier".
This PR fixes the above issues and extends the `mixed-site-span` test to exercise these fixed code paths, as well as validating the different possible spans resolve `$crate` as expected (for both the new and old `$crate` construction code paths).
|
|
Add opaque TypeId handles for CTFE
Reopen of https://github.com/rust-lang/rust/pull/142789#issuecomment-3053155043 after some bors insta-merge chaos
r? `@RalfJung`
|
|
|
|
And not both `is_windows_msvc` and `is_msvc`.
|
|
|
|
|
|
Update LLVM submodule
Picks up <https://github.com/rust-lang/llvm-project/pull/183>
r? `@nikic`
|
|
|
|
|
|
Change to a structural diagnostic, update the valid list, and move the
valid list to a note.
|
|
Give a more user-friendly diagnostic about the following:
* Trailing tokens within braces, e.g. `${foo() extra}`
* Missing parentheses, e.g. `${foo}`
* Incorrect number of arguments, with a hint about correct usage.
|
|
Update the `compiler-builtins` subtree
Update the Josh subtree to https://github.com/rust-lang/compiler-builtins/commit/8aba4c899ee8.
r? `@ghost`
|
|
Closes rust-lang/rust-clippy#15063
----
changelog: [`op_ref`]: fix wrongly showed macro definition in
suggestions
changelog: [`needless_bool_assign`]: fix missing curlies when on else if
|
|
|
|
local_macro_map.
|
|
|
|
When comparing `x.map(func) == Some(bool_lit)`, the value of `bool_lit`
was ignored, despite the fact that its value should determine the value
of the proposed expression.
`func` can be either a closure or a path. For the latter, η-expansion
will be used if needed to invert the result of the function call.
changelog: [`manual_is_variant_and`]: fix inverted suggestions that
could lead to code with different semantics
Fixes rust-lang/rust-clippy#15202
<!-- TRIAGEBOT_START -->
<!-- TRIAGEBOT_SUMMARY_START -->
### Summary Notes
-
[Beta-nomination](https://github.com/rust-lang/rust-clippy/pull/15206#issuecomment-3034006613)
by [samueltardieu](https://github.com/samueltardieu)
*Managed by `@rustbot`—see
[help](https://forge.rust-lang.org/triagebot/note.html) for details*
<!-- TRIAGEBOT_SUMMARY_END -->
<!-- TRIAGEBOT_END -->
|
|
|
|
|
|
Instantiate auto trait/`Copy`/`Clone`/`Sized` before computing constituent types binder
This makes the binder logic w.r.t. coroutines a bit simpler.
r? lcnr
|
|
Let `rvalue_creates_operand` return true for *all* `Rvalue::Aggregate`s
~~Draft for now because it's built on Ralf's rust-lang/rust#143291~~
Inspired by https://github.com/rust-lang/rust/pull/138759#discussion_r2156375342 where I noticed that we were nearly at this point, plus the comments I was writing in rust-lang/rust#143410 that reminded me a type-dependent `true` is fine.
This PR splits the `OperandRef::builder` logic out to a separate type, with the updates needed to handle SIMD as well. In doing so, that makes the existing `Aggregate` path in `codegen_rvalue_operand` capable of handing SIMD values just fine.
As a result, we no longer need to do layout calculations for aggregate result types when running the analysis to determine which things can be SSA in codegen.
|