| Age | Commit message (Collapse) | Author | Lines |
|---|
|
|
|
Rollup of 3 pull requests
Successful merges:
- #124313 (Detect borrow error involving sub-slices and suggest `split_at_mut`)
- #124374 (Don't ICE when `codegen_select_candidate` returns ambiguity in new solver)
- #124380 (`Range` iteration specialization: remove trivial bounds)
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
|
|
|
|
|
|
And avoid duplicating logic for visiting `Item`s with different kinds (regular, associated, foreign).
|
|
|
|
uses a `ProofTreeVisitor` to look into nested
goals when looking at the pending obligations
during hir typeck. Used by closure signature
inference, coercion, and for async functions.
|
|
Instead, use raw pointers to accomplish internal mutability throughout.
|
|
`#[collapse_debuginfo]`
`-Z debug-macros` is "stabilized" by enabling it by default and removing.
`-Z collapse-macro-debuginfo` is stabilized as `-C collapse-macro-debuginfo`.
It now supports all typical boolean values (`parse_opt_bool`) in addition to just yes/no.
Default value of `collapse_debuginfo` was changed from `false` to `external` (i.e. collapsed if external, not collapsed if local).
`#[collapse_debuginfo]` attribute without a value is no longer supported to avoid guessing the default.
|
|
`Range` iteration specialization: remove trivial bounds
These bounds on impl items are trivially true and never checked by a caller. They end up shadowing the actual impls, currently preventing normalization in the new solver. While we may have to fix the underlying issue in the new solver at some point, for now this is an easy way to get us closer to compiling core with `-Znext-solver`.
r? `@Nilstrieb`
|
|
Don't ICE when `codegen_select_candidate` returns ambiguity in new solver
Because we merge identical candidates, we may have >1 impl candidate to in `codegen_select_error` but *not* have a trait error.
r? lcnr
|
|
Detect borrow error involving sub-slices and suggest `split_at_mut`
```
error[E0499]: cannot borrow `foo` as mutable more than once at a time
--> $DIR/suggest-split-at-mut.rs:13:18
|
LL | let a = &mut foo[..2];
| --- first mutable borrow occurs here
LL | let b = &mut foo[2..];
| ^^^ second mutable borrow occurs here
LL | a[0] = 5;
| ---- first borrow later used here
|
= help: use `.split_at_mut(position)` or similar method to obtain two mutable non-overlapping sub-slices
```
Address most of #58792.
For follow up work, we should emit a structured suggestion for cases where we can identify the exact `let (a, b) = foo.split_at_mut(2);` call that is needed.
|
|
|
|
|
|
|
|
Rollup of 2 pull requests
Successful merges:
- #124287 (Improved code with clippy)
- #124326 (tests: remove few ignore-stage2)
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
tests: remove few ignore-stage2
beta was branched long ago, so can be removed
|
|
Improved code with clippy
I haven't used the bootstrapped compiler, but I think I have made some improvements using clippy. I have already made the following changes to the compiler:
Replaced `self.first().is_digit(10)` with `self.first().is_ascii_digit()` on lines 633, 664, and 680 of compiler/rust_lexer/src/lib.rs.
Removed unnecessary cast on line 262 of compiler/rustc_lexer/src/unescape.rs
Replaced ok_or_else with ok_or on line 303 of compiler/rustc_lexer/src/unescape.rs
Replaced `!std::env::var("RUSTC_BOOTSTRAP").is_ok()` with `std::env::var("RUSTC_BOOTSTRAP").is_err()` on line 4 of compiler/rustc_macros/build.rs
Removed needless borrow for generic argument `env`on line 53 of compiler/rust_llvm/build.rs
|
|
|
|
|
|
Emit suggestion when encountering
```rust
let a = &mut foo[0];
let b = &foo[1];
a.use_mut();
```
|
|
|
|
```
error[E0499]: cannot borrow `foo` as mutable more than once at a time
--> $DIR/suggest-split-at-mut.rs:13:18
|
LL | let a = &mut foo[..2];
| --- first mutable borrow occurs here
LL | let b = &mut foo[2..];
| ^^^ second mutable borrow occurs here
LL | a[0] = 5;
| ---- first borrow later used here
|
= help: use `.split_at_mut(position)` or similar method to obtain two mutable non-overlapping sub-slices
```
Address most of #58792.
For follow up work, we should emit a structured suggestion for cases where we can identify the exact `let (a, b) = foo.split_at_mut(2);` call that is needed.
|
|
|
|
`super::super` of `rustc_hir_typeck::fn_ctxt::_impl`
is just `rustc_hir_typeck`.
|
|
|
|
Enforce closure args + return type are WF
I found this out when investigating https://github.com/rust-lang/rust/issues/123461#issuecomment-2040894359. Turns out we don't register WF obligations for closure args and return types, leading to the ICE.
~~I think this is a useful thing to check for, but I'd like to check what the fallout is.~~ crater is complete.
~~Worst case, I think we should enforce this across an edition boundary (and possibly eventually migrate this for all editions) -- this should be super easy to do, since this is a check in HIR wfcheck, so it can be made edition dependent.~~ I believe the regressions are manageable enough to not necessitate edition-specific behavior.
Fixes #123461
|
|
|
|
|
|
|
|
Fix some typos in comments
|
|
Miri subtree update
r? `@ghost`
|
|
|
|
CI: run benches with hyperfine rather than bash
The hyperfine installation is cached so this should not cost a lot of CI time.
This is step 1/2 to getting rid of the BASH variable hack.
|
|
|
|
Suggest ref mut for pattern matching assignment
Fixes #118596
|
|
add a test for the TLS memory leak
This is a regression test for https://github.com/rust-lang/rust/issues/123583.
|
|
|
|
|
|
|
|
beta was branched long ago, so can be removed
|
|
make miri-script a workspace root
This is needed to make miri-script build on stable (as is done by the `./miri` script) when the parent package uses unstable cargo features.
|
|
Automatic Rustup
|
|
Rollup of 3 pull requests
Successful merges:
- #124257 (Rewrite the `no-input-file.stderr` test in Rust and support diff)
- #124324 (Minor AST cleanups)
- #124327 (CI: implement job skipping in Python matrix calculation)
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
CI: don't run cron-fail-notify when the job just got canceled
Doesn't seem right to prepare a PR in that case
|
|
For code clarity.
|
|
|
|
|
|
|
