about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2025-01-12fix: Fix `ref` text edit for binding mode hintsLukas Wirth-2/+27
2025-01-11Merge pull request #18913 from Wilfred/grammar_fixLaurențiu Nicola-4/+4
minor: Fix grammar in doc comments
2025-01-10minor: Fix grammar in doc commentsWilfred Hughes-4/+4
"too" should be "to" here.
2025-01-10Merge pull request #18907 from Veykril/push-uqlzpttmvurvLukas Wirth-2/+86
Implement `#[rust_analyzer::skip]` for bodies
2025-01-10Implement `#[rust_analyzer::skip]` for bodiesLukas Wirth-2/+86
2025-01-10Merge pull request #18906 from Veykril/push-upuxsyovskmtLukas Wirth-173/+386
feat: Re-implement rust string highlighting via tool attribute
2025-01-10Re-implement rust string highlighting via tool attributeLukas Wirth-173/+386
2025-01-10Merge pull request #18904 from Veykril/push-yztnorquuyzwLukas Wirth-24/+134
Improve hover module path rendering
2025-01-10Merge pull request #18903 from Veykril/push-mqmworppxuywLukas Wirth-12/+192
Implement implicit sized bound inlay hints
2025-01-10Implement implicit sized bound inlay hintsLukas Wirth-12/+192
2025-01-10Improve hover module path renderingLukas Wirth-24/+134
2025-01-10Merge pull request #18900 from ChayimFriedman2/stupid-hangLukas Wirth-7/+7
fix: Do not compute `prettify_macro_expansion()` unless the "Inline macro" assist has actually been invoked
2025-01-10Merge pull request #18902 from Veykril/push-znlsxykqrkooLukas Wirth-133/+184
internal: Add Definition::Crate
2025-01-10internal: Add Definition::CrateLukas Wirth-133/+184
This is its own thing so it should be handled specifically where possible
2025-01-10Merge pull request #18901 from ChayimFriedman2/hir-reexportLukas Wirth-23/+28
minor: Remove two hir reexports
2025-01-10Merge pull request #18813 from Giga-Bowser/syntax-tree-viewLukas Wirth-701/+812
feat: Add a new and improved syntax tree view
2025-01-10Merge pull request #18899 from ChayimFriedman2/issue-18898Lukas Wirth-5/+85
fix: Fix another issue with fixup reversing
2025-01-10Remove two hir reexportsChayim Refael Friedman-23/+28
2025-01-10Do not compute `prettify_macro_expansion()` unless the "Inline macro" assist ↵Chayim Refael Friedman-7/+7
has actually been invoked And not just called to be listed. This was a major performance hang when repeatedly switching back-and-forth between a large `include!`d file (but there are others)..
2025-01-09Add an action to copy an element from the syntax tree viewGiga Bowser-0/+55
2025-01-09Fix another issue with fixup reversingChayim Refael Friedman-5/+85
We need to *remove* the whole subtree, but we don't advance `i` by this, because it hasn't gotten there yet (and never will).
2025-01-09Remove the old syntax tree viewerGiga Bowser-700/+1
2025-01-09Add a new and improved syntax tree viewerGiga Bowser-4/+759
2025-01-09Merge pull request #18889 from ChayimFriedman2/subtle-completionLukas Wirth-1/+2
fix: Fix actual token lookup in completion's `expand()`
2025-01-09Merge pull request #18880 from PrototypeNM1/extra-includesLukas Wirth-3/+67
Add config setting which allows adding additional include paths to the VFS.
2025-01-09Merge pull request #18861 from ChayimFriedman2/await-editionLukas Wirth-316/+480
fix: Make edition per-token, not per-file
2025-01-09Merge pull request #18885 from qjerome/refactor-cargo-cfgsLukas Wirth-14/+21
refactor: struct holding cargo cfgs settings
2025-01-09Merge pull request #18890 from Veykril/push-nwnozlyppvzoLukas Wirth-5/+7
minor: Fixup macro error kinds
2025-01-09minor: Fixup macro error kindsLukas Wirth-5/+7
2025-01-09Merge pull request #18887 from vishruth-thimmaiah/refactor_completions_testsLukas Wirth-448/+322
refactor test helpers within ide-completions
2025-01-09Merge pull request #18524 from Giga-Bowser/migrate-wrap-unwrap-returnLukas Wirth-121/+295
internal: Migrate `(un)wrap_return_type` assists to use `SyntaxEditor`
2025-01-09Make edition per-token, not per-fileChayim Refael Friedman-316/+480
More correctly, *also* per-token. Because as it turns out, while the top-level edition affects parsing (I think), the per-token edition affects escaping of identifiers/keywords.
2025-01-09Fix actual token lookup in completion's `expand()`Chayim Refael Friedman-1/+2
It should be left biased, not right biased, because when e.g. the use has typed `h` then requested completion, the `h` is what we want to find, not the next token (which might indeed be inside a macro call). I'm not sure why I wrote `right_biased()` to begin with (I remember I had a reason and not just "both should work"), I might've copied the code in `expand_and_analyze()` (which is wrong, because there it lookups on the speculative file, where right biased will always find the correct token and left biased not). This is still not perfect, because there might not be an identifier already typed then we might still end up in a macro call, but this is the best we can do.
2025-01-08minor: Use placeholders in `unwrap_return_type`Giga Bowser-2/+53
2025-01-08internal: Migrate `unwrap_return_type` assist to use `SyntaxEditor`Giga Bowser-58/+76
Also changes `make::expr_empty_block()` to return `ast::BlockExpr` instead of `ast::Expr`
2025-01-08internal: Migrate `wrap_return_type` assist to use `SyntaxEditor`Giga Bowser-63/+168
2025-01-08Add config setting which allows adding additional include paths to the VFS.Nicholas Rishel-3/+67
2025-01-08refactor test helpers within ide-completionsVishruth-Thimmaiah-448/+322
2025-01-08fix: requested changedqjerome-9/+4
2025-01-08fix: autogenerate filesqjerome-9/+12
2025-01-08refactor: struct holding cargo cfgs settingsqjerome-6/+15
2025-01-08Merge pull request #18884 from Veykril/push-xwqkorxozzkqLukas Wirth-34/+40
fix: Fix `env`/`option_env` macro check disregarding macro_rules definitions
2025-01-08fix: Fix `env`/`option_env` macro check disregarding macro_rules definitionsLukas Wirth-34/+40
2025-01-08Merge pull request #18855 from Giga-Bowser/migrate-if-letLukas Wirth-154/+433
internal: Migrate `if let` replacement assists to `SyntaxEditor`
2025-01-08Merge pull request #18882 from lnicola/publish-test-fixtureLaurențiu Nicola-2/+4
minor: Fix `test-fixture` autopublishing
2025-01-08Fix test-fixture autopublishingLaurențiu Nicola-2/+4
2025-01-08Merge pull request #18877 from ChayimFriedman2/crazy-hangLaurențiu Nicola-1/+2732
fix: Fix a bug with missing binding in MBE
2025-01-07Fix a bug with missing binding in MBEChayim Refael Friedman-1/+2732
We should immediately mark them as finished, on the first entry. The funny (or sad) part was that this bug was pre-existing, but previously to #18327, it was causing us to generate bindings non-stop, 65535 of them, until we get to the hardcoded repetition limit, and then throw it all away. And it was so Blazingly Fast that nobody noticed. With #18327 however, this is still what happens, except that now instead of *merging* the fragments into the result, we write them on-demand. Meaning that when we hit the limit, we've already written all previous entries. This is a minor change, I thought for myself when I was writing this, and it's actually for the better, so who cares. Minor change? Not so fast. This caused us to emit 65535 repetitions, all of which the MBE infra needs to handle when calling other macros with the expansion, and convert to rowan tree etc., which resulted a *massive* hang. The test (and also `analysis-stats`) used to crash with stack overflow on this macro, because we were dropping some crazily deep rowan tree. Now they work properly. Because I am lazy, and also because I could not find the exact conditions that causes a macro match but with a missing binding, I just copied all macros from tracing. Easy.
2025-01-07Merge pull request #18874 from lnicola/sync-from-rustLaurențiu Nicola-9761/+378307
minor: Sync from downstream
2025-01-07Merge from rust-lang/rustLaurențiu Nicola-9760/+378306