about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2019-09-04Auto merge of #4501 - derivmug:update-lint-doc, r=phanschbors-1/+1
Remove ui/ from TESTNAME for foo lint example changelog: Remove ui/ from TESTNAME in doc/adding-lints.md This PR remove the `ui/` from the TESTNAME of the example foo lint in the 'Adding lints' documentation.
2019-09-04Remove ui/ from TESTNAME for foo lint exampleLuca Beetz-1/+1
2019-09-04Auto merge of #4495 - JohnTitor:fix-map-entry-false-positive, r=phanschbors-1/+16
Fix `map_entry` false positive Fixes #4219 changelog: Fix `map_entry` false positive
2019-09-05Improve testsYuki Okushi-1/+8
2019-09-04Auto merge of #4487 - JohnTitor:deref-addrof-external-macro, r=flip1995bors-1/+12
Don't check across macro boundary in `deref_addrof` Fixes #4289 changelog: Allow `deref_addrof` in macros
2019-09-04Auto merge of #4418 - euclio:byte-lit-suggestion, r=flip1995bors-26/+90
use a structured suggestion for char-lit-as-u8 changelog: use a structured suggestion for char-lit-as-u8
2019-09-04Run update_lintsflip1995-1/+1
2019-09-04use a structured suggestion for char-lit-as-u8Andy Russell-25/+89
2019-09-04Auto merge of #4498 - sinkuu:checked_arithmetic_unwrap, r=flip1995bors-2/+482
Add manual_saturating_arithmetic lint changelog: add `manual_saturating_arithmetic` lint Fixes #1557. This lint detects manual saturating arithmetics like `x.checked_add(10u32).unwrap_or(u32::max_value())` and suggests replacing with `x.saturating_add(10u32)`.
2019-09-04Hide variables in doc-testShotaro Yamada-8/+8
2019-09-04Fix doctest and renaming srcShotaro Yamada-6/+8
2019-09-04Auto merge of #4490 - mikerite:fix-4364, r=flip1995bors-142/+167
Fix `too_many_lines` false positive changelog: Fix `too_many_lines` false positive
2019-09-04Add manual_saturating_arithmetic lintShotaro Yamada-2/+480
2019-09-04Auto merge of #4454 - BO41:search_is_some, r=flip1995bors-59/+94
Dereference one less on search_is_some and make it auto-fixable Fixes #4453 changelog: none
2019-09-03Try to fix .fixedBO41-348/+49
2019-09-03Auto merge of #4479 - rust-lang:uninit_assume_init, r=flip1995bors-2/+118
lint against `MaybeUninit::uninit().assume_init()` changelog: add `uninit_assumed_init` lint This fixes #4272
2019-09-03lint against `MaybeUninit::uninit().assume_init()`Andre Bogus-2/+118
2019-09-03Auto merge of #4486 - lzutao:fix-panic-unseparate-literals, r=flip1995bors-1/+2
Fix index out of bound in case of empty snippet cc #4480 changelog: none
2019-09-03Fix `map_entry` false positiveYuki Okushi-1/+9
2019-09-03Auto merge of #4493 - JohnTitor:fix-build-bytes, r=flip1995bors-3/+6
Rustup to rust-lang/rust#63561 changelog: none
2019-09-03Remove Allocation::bytesYuki Okushi-3/+6
2019-09-03Fix occurrences of `too_many_lines` violationsMichael Wright-140/+164
2019-09-03Fix `too_many_lines` false positiveMichael Wright-2/+3
Fixes #4364
2019-09-03Allow deref_addrof in macrosYuki Okushi-1/+12
2019-09-02Fix index out of bound in case of empty snippetLzu Tao-1/+2
2019-09-02Auto merge of #4482 - awoimbee:doc_explicit_counter_loop, r=flip1995bors-8/+7
fix misleading doc for explicit_counter_loop lint changelog: replace misleading examples for explicit_counter_loop & more concise `Why is it bad?` section This fixes #4472
2019-09-02Auto merge of #4477 - mikerite:fix-4291, r=flip1995bors-7/+58
Fix `extra_unused_lifetimes` false positive Fixes #4291 changelog: Fix `extra_unused_lifetimes` false positive
2019-09-01fix misleading doc for explicit_counter_loop lintArthur Woimée-8/+7
2019-09-01Fix `needless_lifetimes` false positiveMichael Wright-7/+39
2019-09-01Simplify issue-4291 testMichael Wright-13/+11
2019-08-31Fix `extra_unused_lifetimes` false positiveMichael Wright-2/+23
Fixes #4291
2019-08-30Auto merge of #4473 - phansch:fix_cast_lossless_fp, r=flip1995bors-0/+48
Fix cast_lossless false positive in impl const fn Fixes https://github.com/rust-lang/rust-clippy/issues/3656#issuecomment-526387382 changelog: Fix false positive in `cast_lossless`
2019-08-30Auto merge of #4475 - flip1995:rustup, r=phanschbors-2/+2
Rustup to rust-lang/rust#60966 changelog: none
2019-08-30Rustup to rust-lang/rust#60966flip1995-2/+2
2019-08-30Auto merge of #4446 - mikerite:fix-4437, r=phanschbors-3/+76
Fix `match_as_ref` bad suggestion Fixes #4437 changelog: Fix `match_as_ref` bad suggestion
2019-08-30Fix cast_lossless false positive in impl const fnPhilipp Hansch-0/+48
Fixes https://github.com/rust-lang/rust-clippy/issues/3656#issuecomment-526387382
2019-08-29Auto merge of #4450 - phansch:fix_const_fn_fp, r=flip1995bors-4/+63
Fix missing_const_for_fn false positive We don't want to lint if the type of the method implements drop. (constant functions cannot evaluate destructors) changelog: Fix `missing_const_for_fn` false positive Fixes #4449
2019-08-29Add missing UI test changePhilipp Hansch-1/+9
2019-08-29Fix testsflip1995-2/+2
2019-08-29Use the spans returned by utils::method_callsflip1995-25/+31
2019-08-29Also return the method spans in utils::method_callsflip1995-3/+5
2019-08-29Dereference one less on search_is_some and make it auto-fixableBO41-37/+363
2019-08-29Auto merge of #4408 - phansch:more_rustfix_tests, r=flip1995bors-60/+129
More rustfix tests <!-- Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only updates to the latest nightly, you can leave the `changelog` entry as `none`. Otherwise, please write a short comment explaining your change. If your PR fixes an issue, you can add "fixes #issue_number" into this PR description. This way the issue will be automatically closed when your PR is merged. If you added a new lint, here's a checklist for things that will be checked during review or continuous integration. - [ ] Followed [lint naming conventions][lint_naming] - [ ] Added passing UI tests (including committed `.stderr` file) - [ ] `cargo test` passes locally - [ ] Executed `./util/dev update_lints` - [ ] Added lint documentation - [ ] Run `./util/dev fmt` [lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints Note that you can skip the above if you are just opening a WIP PR in order to get feedback. Delete this line and everything above before opening your PR --> cc #3630 This is probably easier reviewed per-commit. changelog: none
2019-08-29Auto merge of #4469 - vityafx:master, r=flip1995bors-22/+26
Improve the cognitive_complexity lint's warning. Adds the value of complexity limit set for the lint to the warning. Fixes #4466 Signed-off-by: Victor Polevoy <fx@thefx.co> changelog: improve the `cognitive_complexity` lint's warning message.
2019-08-29Improve cognitive_complexity lint's warning.Victor Polevoy-22/+26
Adds the value of complexity limit set for the lint to the warning. Fixes #4466 Signed-off-by: Victor Polevoy <fx@thefx.co>
2019-08-29Merge branch 'master' into fix-4437Michael Wright-181/+680
2019-08-29Fix missing_const_for_fn false positivePhilipp Hansch-3/+54
We don't want to lint if any of the input parameters implement drop. (constant functions cannot evaluate destructors)
2019-08-28Make useless_attribute suggestion MaybeIncorrectPhilipp Hansch-53/+3
2019-08-28Auto merge of #4465 - JohnTitor:add-note-to-fix-toolstate, r=flip1995bors-1/+17
Add note to fix toolstate The idea from https://github.com/rust-lang/rust-clippy/pull/4462#issuecomment-525725587 It's nice that we have the documentation to guide fix toolstate. changelog: none
2019-08-29Add note to fix toolstateYuki Okushi-1/+17
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-03-01 14:02:36 +0000