about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2023-01-13Consolidate two almost duplicated fn info extraction routinesMichael Goulet-185/+183
2023-01-13Auto merge of #106776 - oli-obk:om_nom_nom_nom_nom, r=cjgillotbors-46/+29
Feed a bunch of queries instead of tracking fields on TyCtxt r? `@cjgillot` pulled out of https://github.com/rust-lang/rust/pull/105462
2023-01-13Auto merge of #106801 - JohnTitor:rollup-xqkraw0, r=JohnTitorbors-153/+338
Rollup of 6 pull requests Successful merges: - #106608 (Render missing generics suggestion verbosely) - #106716 ([RFC 2397] Deny incorrect locations) - #106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`) - #106782 (Ignore tests move in git blame) - #106785 (Make blame spans better for impl wfcheck) - #106791 (Fix ICE formatting) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
2023-01-13Rollup merge of #106791 - estebank:fix-ice, r=compiler-errorsYuki Okushi-1/+1
Fix ICE formatting
2023-01-13Rollup merge of #106785 - compiler-errors:better-impl-wf-spans, r=estebankYuki Okushi-83/+106
Make blame spans better for impl wfcheck r? types
2023-01-13Rollup merge of #106782 - albertlarsan68:ignore-test-move-in-blame, r=NilstriebYuki Okushi-0/+2
Ignore tests move in git blame This commit is not relevant in the history, but may clobber the git blame output.
2023-01-13Rollup merge of #106754 - compiler-errors:ty-infer-method-is-confusing, r=lcnrYuki Okushi-11/+14
Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer` Makes sure people are aware that they may have a type variable *or* an int/float variable. r? `@oli-obk` https://github.com/rust-lang/rust/pull/106322#issuecomment-1376913539 but I could instead implement your solution, let me know. (This will conflict with #106322 for now, ignore that :smile:)
2023-01-13Rollup merge of #106716 - c410-f3r:rfc-2397-1, r=davidtwcoYuki Okushi-2/+121
[RFC 2397] Deny incorrect locations cc #51992 As declared in the RFC, `#[do_not_recommend]` should only be applicable on trait implementations.
2023-01-13Rollup merge of #106608 - compiler-errors:missing-generics-verbose, r=estebankYuki Okushi-56/+94
Render missing generics suggestion verbosely It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline. Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
2023-01-13Auto merge of #106092 - asquared31415:start_lang_item_checks, r=davidtwcobors-3/+405
Add checks for the signature of the `start` lang item Closes #105963
2023-01-13Ignore tests move in git blameAlbert Larsan-0/+2
2023-01-13Auto merge of #106004 - fee1-dead-contrib:const-closures, r=oli-obkbors-48/+249
Const closures cc https://github.com/rust-lang/rust/issues/106003
2023-01-13Auto merge of #101138 - Rejyr:diagnostic-migration-rustc-lint-pt2, r=davidtwcobors-1374/+2295
Migrate `rustc_lint` lint diagnostics Part 2 of [Migrate `rustc_lint` errors to `SessionDiagnostic`](https://github.com/rust-lang/rust/pull/100776) r? `@davidtwco` # TODO - [x] Refactor some lints manually implementing `DecorateLint` to use `Option<Subdiagnostic>`. - [x] Add `#[rustc_lint_diagnostics]` to lint functions in `context.rs`. - [x] Migrate `hidden_unicode_codepoints.rs`. - [x] Migrate `UnsafeCode` in `builtin.rs`. - [x] Migrate the rest of `builtin.rs`.
2023-01-12is_ty_infer -> is_ty_or_numeric_inferMichael Goulet-11/+14
2023-01-12Fix ICE formattingEsteban Küber-1/+1
2023-01-12Auto merge of #106786 - JohnTitor:rollup-8f4vk8m, r=JohnTitorbors-177/+177
Rollup of 8 pull requests Successful merges: - #105795 (Stabilize `abi_efiapi` feature) - #106446 ([LSDA] Take ttype_index into account when taking unwind action) - #106675 (Mark ZST as FFI-safe if all its fields are PhantomData) - #106740 (Adding a hint on iterator type errors) - #106741 (Fix reexport of `doc(hidden)` item) - #106759 (Revert "Make nested RPITIT inherit the parent opaque's generics.") - #106772 (Re-add mw to review rotation) - #106778 (Exclude formatting commit from blame) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
2023-01-12Only point at impl self ty in WF if trait predicate shares self tyMichael Goulet-38/+45
2023-01-12Don't suggest dyn as parameter to addMichael Goulet-24/+11
2023-01-12Render missing generics suggestion verboselyMichael Goulet-52/+103
2023-01-13Rollup merge of #106778 - RReverser:patch-1, r=dtolnayYuki Okushi-0/+2
Exclude formatting commit from blame Excludes https://github.com/rust-lang/rust/commit/c34fbfaad38cf5829ef5cfe780dc9d58480adeaa (cc `@dtolnay)` to make Git blame a bit more useful.
2023-01-13Rollup merge of #106772 - michaelwoerister:triagebot-rotation, r=wesleywiserYuki Okushi-0/+1
Re-add mw to review rotation r? `@wesleywiser`
2023-01-13Rollup merge of #106759 - compiler-errors:revert-105255, r=cjgillotYuki Okushi-2/+18
Revert "Make nested RPITIT inherit the parent opaque's generics." This reverts commit e2d41f4c974f0cc09e5aafb02883f222487610f9, and adjusts the `tests/ui/async-await/in-trait/nested-rpit.rs` test. r? `@cjgillot` fixes #106332, manually verified because it had no minimization :/ reopens #105197 cc #106729
2023-01-13Rollup merge of #106741 - GuillaumeGomez:reexport-doc-hidden, r=notriddleYuki Okushi-3/+44
Fix reexport of `doc(hidden)` item Part of #59368. It doesn't fix the `doc(inline)` nor the `doc(hidden)` on macro. I'll do it in a follow-up PR. r? `@notriddle`
2023-01-13Rollup merge of #106740 - petar-dambovaliev:float-iterator-hint, r=NilstriebYuki Okushi-0/+34
Adding a hint on iterator type errors Issue reference https://github.com/rust-lang/rust/issues/106728 - [x] add a case in the attribute - [x] add a test closes #106728
2023-01-13Rollup merge of #106675 - krtab:fix_improper_ctypes, r=davidtwcoYuki Okushi-23/+45
Mark ZST as FFI-safe if all its fields are PhantomData This presents one possible solution to issue: #106629. This is my first (tentative) contribution to the compiler itself. I'm looking forward for comments and feedback Closes: #106629
2023-01-13Rollup merge of #106446 - bzEq:fix-unwind-lsda, r=AmanieuYuki Okushi-9/+22
[LSDA] Take ttype_index into account when taking unwind action If `cs_action != 0`, we should check the `ttype_index` field in action record. If `ttype_index == 0`, a clean up action is taken; otherwise catch action is taken. This can fix unwind failure on AIX which uses LLVM's libunwind by default. IIUC, rust's LSDA is borrowed from c++ and I'm assuming itanium-cxx-abi https://itanium-cxx-abi.github.io/cxx-abi/exceptions.pdf should be followed, so the fix follows what libcxxabi does. See https://github.com/llvm/llvm-project/blob/ec48682ce9f61d056361c5095f21e930b8365661/libcxxabi/src/cxa_personality.cpp#L152 for use of `ttype_index`.
2023-01-13Rollup merge of #105795 - nicholasbishop:bishop-stabilize-efiapi, r=joshtriplettYuki Okushi-140/+11
Stabilize `abi_efiapi` feature Tracking issue: https://github.com/rust-lang/rust/issues/65815 Closes #65815
2023-01-12Point at impl self type for impl wf obligationsMichael Goulet-97/+97
2023-01-12Point at HIR types when impl trait ref doesn't normalizeMichael Goulet-22/+38
2023-01-12Auto merge of #106780 - flip1995:clippyup, r=Manishearthbors-850/+1879
Update Clippy r? `@Manishearth`
2023-01-12Merge commit '7f27e2e74ef957baa382dc05cf08df6368165c74' into clippyupPhilipp Krones-850/+1879
2023-01-12Auto merge of #10192 - Jarcho:revert_9701, r=flip1995bors-233/+109
Partially revert #9701 This partially reverts #9701 due to #10134 r? `@flip1995` changelog: None
2023-01-12Adjust old code for newer rustc version.Jason Newcomb-3/+4
2023-01-12Revert 4dbd8ad34e7f6820f6e9e99531353e7ffe37b76a, ↵Jason Newcomb-234/+109
c7dc96155853a3919b973347277d0e9bcaaa22f0, ed519ad746e31f64c4e9255be561785612532d37 and c6477eb71188311f01f409da628fab7062697bd7
2023-01-12Auto merge of #10191 - flip1995:rustup, r=flip1995bors-64/+64
Rustup r? `@ghost` changelog: none
2023-01-12Also add rustc_driver to clippy_utilsPhilipp Krones-0/+3
I'm not sure why this is necessary. It worked without this for me locally, but this fails in CI. The same was done in clippy_dev
2023-01-12Bump nightly version -> 2023-01-12Philipp Krones-1/+1
2023-01-12Merge remote-tracking branch 'upstream/master' into rustupPhilipp Krones-660/+1808
2023-01-12Exclude formatting commit from blameIngvar Stepanyan-0/+2
Excludes https://github.com/rust-lang/rust/commit/c34fbfaad38cf5829ef5cfe780dc9d58480adeaa to make Git blame a bit more useful.
2023-01-12Auto merge of #10149 - jyn514:duplicate-sysroot, r=flip1995bors-1/+20
Don't pass `--sysroot` twice if SYSROOT is set This is useful for rust-lang/rust to allow setting a sysroot that's *only* for build scripts, different from the regular sysroot passed in RUSTFLAGS (since cargo doesn't apply RUSTFLAGS to build scripts or proc-macros). That said, the exact motivation is not particularly important: this fixes a regression from https://github.com/rust-lang/rust-clippy/pull/9881/commits/5907e9155ed7f1312d108aa2110853472da3b029#r1060215684. Note that only RUSTFLAGS is tested in the new integration test; passing --sysroot through `clippy-driver` never worked as far as I can tell, and no one is using it, so I didn't fix it here. Helps with https://github.com/rust-lang/rust/pull/106394. --- changelog: other: `SYSROOT` and `--sysroot` can now be set at the same time [#10149](https://github.com/rust-lang/rust-clippy/pull/10149) <!-- changelog_checked -->
2023-01-12Add cargo-clippy sysroot testPhilipp Krones-69/+36
Whne SYSROOT is defined, clippy-driver will insert a --sysroot argument when calling rustc. However, when a sysroot argument is already defined, e.g. through RUSTFLAGS=--sysroot=... the `cargo clippy` call would error. This tests that the sysroot argument is only passed once and that SYSROOT is ignored in this case.
2023-01-12Don't pass `--sysroot` twice if SYSROOT is setJoshua Nelson-25/+77
This is useful for rust-lang/rust to allow setting a sysroot that's *only* for build scripts, different from the regular sysroot passed in RUSTFLAGS (since cargo doesn't apply RUSTFLAGS to build scripts or proc-macros). That said, the exact motivation is not particularly important: this fixes a regression from https://github.com/rust-lang/rust-clippy/pull/9881/commits/5907e9155ed7f1312d108aa2110853472da3b029#r1060215684. Note that only RUSTFLAGS is tested in the new integration test; passing --sysroot through `clippy-driver` never worked as far as I can tell, and no one is using it, so I didn't fix it here.
2023-01-12Feed the `features_query` instead of grabbing it from the session lazilyOli Scherer-5/+5
2023-01-12Remove `output_filenames` field from TyCtxt and feed the query insteadOli Scherer-9/+4
2023-01-12Remove `untracked_crate` field and instead pass it along with the resolver.Oli Scherer-12/+9
2023-01-12Feed `crate_name` queryOli Scherer-13/+7
2023-01-12Feed `resolutions` query instead of it being a thin wrapper around an ↵Oli Scherer-9/+6
untracked field
2023-01-12Auto merge of #106773 - Nilstrieb:rollup-sq73pyg, r=Nilstriebbors-111/+395
Rollup of 6 pull requests Successful merges: - #105806 (Support eager subdiagnostics again) - #106322 (Handle inference variables in `CollectAllMismatches` correctly) - #106579 (Suggest making private tuple struct field public) - #106714 (remove unreachable error code `E0490`) - #106751 (Fix rendering 'const' in header for intrinsics) - #106761 (Add `WaffleLapkin` to compiler reviewers) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
2023-01-12Add test for displayed re-export of `doc(hidden)`Guillaume Gomez-0/+26
2023-01-12Fix not displayed re-export of `doc(hidden)` itemGuillaume Gomez-3/+18