about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2019-04-28travis: sort integration test jobs so that the jobs taking the most time are ↵Matthias Krüger-14/+15
run first
2019-04-28Auto merge of #4042 - matthiaskrgr:toml_update, r=Manishearthbors-1/+1
deps: bump toml from 0.4 to 0.5 changelog: none
2019-04-28deps: bump toml from 0.4 to 0.5Matthias Krüger-1/+1
2019-04-28Auto merge of #4040 - mikerite:fix-build-20190428, r=Manishearthbors-74/+78
Fix breakage due to rust-lang/rust#60225 Wrote this up before I saw that Manish already started on a fix in #4038. It no doubt contains errors. Feel free to close.
2019-04-28Fix breakage due to rust-lang/rust#60225Michael Wright-74/+78
2019-04-25Auto merge of #4008 - g-bartoszek:boxed-fnmut, r=phanschbors-1/+49
Do not trigger redundant_closure for non-function types fixes #3898 Added a check for the entity being called in the closure body to be a FnDef. This way lint does not trigger for ADTs (Box) but I'm not sure if it's correct and not too restrictive. <!-- Thank you for making Clippy better! We're collecting our changelog from pull request descriptions. If your PR only updates to the latest nightly, you can leave the `changelog` entry as `none`. Otherwise, please write a short comment explaining your change. If your PR fixes an issue, you can add "fixes #issue_number" into this PR description. This way the issue will be automatically closed when your PR is merged. If you added a new lint, here's a checklist for things that will be checked during review or continuous integration. - [ ] Followed [lint naming conventions][lint_naming] - [ ] Added passing UI tests (including committed `.stderr` file) - [ ] `cargo test` passes locally - [ ] Executed `util/dev update_lints` - [ ] Added lint documentation - [ ] Run `cargo fmt` Note that you can skip the above if you are just opening a WIP PR in order to get feedback. Delete this line and everything above before opening your PR --> changelog: Fix false positive in `redundant_closure` pertaining to non-function types
2019-04-25Auto merge of #4026 - cemiloten:working-on-#3981, r=flip1995bors-3/+18
Attempt to fix #3981 Fixes #3981 Hi, hopefully this is correct, happy to have feedback. changelog: Don't trigger `unnecessary_cast` inside a macro
2019-04-25Ignore unnecessary cast if inside macrocemil-3/+18
2019-04-25Auto merge of #4029 - phansch:update_pulldown_cmark, r=oli-obkbors-41/+24
Update pulldown_cmark to 0.5 We now no longer have to use our own wrapper around `Parser` and can use the new `OffsetIter`. changelog: none
2019-04-25Auto merge of #4028 - phansch:skip_appveyor_on_pr_pushes, r=phanschbors-5/+5
Only run AppVeyor on r+, try and the master branch As it is right now, there is only one worker available in the `rust-lang-libs` AppVeyor project and there are other repos as well that we share this worker with. This has been a problem for us because we sometimes hit a bors timeout if there are too many builds queued up. To improve the situation, I think we could try to use AppVeyor a bit less often. The average PR is not going to break windows related things anyway, so it should be fine to run it on r+/try/master only. changelog: none
2019-04-25Auto merge of #4030 - phansch:rustup190425, r=Manishearthbors-6/+5
Rustup for https://github.com/rust-lang/rust/pull/59042 changelog: none
2019-04-25Rustup for https://github.com/rust-lang/rust/pull/59042Philipp Hansch-6/+5
2019-04-24Update pulldown_cmark to 0.5Philipp Hansch-41/+24
We now no longer have to use our own wrapper around `Parser` and can use the new `OffsetIter`.
2019-04-24Auto merge of #4027 - kraai:remove-approx_constant-known-problems, r=phanschbors-4/+1
Remove approx_constant known problems Fixes #4025. changelog: Remove `approx_constant`'s documentation's "Known problems" section.
2019-04-24Only run AppVeyor on r+, try and the master branchPhilipp Hansch-5/+5
As it is right now, there is only one worker available in the `rust-lang-libs` AppVeyor project and there are other repos as well that we share this worker with. This has been a problem for us because we sometimes hit a bors timeout if there are too many builds queued up. To improve the situation, I think we could try to use AppVeyor a bit less often. The average PR is not going to break windows related things anyway, so it should be fine to run it on r+/try/master only.
2019-04-24Auto merge of #4023 - phansch:add_test, r=flip1995bors-1/+11
Add test for or_fun_call macro suggestion changelog: none Closes #1018
2019-04-24Remove approx_constant known problemsMatthew Kraai-4/+1
Fixes #4025.
2019-04-24Auto merge of #4022 - phansch:move_some_loop_tests, r=flip1995bors-228/+234
UI test cleanup: Extract needless_range_loop tests changelog: none
2019-04-24Auto merge of #4024 - kraai:suppress-let_and_return-if-let-has-attributes, ↵bors-1/+7
r=flip1995 Suppress let_and_return if let has attributes Fixes #3882. changelog: suppress `let_and_return` if `let` has attributes
2019-04-23Suppress let_and_return if let has attributesMatthew Kraai-1/+7
Fixes #3882.
2019-04-24Add test for or_fun_call macro suggestionPhilipp Hansch-1/+11
Closes #1018
2019-04-24UI test cleanup: Extract needless_range_loop testsPhilipp Hansch-228/+234
2019-04-24Auto merge of #4021 - kraai:change-cast_lossless-warning, r=Manishearthbors-32/+32
Change "if types change" to "if you later change the type" Fixes #3964. changelog: change wording of `cast_lossless` message
2019-04-23Change "if types change" to "if you later change the type"Matthew Kraai-32/+32
Fixes #3964.
2019-04-23Auto merge of #4018 - rust-lang:or_fn_call_variants, r=oli-obkbors-5/+41
Ignore non-const ctor expressions in or_fn_call Fixes https://github.com/rust-lang/rust-clippy/issues/1338 Should have been fixed by #919, however that focuses on const ctor expressions only, and `.or(Some(local))` isn't const. This also automatically ignores things like `.or(Some(local.clone())` which we don't actually want to do; I need to figure out what to do here. changelog: Fixed false positive in [`or_fn_call`] pertaining to enum variant constructors r? @oli-obk @phansch
2019-04-23Auto merge of #4020 - rust-lang:rustup, r=phanschbors-1/+1
Rustup to rustc 1.36.0-nightly (fe0a415b4 2019-04-23) r? @oli-obk @phansch
2019-04-23Rustup to rustc 1.36.0-nightly (fe0a415b4 2019-04-23)Manish Goregaokar-1/+1
2019-04-23Add testManish Goregaokar-0/+18
2019-04-23Ignore all enum and struct constructors in lints about `*or(call())`Manish Goregaokar-5/+23
2019-04-23Auto merge of #4017 - Xanewok:wip-disambiguate-extern, r=oli-obkbors-2/+25
compiletest: Disambiguate extern crate deps shared with the compiler Fixes #4015. changelog: Handle deps shared with the compiler in the internal compiletest suite Attempts to fix the multiple matching crates error using the `--extern dep=path` disambiguation. This only includes `serde` at the moment because it's the only problematic dep right now (is inside Rust sysroot and pulled via `extern crate` in the test suite). I'm not exactly sure this is the right approach (FWIW it fixes the issue locally), please do tell if this should be done differently.
2019-04-23compiletest: Disambiguate extern crate deps shared with the compilerIgor Matuszewski-2/+25
2019-04-21Auto merge of #4013 - kraai:move-path_buf_push_overwrite-to-nursery, ↵bors-5/+6
r=matthiaskrgr Move path_buf_push_overwrite to nursery See #4012. changelog: move `path_buf_push_overwrite` to the nursery
2019-04-21Auto merge of #4014 - Xanewok:rustup-60124, r=matthiaskrgrbors-1/+2
rustup: Use newly-introduced mutability query for statics Fixes fallout from https://github.com/rust-lang/rust/pull/60124. cc https://github.com/rust-lang/rust/issues/60154 changelog: none
2019-04-21Use newly-introduced mutability query for staticsIgor Matuszewski-1/+2
Fixes fallout from https://github.com/rust-lang/rust/pull/60124. cc https://github.com/rust-lang/rust/issues/60154
2019-04-21Move path_buf_push_overwrite to nurseryMatthew Kraai-5/+6
See #4012.
2019-04-20redundant closure triggers for fnptrs and closuresGrzegorz-2/+37
2019-04-20Auto merge of #4011 - phansch:add_test_for_derive_expansion, r=flip1995bors-6/+21
Add test for derives for used_underscore_binding lint This closes #852 as I can't reproduce the original issue anymore. changelog: none
2019-04-20Auto merge of #4007 - phansch:fix_allowing_toplevel_ref_arg, r=flip1995bors-6/+11
Allow allowing of toplevel_ref_arg lint I'm not sure why some lints need the `HirId` to be able to recognize the lint level attributes, but this commit makes the lint level attributes work for `toplevel_ref_arg`. Fixes #2332 changelog: Allow allowing of `toplevel_ref_arg` lint
2019-04-20Auto merge of #4005 - phansch:rustfix_match_as_ref, r=flip1995bors-38/+60
Add run-rustfix for match_as_ref lint * Extracts `match_as_ref` into separate file * Adds `// run-rustfix` to `tests/ui/match_as_ref.rs` cc #3630 changelog: none
2019-04-20Auto merge of #4006 - phansch:fix_module_name_repetitions_fp, r=flip1995bors-23/+33
Fix false positive in module_name_repetitions lint This lint was triggering on modules inside expanded attrs, like for example `#[cfg(test)]` and possibly more. It was not reporting a location in #3892 because `span.lo()` and `span.hi()` both were 0. Fixes #3892 changelog: Fix false positive in `module_name_repetitions` lint
2019-04-20Add test for derives for used_underscore_binding lintPhilipp Hansch-6/+21
This closes #852 as I can't reproduce the original issue anymore.
2019-04-19Auto merge of #4009 - phansch:update_compiletest, r=phanschbors-1/+1
Update compiletest_rs This includes a fix that make ICEs appear in UI tests again.
2019-04-19Update compiletest_rsPhilipp Hansch-1/+1
This includes a fix that make ICEs appear in UI tests again.
2019-04-19Allow allowing of toplevel_ref_arg lintPhilipp Hansch-6/+11
I'm not sure why some lints need the `HirId` to be able to recognize the lint level attributes, but this commit makes the lint level attributes work for `toplevel_ref_arg`.
2019-04-19redundant closure for functions restricted to FnDefsGrzegorz-0/+13
2019-04-19Fix false positive in module_name_repetitions lintPhilipp Hansch-23/+33
This lint was triggering on modules inside expanded attrs, like for example `#[cfg(test)]` and possibly more.
2019-04-19Add run-rustfix for match_as_ref lintPhilipp Hansch-38/+60
* Extracts `match_as_ref` into separate file * Adds `// run-rustfix` to `tests/ui/match_as_ref.rs`
2019-04-19Auto merge of #3989 - flip1995:assert_on_const, r=phanschbors-41/+42
Don't trigger assertions_on_constants on debug_assert!(false) Fixes #3948 Fixes #3765 changelog: Fix `debug_assert!` false positive on `assertions_on_constants` lint
2019-04-18Auto merge of #3990 - felixrabe:patch-1, r=flip1995bors-1/+1
Typo changelog: none
2019-04-18Auto merge of #3978 - phansch:rustfix_len_zero, r=flip1995bors-163/+367
Add run-rustfix for len_zero lint * Extracts len_without_is_empty into separate file * Adds `// run-rustfix` to `tests/ui/len_zero.rs` cc #3630
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-03-01 11:03:11 +0000