about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2019-10-18Improve comments and structure of `ConstProp::const_prop()`Wesley Wiser-32/+50
Per code review feedback
2019-10-18Don't ICE when evaluating writes to uninhabited enum variantsWesley Wiser-13/+48
2019-10-18Cleanup const_prop() someWesley Wiser-72/+75
2019-10-18[const-prop] Handle MIR Rvalue::BoxWesley Wiser-18/+57
2019-10-18[const-prop] Handle MIR Rvalue::DiscriminantWesley Wiser-2/+55
2019-10-18[const-prop] Handle MIR Rvalue::AggregatesWesley Wiser-7/+75
2019-10-18[const-prop] Handle MIR Rvalue::RepeatWesley Wiser-2/+46
2019-10-18Auto merge of #65533 - Manishearth:clippyup, r=Manishearthbors-7/+7
Update clippy None
2019-10-17Update clippyManish Goregaokar-7/+7
2019-10-17Auto merge of #65495 - Centril:rollup-tguwjt5, r=Centrilbors-634/+782
Rollup of 8 pull requests Successful merges: - #65237 (Move debug_map assertions after check for err) - #65316 (make File::try_clone produce non-inheritable handles on Windows) - #65319 (InterpCx: make memory field public) - #65461 (Don't recommend ONCE_INIT in std::sync::Once) - #65465 (Move syntax::ext to a syntax_expand and refactor some attribute logic) - #65475 (add example for type_name) - #65478 (fmt::Write is about string slices, not byte slices) - #65486 (doc: fix typo in OsStrExt and OsStringExt) Failed merges: r? @ghost
2019-10-17Auto merge of #64595 - Mark-Simulacrum:trivial-query, r=pnkfelixbors-66/+73
Optimize dropck This does two things: caches the `trivial_dropck` check by making it a query, and shifts around the implementation of the primary dropck itself to avoid allocating many small vectors.
2019-10-17Rollup merge of #65486 - mathstuf:osstr-doc-typo, r=TimNNMazdak Farrokhzad-4/+4
doc: fix typo in OsStrExt and OsStringExt
2019-10-17Rollup merge of #65478 - RalfJung:write, r=jonas-schievinkMazdak Farrokhzad-2/+2
fmt::Write is about string slices, not byte slices No idea why the docs talk about bytes, maybe a copy-paste error?
2019-10-17Rollup merge of #65475 - lzutao:eg_type_name, r=CentrilMazdak Farrokhzad-0/+9
add example for type_name So users of this function could at least expect what its output for current compiler version.
2019-10-17Rollup merge of #65465 - Centril:split-syntax-1, r=petrochenkovMazdak Farrokhzad-600/+709
Move syntax::ext to a syntax_expand and refactor some attribute logic Part of https://github.com/rust-lang/rust/pull/65324. r? @petrochenkov
2019-10-17Rollup merge of #65461 - Kampfkarren:patch-1, r=CentrilMazdak Farrokhzad-3/+2
Don't recommend ONCE_INIT in std::sync::Once ONCE_INIT is deprecated, and so suggesting it as not only being on par with, but before `Once::new` is a bad idea.
2019-10-17Rollup merge of #65319 - RalfJung:memory, r=CentrilMazdak Farrokhzad-17/+6
InterpCx: make memory field public I made this field private forever ago because I thought sealing things might be nice. But with the `memory_mut` getter it doesn't actually seal anything, and it's not like we need to invalidate caches on writes to memory or so. And moreover, having to use the getters leads to some annoying borrow checking interactions. So, let's just make it public (again). r? @oli-obk
2019-10-17Rollup merge of #65316 - oconnor663:noninheritable, r=alexcrichtonMazdak Farrokhzad-1/+1
make File::try_clone produce non-inheritable handles on Windows ~**NOT READY FOR REVIEW.** This PR is currently mainly to trigger CI so that I can see what happens. (Is there a better way to trigger CI?) I don't know whether this change makes sense yet.~ (Edit: @Mark-Simulacrum clarified that CI doesn't currently run on Windows.) --- File handles shouldn't be inheritable in general. `std::process::Command` takes care of making them inheritable when child processes are spawned, and the `CREATE_PROCESS_LOCK` protects against races in that section on Windows. But `File::try_clone` has been creating inheritable file descriptors outside of that lock, which could be leaking into other child processes unintentionally. See also https://github.com/rust-lang/rust/pull/31069#discussion_r334117665.
2019-10-17Rollup merge of #65237 - KodrAus:fix/map-entry-err, r=sfacklerMazdak Farrokhzad-7/+49
Move debug_map assertions after check for err Fixes #65231 We have some assertions in `DebugMap` to catch broken implementations of `Debug` that produce malformed entries. These checks don't make sense if formatting fails partway through. This PR moves those assertions to within the `and_then` closures along with the other formatting logic, so they're only checked if the map hasn't failed to format an entry already.
2019-10-17Auto merge of #59953 - eddyb:soa-metadata, r=michaelwoeristerbors-876/+857
rustc_metadata: replace Entry table with one table for each of its fields (AoS -> SoA). In https://github.com/rust-lang/rust/pull/59789#issuecomment-481958212 I noticed that for many cross-crate queries (e.g. `predicates_of(def_id)`), we were deserializing the `rustc_metadata::schema::Entry` for `def_id` *only* to read one field (i.e. `predicates`). But there are several such queries, and `Entry` is not particularly small (in terms of number of fields, the encoding itself is quite compact), so there is a large (and unnecessary) constant factor. This PR replaces the (random-access) array¹ of `Entry` structures ("AoS"), with many separate arrays¹, one for each field that used to be in `Entry` ("SoA"), resulting in the ability to read individual fields separately, with negligible time overhead (in thoery), and some size overhead (as these arrays are not sparse). In a way, the new approach is closer to incremental on-disk caches, which store each query's cached results separately, but it would take significantly more work to unify the two. For stage1 `libcore`'s metadata blob, the size overhead is `8.44%`, and I have another commit (~~not initially included because I want to do perf runs with both~~ **EDIT**: added it now) that brings it down to `5.88%`. ¹(in the source, these arrays are called "tables", but perhaps they could use a better name)
2019-10-17Auto merge of #65251 - tlively:emscripten-upstream-upgrade, r=tlivelybors-603/+438
Upgrade Emscripten targets to use upstream LLVM backend - Compatible with Emscripten 1.38.46-upstream or later upstream. - Refactors the Emscripten target spec to share code with other wasm targets. - Replaces the old incorrect wasm32 C call ABI with the correct one, preserving the old one as wasm32_bindgen_compat for wasm-bindgen compatibility. - Updates the varargs ABI used by Emscripten and deletes the old one. - Removes the obsolete wasm32-experimental-emscripten target. - Uses EMCC_CFLAGS on CI to avoid the timeout problems with #63649. r? @alexcrichton
2019-10-16Remove PR runs, enable wasm32 CI, and move asmjs to disabledThomas Lively-6/+2
2019-10-16doc: fix typo in OsStrExt and OsStringExtBen Boeckel-4/+4
2019-10-17Auto merge of #65234 - GuillaumeGomez:long-err-explanation-E0573, r=kinnisonbors-5/+87
Add long error explanation for E0573 Part of #61137.
2019-10-16User should not change between emcc install and useThomas Lively-12/+6
2019-10-16Update test expectationsThomas Lively-1/+1
2019-10-16Update test and add -O1 to wasm32 DockerfileThomas Lively-2/+3
2019-10-16Temporarily enable asmjs and wasm32 on PR CIThomas Lively-0/+4
2019-10-16Upgrade Emscripten targets to use upstream LLVM backendThomas Lively-538/+378
- Compatible with Emscripten 1.38.46-upstream or later upstream. - Refactors the Emscripten target spec to share code with other wasm targets. - Replaces the old incorrect wasm32 C call ABI with the correct one, preserving the old one as wasm32_bindgen_compat for wasm-bindgen compatibility. - Updates the varargs ABI used by Emscripten and deletes the old one. - Removes the obsolete wasm32-experimental-emscripten target. - Uses EMCC_CFLAGS on CI to avoid the timeout problems with #63649.
2019-10-16fmt::Write is about string slices, not byte slicesRalf Jung-2/+2
2019-10-16panictry!(..) -> .unwrap()Mazdak Farrokhzad-2/+2
2019-10-16Auto merge of #63756 - Zoxc:sharded-dep-graph-1, r=nikomatsakisbors-60/+72
Use more fine grained locks for the dep graph Split out from https://github.com/rust-lang/rust/pull/61845. r? @michaelwoerister cc @aturon
2019-10-16add example for type_nameLzu Tao-0/+9
2019-10-16Auto merge of #65445 - ehuss:update-cargo-books, r=alexcrichtonbors-0/+0
Update cargo, books ## nomicon 3 commits in 4374786f0b4bf0606b35d5c30a9681f342e5707b..5004ad30d69f93553ceef74439fea2159d1f769e 2019-09-17 18:33:21 +0200 to 2019-10-12 19:52:40 +0200 - further clarify C11 and C/C++11 terminology (rust-lang-nursery/nomicon#169) - atomics: C11 -> C++20 (rust-lang-nursery/nomicon#168) - use sound/unsound terminology ## cargo 12 commits in a429e8cc4614a46a86322a0777a477e2baa83f1c..3a9abe3f065554a7fbc59f440df2baba4a6e47ee 2019-10-04 17:36:12 +0000 to 2019-10-15 15:55:35 +0000 - Fix typo in git index initialization error path (rust-lang/cargo#7512) - Reject feature flags in a virtual workspace. (rust-lang/cargo#7507) - Rename `overrides` to `package` in profiles. (rust-lang/cargo#7504) - Allow publishing with dev-dependencies without a version. (rust-lang/cargo#7333) - Stabilize cache-messages (rust-lang/cargo#7450) - don't lock the package cache when cleaning target dir. (rust-lang/cargo#7502) - Document rustc wrapper (rust-lang/cargo#7499) - Migrate towards exclusively using serde for `Config` (rust-lang/cargo#7456) - Re-enable some MSVC tests. (rust-lang/cargo#7492) - when -Z unstable-options not specified, don't validate --profile (rust-lang/cargo#7489) - Improve error message for cyclic dependencies (rust-lang/cargo#7470) - Some minor clippy fixes. (rust-lang/cargo#7484) ## book 7 commits in 04806c80be0f54b1290287e3f85e84bdfc0b6ec7..9bb8b161963fcebc9d9ccd732ba26f42108016d5 2019-10-01 20:20:22 -0400 to 2019-10-14 18:42:55 -0500 - Make a portion of text less ambiguous (rust-lang/book#2092) - fix heading level (rust-lang/book#2117) - Add missing "of" before `"duck typing"`. (rust-lang/book#1951) - ch18-03: no need to debug print destructured int (rust-lang/book#1991) - Subtle fix to introduce ? on Option in Chapter 9.2 (rust-lang/book#2047) - make wording clearer (rust-lang/book#1976) - Update the version of rand we use ## rust-by-example 5 commits in a6288e7407a6c4c19ea29de6d43f40c803883f21..0b111eaae36cc4b4997684be853882a59e2c7ca7 2019-10-01 10:09:14 -0300 to 2019-10-14 18:34:25 -0300 - Some fix to three files (rust-lang/rust-by-example#1280) - Add reference to Generics (rust-lang/rust-by-example#1281) - Confusing and long sentence (rust-lang/rust-by-example#1282) - Explicit mention of slice range meaning (rust-lang/rust-by-example#1277) - Updated aliasing for nll (rust-lang/rust-by-example#1276)
2019-10-16ui-fulldeps: make them pass again?Mazdak Farrokhzad-9/+13
2019-10-16Update cargo, booksEric Huss-0/+0
2019-10-16Auto merge of #65172 - tanriol:explain_borrow-use-context-dominators, r=nagisabors-1/+1
use precalculated dominators in explain_borrow This looks like the only place calculating dominators from the MIR body every time instead of using the ones stored on the `MirBorrowckCtxt`. For example, in rust-lang/rust#65131 a big generated function with a number of borrowck errors takes a few hours(!) recalculating the dominators while explaining the errors. I don't know enough about this part of rustc codebase to know for sure that this change is correct, but no tests seem to fail as a result of this change in local testing.
2019-10-16update ui testsGuillaume Gomez-4/+13
2019-10-16Add long error explanation for E0573Guillaume Gomez-1/+74
2019-10-16make tidy happyMazdak Farrokhzad-3/+13
2019-10-16mbe: leave a FIXMEMazdak Farrokhzad-0/+3
2019-10-16parser: leave a FIXME for laterMazdak Farrokhzad-0/+2
2019-10-16move SeqSep to parser.rsMazdak Farrokhzad-30/+31
2019-10-16move syntax::ext to new crate syntax_expandMazdak Farrokhzad-423/+493
2019-10-16syntax::parse: don't depend on syntax::extMazdak Farrokhzad-6/+12
2019-10-16attr: remove dep on ExtCtxtMazdak Farrokhzad-11/+22
2019-10-16ast: use more direct importsMazdak Farrokhzad-9/+8
2019-10-16syntax: reduce visibilitiesMazdak Farrokhzad-101/+101
2019-10-16move diagnostics.rs into parser/Mazdak Farrokhzad-6/+7
2019-10-16syntax: extract parse_cfg_attrMazdak Farrokhzad-21/+22