about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2020-06-02Auto merge of #72918 - Dylan-DPC:rollup-pnvj62b, r=Dylan-DPCbors-242/+100
Rollup of 4 pull requests Successful merges: - #72884 (RawString error reporting cleanup ) - #72888 (Add a warning about infinite reading in read_(until|line)) - #72914 (Minor: off-by-one error in RELEASES.md) - #72916 (Update README.md) Failed merges: r? @ghost
2020-06-02Rollup merge of #72916 - DutchGhost:patch-1, r=jonas-schievinkDylan DPC-1/+1
Update README.md https://github.com/rust-lang/rust/pull/72827 changed it from `*.nix` to `Unix-like system`, but actually it should be `a Unix-like system`
2020-06-02Rollup merge of #72914 - petertodd:2020-minor-at-most-32, r=jonas-schievinkDylan DPC-1/+1
Minor: off-by-one error in RELEASES.md
2020-06-02Rollup merge of #72888 - poliorcetics:improve-read_line-read_until-doc, ↵Dylan DPC-0/+8
r=Dylan-DPC Add a warning about infinite reading in read_(until|line) Fix for #48788. This PR adds a warning to [`BufRead::read_line`](https://doc.rust-lang.org/stable/std/io/trait.BufRead.html#method.read_line) and [`BufRead::read_until`](https://doc.rust-lang.org/stable/std/io/trait.BufRead.html#method.read_until) about the possibility of an attack using the behaviour of these functions. I did not mention a possible fix (using [`Read::take`](https://doc.rust-lang.org/stable/std/io/trait.Read.html#method.take), should I ?
2020-06-02Rollup merge of #72884 - Julian-Wollersberger:raw_str_error_cleanup, ↵Dylan DPC-240/+90
r=petrochenkov RawString error reporting cleanup I simplified how errors with raw string are represented in the lexer and reportet in the parser, by using one enum instead of two structs with impls. This makes 70 code lines obsolete. I also noticed some other things (2nd commit) and added a missing test for the `too many '#' symbols' error. My original intent was to improve performance, but the only thing I found was to inline some functions in `cursor.rs`. It's effect is barely measurable, though. There is one open question. Before, the compiler aborts when encountering the `too many '#' symbols` error. Now the lexer says in this case that there are 0 hashes, and then later the parser aborts on the error. I'm worrying that the parser may be changed to recover and continue, and then later stages will see the wrong numer of hashes and act strange. (eg. the `format!` macro expansion). Is that possibility important enough today to worry about it?
2020-06-02Update README.mdDutchGhost-1/+1
https://github.com/rust-lang/rust/pull/72827 changed it from `*.nix` to `Unix-like system`, but actually it should be `a Unix-like system`
2020-06-02Minor: off-by-one error in RELEASES.mdPeter Todd-1/+1
2020-06-02Auto merge of #72672 - seritools:remote-test-windows, r=Mark-Simulacrumbors-40/+89
Make remote-test-client and remote-test-server compatible with windows `compiletest` and `remote-test-client`: The command line for `remote-test-client` was changed slightly to allow cross-platform compatible paths. The old way of supplying the support libs was by joining their paths with the executable path with `:`. This caused Windows-style paths to be split after the directory letter. Now, the number of support libs is provided as a parameter as well, and the support lib paths are split off from the regular args in the client. `remote-test-server`: - Marked Unix-only parts as such and implemented Windows alternatives - On Windows `LD_LIBRARY_PATH` doesn't exist. Libraries are loaded from `PATH` though, so that's the way around it. - Tiny cleanup: `Command::args`/`envs` instead of manually looping over them - The temp path for Windows has to be set via environment variable, since there isn't a global temp directory that would work on every machine (as a static string)
2020-06-02Auto merge of #72905 - JohnTitor:rollup-phtyo5i, r=JohnTitorbors-87/+238
Rollup of 10 pull requests Successful merges: - #72775 (Return early to avoid ICE) - #72795 (Add a test for `$:ident` in proc macro input) - #72822 (remove trivial calls to mk_const) - #72825 (Clarify errors and warnings about the transition to the new asm!) - #72827 (changed *nix to Unix-like) - #72880 (Clean up E0637 explanation) - #72886 (Remove allow missing_debug_implementations for MaybeUninit) - #72889 (rustc: Remove the `--passive-segments` LLD flag on wasm) - #72891 (Add associated consts MIN/MAX for Wrapping<Int>) - #72893 (test miri-unleash TLS accesses) Failed merges: r? @ghost
2020-06-02Rollup merge of #72893 - RalfJung:unleash-tls, r=ecstatic-morseYuki Okushi-15/+58
test miri-unleash TLS accesses Finally gets rid of `IS_SUPPORTED_IN_MIRI`. :-) I also added a test for the new `asm!` while I am at it. r? @ecstatic-morse Cc @rust-lang/wg-const-eval
2020-06-02Rollup merge of #72891 - lzutao:wrapping_int-max, r=sfacklerYuki Okushi-12/+4
Add associated consts MIN/MAX for Wrapping<Int>
2020-06-02Rollup merge of #72889 - alexcrichton:update-wasm-threads, r=nikomatsakisYuki Okushi-4/+0
rustc: Remove the `--passive-segments` LLD flag on wasm This flag looks like it's been removed in LLVM 10, so this removes rustc unconditionally passing the flag.
2020-06-02Rollup merge of #72886 - xfix:patch-21, r=jonas-schievinkYuki Okushi-1/+0
Remove allow missing_debug_implementations for MaybeUninit It already has a Debug implementation.
2020-06-02Rollup merge of #72880 - GuillaumeGomez:cleanup-e0637, r=Dylan-DPCYuki Okushi-1/+4
Clean up E0637 explanation r? @Dylan-DPC
2020-06-02Rollup merge of #72827 - milrope:patch-1, r=nikomatsakisYuki Okushi-1/+1
changed *nix to Unix-like
2020-06-02Rollup merge of #72825 - Amanieu:asm-warning, r=davidtwcoYuki Okushi-12/+21
Clarify errors and warnings about the transition to the new asm! Hopefully addresses the concerns from https://github.com/rust-lang/rust/pull/71007#issuecomment-636412905.
2020-06-02Rollup merge of #72822 - lcnr:intern-me, r=estebankYuki Okushi-1/+5
remove trivial calls to mk_const similar to #72754
2020-06-02Rollup merge of #72795 - petrochenkov:identgroup, r=nikomatsakisYuki Okushi-33/+99
Add a test for `$:ident` in proc macro input cc https://github.com/rust-lang/rust/issues/72545#issuecomment-636388019
2020-06-02Rollup merge of #72775 - JohnTitor:await-sugg, r=estebankYuki Okushi-7/+46
Return early to avoid ICE Fixes #72766
2020-06-02Fix commentRalf Jung-1/+1
Co-authored-by: Aaron Hill <aa1ronham@gmail.com>
2020-06-01Cleanup: Inline `struct_span_fatal()`, which is only called once, and remove ↵Julian Wollersberger-24/+5
an outdated FIXME.
2020-06-01Simplify raw string error reporting.Julian Wollersberger-216/+85
This makes `UnvalidatedRawStr` and `ValidatedRawStr` unnecessary and removes 70 lines.
2020-06-01Auto merge of #72779 - RalfJung:miri, r=oli-obkbors-23/+42
bump Miri, update for cargo-miri being a separate project r? @oli-obk Fixes https://github.com/rust-lang/rust/issues/72801
2020-06-01test miri-unleash TLS accessesRalf Jung-15/+58
2020-06-01bump Miri, update for cargo-miri being a separate projectRalf Jung-23/+42
2020-06-01Add associated consts MIN/MAX for Wrapping<Int>Lzu Tao-12/+4
2020-06-01rustc: Remove the `--passive-segments` LLD flag on wasmAlex Crichton-4/+0
This flag looks like it's been removed in LLVM 10, so this removes rustc unconditionally passing the flag.
2020-06-01Add a warning about infinite reading in read_(until|line)Alexis Bourget-0/+8
2020-06-01Remove allow missing_debug_implementations for MaybeUninitKonrad Borowski-1/+0
It already has a Debug implementation.
2020-06-01Auto merge of #71192 - oli-obk:eager_alloc_id_canonicalization, r=wesleywiserbors-23/+157
Make TLS accesses explicit in MIR r? @rust-lang/wg-mir-opt cc @RalfJung @vakaras for miri thread locals cc @bjorn3 for cranelift fixes #70685
2020-06-01Clean up E0637 explanationGuillaume Gomez-1/+4
2020-06-01Auto merge of #72844 - Dylan-DPC:rollup-i51qv5z, r=Dylan-DPCbors-184/+278
Rollup of 5 pull requests Successful merges: - #72776 (fulfill: try using SmallVec or Box for stalled_on) - #72818 (Clean up E0622 explanation) - #72823 (Add descriptions for all queries) - #72832 (RELEASES.md: Expand `cargo tree` note to mention `cargo tree -d`) - #72834 (Rephrase term 'non-pointer type') Failed merges: r? @ghost
2020-06-01Rollup merge of #72834 - JOE1994:correct_confusing_term, r=sfacklerDylan DPC-4/+4
Rephrase term 'non-pointer type' Hello :cat2: , If the reader assumes that 'pointer type's include 'smart pointer's, the term 'non-pointer type' could mislead the reader to assume that x should not be a smart pointer type. I tried to rephrase the term 'non-pointer type' to remove ambiguity in the doc comments. closes #72335 Thank you for reviewing this PR! :superhero_woman:
2020-06-01Rollup merge of #72832 - joshtriplett:cargo-tree-d, r=Mark-SimulacrumDylan DPC-0/+2
RELEASES.md: Expand `cargo tree` note to mention `cargo tree -d` Useful feature that people might not automatically associate with `cargo tree`.
2020-06-01Rollup merge of #72823 - matthewjasper:describe-queries, r=eddybDylan DPC-174/+257
Add descriptions for all queries This also removes the default description for queries with DefId keys and makes the macro validate that a description is provided. cc #72730 r? @eddyb
2020-06-01Rollup merge of #72818 - GuillaumeGomez:cleanup-e0622, r=Dylan-DPCDylan DPC-3/+11
Clean up E0622 explanation r? @Dylan-DPC
2020-06-01Rollup merge of #72776 - lcnr:stalled_on-smallvec, r=nnethercoteDylan DPC-3/+4
fulfill: try using SmallVec or Box for stalled_on Tested both `Box` and `SmallVec` for `stalled_on`, with both resulting in a perf loss. Adds a comment mentioning this and removes an now outdated FIXME. Logging the length of `stalled_on` resulted in the following distribution while building a part of stage 1 libs: ``` 22627647 counts: ( 1) 20983696 (92.7%, 92.7%): process_obligation_len: 1 ( 2) 959711 ( 4.2%, 97.0%): process_obligation_len: 2 ( 3) 682326 ( 3.0%,100.0%): process_obligation_len: 0 ( 4) 1914 ( 0.0%,100.0%): process_obligation_len: 3 ``` cc @eddyb r? @nnethercote
2020-05-31Auto merge of #72831 - Dylan-DPC:rollup-6rxjwt9, r=Dylan-DPCbors-29/+62
Rollup of 5 pull requests Successful merges: - #72691 (Fix escape key handling) - #72807 (Avoid setting wrong obligation cause span of associated type mismatch) - #72812 (Miri tests: skip parts of test_char_range) - #72829 (Clarify terms in doc comments) - #72830 (Fix release notes for niche initialization change) Failed merges: r? @ghost
2020-05-31Rephrase term 'non-pointer type'JOE1994-4/+4
If the reader assumes that 'pointer type's include 'smart pointer's, the term 'non-pointer type' could mislead the reader to assume that x should not be a smart pointer type. I tried to rephrase the term 'non-pointer type' to remove ambiguity in the doc comments. closes #72335 Thank you for reviewing this PR! :)
2020-05-31RELEASES.md: Expand `cargo tree` note to mention `cargo tree -d`Josh Triplett-0/+2
Useful feature that people might not automatically associate with `cargo tree`.
2020-05-31Rollup merge of #72830 - rust-lang:sfackler-patch-1, r=Mark-SimulacrumDylan DPC-2/+2
Fix release notes for niche initialization change MaybeUninit is not affected by the linked PR.
2020-05-31Rollup merge of #72829 - JOE1994:clarify_terms, r=jonas-schievinkDylan DPC-2/+2
Clarify terms in doc comments Doc comments of `copy_from_slice` say that people should use `clone_from_slice` when 'src' doesn't implement `Copy`. However, 'src' is a reference and it always implements `Copy`. The term 'src' should be fixed to `T`(element type of slice 'src') in the doc comments. Thank you for reviewing this PR :) :smiley_cat:
2020-05-31Rollup merge of #72812 - RalfJung:miri-char-test, r=jonas-schievinkDylan DPC-2/+5
Miri tests: skip parts of test_char_range The new `test_char_range` test takes forever in Miri as it loops over all values of `char`. This makes it skip most of them when being run in Miri.
2020-05-31Rollup merge of #72807 - xiaotianrandom:fix-assoc-type-diagnostics, r=estebankDylan DPC-19/+41
Avoid setting wrong obligation cause span of associated type mismatch Removes code that sets wrong obligation cause span of associated type mismatch. See the linked issue for details. Closes #72806.
2020-05-31Rollup merge of #72691 - GuillaumeGomez:escape-key-handling, r=kinnisonDylan DPC-4/+12
Fix escape key handling Fixes #72647. The problem was that you could have a timeout just after the moment you press "escape", putting back the results. r? @kinnison
2020-05-31Add descriptions for all queriesMatthew Jasper-174/+257
2020-05-31Fix release notes for niche initialization changeSteven Fackler-2/+2
MaybeUninit is not affected by the linked PR.
2020-05-31Clarify terms in doc commentsJOE1994-2/+2
Doc comments of 'copy_from_slice' say that people should use 'clone_from_slice' when 'src' doesn't implement 'Copy'. However, 'src' is a reference and it always implements 'Copy'. The term 'src' should be fixed to 'T' in the doc comments. Thank you for reviewing this PR :)
2020-06-01changed *nix to Unix-likeMiller-1/+1
2020-05-31Clarify errors and warnings about the transition to the new asm!Amanieu d'Antras-12/+21
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-05-04 19:08:50 +0000