about summary refs log tree commit diff
AgeCommit message (Collapse)AuthorLines
2020-01-08review commentsEsteban Küber-26/+40
2020-01-08review commentsEsteban Küber-16/+34
2020-01-08review comment: wordingEsteban Küber-10/+12
2020-01-08Point at the def span of trait refs E0277Esteban Küber-13/+71
2020-01-08review commentsEsteban Küber-33/+53
2020-01-08Point at opaque and closure type definitions in type errorsEsteban Küber-8/+137
2020-01-08Auto merge of #67770 - Centril:reduce-diversity-2, r=petrochenkovbors-655/+629
More reductions in error handling diversity In this follow up to https://github.com/rust-lang/rust/pull/67744, we: - Remove all fatal / error / warning macros in `syntax` except for `struct_span_err`, which is moved to `rustc_errors`. - Lintify some hard-coded warnings which used warning macros. - Defatalize some errors. In general, the goal here is to make it painful to use fatal or unstructured errors and so we hopefully won't see many of these creep in. Fixes https://github.com/rust-lang/rust/issues/67933.
2020-01-08Auto merge of #67760 - Mark-Simulacrum:rustc-dirty, r=alexcrichtonbors-2/+13
Clear out target directory if compiler has changed Previously, we relied fully on Cargo to detect that the compiler had changed and it needed to rebuild the standard library (or later "components"). This used to not quite be the case prior to moving to LLVM be a separate cargo invocation; subsequent compiles would recompile std and friends if LLVM had changed (#67077 is the PR that changes things here). This PR moves us to clearing out libstd when it is being compiled if the rustc we're using has changed. We fairly harshly limit the cases in which we do this (e.g., ignoring dry run mode, and so forth, as well as rustdoc invocations). This is primarily because when we're not using the compiler directly, so clearing out in other cases is likely to lead to bugs, particularly as our deletion scheme is pretty blunt today (basically removing more than is needed, i.e., not just the rustc artifacts). In practice, this targeted fix does fix the known bug, though it may not fully resolve the problem here. It's also not clear that there is a full fix hiding here that doesn't involve a more major change (like -Zbinary-dep-depinfo was). As a drive-by fix, don't delete the compiler before calling Build::copy, as that also deletes the compiler.
2020-01-08Auto merge of #67733 - pietroalbini:gha-2, r=alexcrichtonbors-5/+18
GitHub Actions: preparations, part 2 This PR adds the second batch of commits in preparation for GitHub Actions: * Removed hardcoded Azure Pipelines variables from `publish_toolstate.sh` * Fixed a bug in `shared.sh`'s GitHub Actions support * Fixed binutils missing from MSYS2 on Windows 2019 (GitHub Actions-specific) * Fixed wrong sysroot in macOS 10.15 onwards (GitHub Actions-specific) This PR does **not** yet add any builders on GitHub Actions. r? @alexcrichton
2020-01-08span_to_lines: account for DUMMY_SPMazdak Farrokhzad-2/+3
2020-01-08- remove syntax::{span_warn!, span_err!, span_fatal!. struct_err!}Mazdak Farrokhzad-653/+626
- remove syntax::{help!, span_help!, span_note!} - remove unused syntax::{struct_span_fatal, struct_span_err_or_warn!, span_err_or_warn!} - lintify check_for_bindings_named_same_as_variants + conflicting_repr_hints - inline syntax::{struct_span_warn!, diagnostic_used!} - stringify_error_code! -> error_code! & use it more. - find_plugin_registrar: de-fatalize an error - de-fatalize metadata errors - move type_error_struct! to rustc_typeck - struct_span_err! -> rustc_errors
2020-01-07Auto merge of #67970 - cjgillot:inherent, r=Centrilbors-1442/+1512
Minimize dependencies on trait and infer inside librustc Split from #67953 All commits should pass check on their own. r? @Centril
2020-01-07Rename traits::drop -> traits::misc.Camille GILLOT-5/+5
2020-01-07Auto merge of #67312 - cuviper:clone-box-slice, r=SimonSapinbors-42/+1
Simplify Clone for Box<[T]> The bespoke `BoxBuilder` was basically a very simple `Vec`. Instead, let's clone to a real `Vec`, with all of its specialization for the task, then convert back to `Box<[T]>`.
2020-01-07Move magic traits queries to rustc::traits::drop.Camille GILLOT-203/+211
2020-01-07Move required_region_bounds to rustc::infer::opaque_types.Camille GILLOT-68/+70
2020-01-07Move free_region_map to rustc::ty.Camille GILLOT-6/+6
2020-01-07Move structural_match to rustc::traits.Camille GILLOT-45/+45
2020-01-07Move ty::wf to traits.Camille GILLOT-9/+11
2020-01-07Make traits::util::* free functions.Camille GILLOT-174/+189
2020-01-07Move subst_and_normalize_erasing_regionsto rustc::ty.Camille GILLOT-26/+24
2020-01-07Move normalize_erasing_regions to rustc::ty.Camille GILLOT-1/+1
2020-01-07Make ↵Camille GILLOT-49/+54
rustc::traits::object_safety::{astconv_object_safety_violations,is_vtable_safe_method,object_safety_violations} free functions.
2020-01-07Make ↵Camille GILLOT-59/+62
rustc::traits::error_reporting::{recursive_type_with_infinite_size_error, report_object_safety_error} free functions.
2020-01-07Make rustc::infer::error_reporting::{note_and_explain_free_region, ↵Camille GILLOT-125/+164
note_and_explain_region} free functions.
2020-01-07Remove private methods from TyCtxt impl block: rustc::ty::print::pretty.Camille GILLOT-16/+16
2020-01-07Remove private methods from TyCtxt impl block: rustc::ty::outlives.Camille GILLOT-27/+23
2020-01-07Remove trivial function.Camille GILLOT-6/+2
2020-01-07Remove private methods from TyCtxt impl block: rustc::trait::object_safety.Camille GILLOT-501/+508
2020-01-07Remove private methods from TyCtxt impl block: rustc::middle::stability.Camille GILLOT-25/+23
2020-01-07Remove private methods from TyCtxt impl block: rustc::infer::error_reporting.Camille GILLOT-108/+109
2020-01-07Auto merge of #67732 - pietroalbini:fewer-apples, r=alexcrichtonbors-20/+1
ci: remove 32-bit Apple targets This PR drops the `i686-apple` and `dist-i686-apple` CI builders, as well as removing the `armv7-apple-ios`, `armv7s-apple-ios` and `i386-apple-ios` targets from the `x86_64-apple` CI builder. The change was approved in [RFC 2837](https://github.com/rust-lang/rfcs/pull/2837), and it should land in Rust 1.42 stable (so this cycle). r? @alexcrichton
2020-01-07Auto merge of #67924 - RalfJung:miri, r=RalfJungbors-8/+8
update miri Fixes https://github.com/rust-lang/rust/issues/67860 r? @ghost
2020-01-07update miriRalf Jung-8/+8
2020-01-07Auto merge of #67961 - ehuss:update-cargo, r=alexcrichtonbors-0/+0
Update cargo 9 commits in 86134e7666a088682f20b76278c3ee096a315218..6e1ca924a67dd1ac89c33f294ef26b5c43b89168 2019-12-23 16:08:07 +0000 to 2020-01-06 19:11:37 +0000 - Fix dynamic linking for Windows UWP MSVC targets (rust-lang/cargo#7758) - Fix CARGO_TARGET_triple_LINKER environment variable. (rust-lang/cargo#7763) - Remove metadata dep_kinds duplicates. (rust-lang/cargo#7756) - Check for a source defined multiple times. (rust-lang/cargo#7751) - Fix typo. (rust-lang/cargo#7735) - Fix config env vars that are prefix of another with underscore. (rust-lang/cargo#7748) - Add test for `cargo pkgid` (rust-lang/cargo#7741) - Add a note to the error message for using --feature / --no-default-features in a virtual workspace (rust-lang/cargo#7742) - Fix debug message. (rust-lang/cargo#7749)
2020-01-07Auto merge of #67964 - JohnTitor:rollup-pu5kosl, r=JohnTitorbors-111/+231
Rollup of 13 pull requests Successful merges: - #67566 (Add an unstable conversion from thread ID to u64) - #67671 (Account for `type X = impl Trait;` in lifetime suggestion) - #67727 (Stabilise vec::remove_item) - #67877 (Omit underscore constants from rustdoc) - #67880 (Handle multiple error fix suggestions carefuly) - #67898 (Improve hygiene of `newtype_index`) - #67908 (rustdoc: HTML escape const values) - #67909 (Fix ICE in const pretty printing and resolve FIXME) - #67929 (Formatting an example for method Vec.retain) - #67934 (Clean up E0178 explanation) - #67936 (fire "non_camel_case_types" for associated types) - #67943 (Missing module std in example.) - #67962 (Update books) Failed merges: r? @ghost
2020-01-07Rollup merge of #67962 - ehuss:update-books, r=ehussYuki Okushi-0/+0
Update books ## nomicon 1 commits in 8be35b201f9cf0a4c3fcc96c83ac21671dcf3112..3e6e1001dc6e095dbd5c88005e80969f60e384e1 2019-12-01 13:02:12 -0500 to 2019-12-14 22:08:52 +0000 - Remove mention of contravariance possibly getting scrapped (rust-lang-nursery/nomicon#177) ## reference 4 commits in d8dfe1b005c03584cd7adc4bfb72b005e7e84744..e1157538e86d83df0cf95d5e33bd943f80d0248f 2019-12-14 21:04:58 +0100 to 2019-12-22 13:13:14 +0100 - Fix typo in macros-by-example.md (rust-lang-nursery/reference#733) - Remove `extern` from exception list (rust-lang-nursery/reference#732) - Added clearification that closures are refered to lambdas (rust-lang-nursery/reference#731) - abi.md: clarify #[used] and linking (rust-lang-nursery/reference#712) ## book 2 commits in ef8bb568035ded8ddfa30a9309026638cc3c8136..5c5cfd2e94cd42632798d9bd3d1116133e128ac9 2019-11-28 11:00:04 -0600 to 2019-12-16 09:27:21 -0600 - document new --show-output option in ch 11-2 (Rust &gt;= 1.39) (rust-lang/book#2065) - Fix sentence in ch07 (rust-lang/book#2183) ## rust-by-example 3 commits in b7ac1bc76b7d02a43c83b3a931d226f708aa1ff4..1d59403cb5269c190cc52a95584ecc280345495a 2019-12-02 11:38:43 -0300 to 2019-12-27 08:27:05 -0300 - Enable section-folding of table of content (rust-lang/rust-by-example#1290) - Remove unnecessary lifetime annotation (rust-lang/rust-by-example#1300) - eliminate the warnings (rust-lang/rust-by-example#1301) ## edition-guide 1 commits in 6601cab4666596494a569f94aa63b7b3230e9769..1a2390247ad6d08160e0dd74f40a01a9578659c2 2019-11-22 12:08:58 -0500 to 2019-12-29 10:40:55 -0800 - Updated install and uninstall instructions (rust-lang-nursery/edition-guide#194) ## embedded-book 1 commits in c26234930282210849256e4ecab925f0f2daf3be..9493b7d4dc97eda439bd8780f05ad7b234cd1cd7 2019-12-07 17:25:11 +0000 to 2019-12-27 20:05:00 +0000 - fixed typo in Interrupts.md (rust-embedded/book#218)
2020-01-07Rollup merge of #67943 - Stromberg90:patch-1, r=jonas-schievinkYuki Okushi-2/+1
Missing module std in example.
2020-01-07Rollup merge of #67936 - euclio:assoc-type-bad-style, r=CentrilYuki Okushi-2/+18
fire "non_camel_case_types" for associated types Fixes #67920.
2020-01-07Rollup merge of #67934 - GuillaumeGomez:clean-up-e0178, r=Dylan-DPCYuki Okushi-7/+18
Clean up E0178 explanation r? @Dylan-DPC
2020-01-07Rollup merge of #67929 - mgrachev:patch-1, r=jonas-schievinkYuki Okushi-1/+1
Formatting an example for method Vec.retain
2020-01-07Rollup merge of #67909 - varkor:obsolete-const-print, r=davidtwcoYuki Okushi-12/+5
Fix ICE in const pretty printing and resolve FIXME Consts now have a `fmt::Display` impl, so we can just use that to pretty-print. This resolves an ICE in https://github.com/rust-lang/rust/issues/61936, though it hits more ICEs afterwards. I couldn't find a test case that was resolved by this that didn't hit errors later on.
2020-01-07Rollup merge of #67908 - ollie27:rustdoc_const_html_escape, r=GuillaumeGomezYuki Okushi-5/+26
rustdoc: HTML escape const values r? @GuillaumeGomez
2020-01-07Rollup merge of #67898 - matthewjasper:newtype-index-hygiene, r=CentrilYuki Okushi-52/+80
Improve hygiene of `newtype_index` `newtype_index` no longer needs `rustc_index::vec::Idx` to be in scope. r? @Centril
2020-01-07Rollup merge of #67880 - lbonn:fix/multi-substs, r=petrochenkovYuki Okushi-9/+37
Handle multiple error fix suggestions carefuly The existing code seems to assume that substitutions spans are disjoint, which is not always the case. In the example: pub trait AAAA {} pub trait B {} pub trait C {} pub type T<P: AAAA + B + C> = P; , we get three substituions starting from ':' and ending respectively at the end of each trait token. With the former offset calculation, this would cause `underline_start` to eventually become negative before being converted to `usize`... The new version may report erroneous results for non perfectly overlapping substitutions but I don't know if such examples exist. Alternatively, we could detect these cases and trim out overlapping substitutions. Fixes #67690
2020-01-07Rollup merge of #67877 - dtolnay:const-_, r=nagisaYuki Okushi-11/+22
Omit underscore constants from rustdoc Underscore constants from https://github.com/rust-lang/rfcs/pull/2526 / https://github.com/rust-lang/rust/issues/54912 do not correspond to a nameable item and so are never useful in documentation. <br> #### Before: > &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;<img src="https://user-images.githubusercontent.com/1940490/71771409-0427cc80-2eef-11ea-8b7d-d9c74a873e7e.png" width="60%"> #### After: > Not that.
2020-01-07Rollup merge of #67727 - Dylan-DPC:stabilise/remove_item, r=alexcrichtonYuki Okushi-6/+1
Stabilise vec::remove_item Closes #40062 r? @alexcrichton
2020-01-07Rollup merge of #67671 - estebank:type-impl-trait, r=davidtwcoYuki Okushi-4/+9
Account for `type X = impl Trait;` in lifetime suggestion Fix #67619.
2020-01-07Rollup merge of #67566 - Mark-Simulacrum:thread-id-u64, r=alexcrichtonYuki Okushi-0/+13
Add an unstable conversion from thread ID to u64 We see multiple cases inside rustc and ecosystem code where ThreadId is transmuted to u64, exploiting the underlying detail. This is suboptimal (can break unexpectedly if we change things in std). It is unlikely that ThreadId will ever need to be larger than u64 -- creating even 2^32 threads over the course of a program is quite hard, 2^64 is even harder. As such, we do not choose to return a larger sized type (e.g. u128). If we choose to shrink ThreadId in the future, or otherwise change its internals, it is likely that a mapping to u64 will still be applicable (though may become more complex). I will file a tracking issue as soon as this is loosely approved.
2020-01-06Update booksEric Huss-0/+0