summary refs log tree commit diff
path: root/compiler/rustc_resolve/src/ident.rs
AgeCommit message (Collapse)AuthorLines
2023-05-18fix(resolve): only disambiguate binding key during definebohan-1/+2
2023-05-14Revert "Validate resolution for SelfCtor too."Camille GILLOT-4/+1
This reverts commit 83453408a0ce91b9e3d3ae6e7f117b1fd28b487d.
2023-05-11Improve error for `self: Box<self>`clubby789-24/+20
2023-05-05improve diagnostics and bless testsBoxy-19/+51
2023-05-05misc nameres changes for anon constsBoxy-10/+2
2023-05-04Rollup merge of #111070 - WaffleLapkin:break_ribs, r=lcnrMatthias Krüger-34/+33
Don't suffix `RibKind` variants This PR - Removes `use RibKind::*` - Renames `RibKind::{SomethingRibKind => Something}` It seems unnecessary to have "RibKind" in the end of all variants, if we can just use it as a normal enum. Additionally previously it was weird that `MacroDefinition` is the only unsuffixed variant.
2023-05-04Rollup merge of #111020 - cjgillot:validate-self-ctor, r=petrochenkovMatthias Krüger-1/+4
Validate resolution for SelfCtor too. Fixes https://github.com/rust-lang/rust/issues/89868 r? `@petrochenkov`
2023-05-03Validate resolution for SelfCtor too.Camille GILLOT-1/+4
2023-05-03Restrict `From<S>` for `{D,Subd}iagnosticMessage`.Nicholas Nethercote-1/+1
Currently a `{D,Subd}iagnosticMessage` can be created from any type that impls `Into<String>`. That includes `&str`, `String`, and `Cow<'static, str>`, which are reasonable. It also includes `&String`, which is pretty weird, and results in many places making unnecessary allocations for patterns like this: ``` self.fatal(&format!(...)) ``` This creates a string with `format!`, takes a reference, passes the reference to `fatal`, which does an `into()`, which clones the reference, doing a second allocation. Two allocations for a single string, bleh. This commit changes the `From` impls so that you can only create a `{D,Subd}iagnosticMessage` from `&str`, `String`, or `Cow<'static, str>`. This requires changing all the places that currently create one from a `&String`. Most of these are of the `&format!(...)` form described above; each one removes an unnecessary static `&`, plus an allocation when executed. There are also a few places where the existing use of `&String` was more reasonable; these now just use `clone()` at the call site. As well as making the code nicer and more efficient, this is a step towards possibly using `Cow<'static, str>` in `{D,Subd}iagnosticMessage::{Str,Eager}`. That would require changing the `From<&'a str>` impls to `From<&'static str>`, which is doable, but I'm not yet sure if it's worthwhile.
2023-05-01Remove "RibKind" suffix from `RibKind` variantsMaybe Waffle-28/+28
2023-05-01Don't `use RibKind::*`Maybe Waffle-34/+33
2023-05-01Rip it outNilstrieb-1/+7
My type ascription Oh rip it out Ah If you think we live too much then You can sacrifice diagnostics Don't mix your garbage Into my syntax So many weird hacks keep diagnostics alive Yet I don't even step outside So many bad diagnostics keep tyasc alive Yet tyasc doesn't even bother to survive!
2023-04-06Rollup merge of #109909 - clubby789:import-tool-mod, r=petrochenkovYuki Okushi-11/+7
Deny `use`ing tool paths Fixes #109853 Fixes #109147
2023-04-04Deny `use`ing tool pathsclubby789-11/+7
2023-04-04Auto merge of #109599 - notriddle:notriddle/use-redundant-glob, r=petrochenkovbors-14/+21
diagnostics: account for glob shadowing when linting redundant imports Fixes #92904
2023-04-01slighty simplify a few boolean expressions (clippy::nonminimal_bool)Matthias Krüger-1/+1
2023-04-01diagnostics: account for glob shadowing when linting redundant importsMichael Howell-14/+21
Co-Authored-By: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
2023-03-03Match unmatched backticks in compiler/ that are part of rustdocest31-1/+1
2023-02-20Prepare for adding a `TyCtxt` to `Resolver`Oli Scherer-6/+9
2023-02-14Separate the lifetime of the session and the arena in the resolverOli Scherer-1/+1
2023-02-02Rename `rust_2015` => `is_rust_2015`Maybe Waffle-2/+3
2023-01-31Use `Edition` methods a bit moreMaybe Waffle-2/+1
2023-01-20Revert "Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard error"Felix S. Klock II-10/+65
This reverts commit 7d82cadd97acc66993b69304c5a1a04ef7d1fa36. I am doing this to buy us some time with respect to issue #106337 w.r.t. the 1.67 release.
2023-01-04Simplify some iterator combinatorsMichael Goulet-5/+4
2022-11-01Rollup merge of #103760 - petrochenkov:macimp, r=cjgillotDylan DPC-2/+6
resolve: Turn the binding from `#[macro_export]` into a proper `Import` Continuation of https://github.com/rust-lang/rust/pull/91795. ```rust #[macro_export] macro_rules! m { /*...*/ } ``` is desugared to something like ```rust macro_rules! m { /*...*/ } // Non-modularized macro_rules item pub use m; // It's modularized reexport ``` This PR adjusts the internal representation to better match this model.
2022-10-31resolve: Turn the binding from `#[macro_export]` into a proper `Import`Vadim Petrochenkov-2/+6
2022-10-24Make PROC_MACRO_DERIVE_RESOLUTION_FALLBACK a hard errorAaron Hill-65/+10
2022-09-29Shrink `hir::def::Res`.Nicholas Nethercote-6/+16
`Res::SelfTy` currently has two `Option`s. When the second one is `Some` the first one is never consulted. So we can split it into two variants, `Res::SelfTyParam` and `Res::SelfTyAlias`, reducing the size of `Res` from 24 bytes to 12. This then shrinks `hir::Path` and `hir::PathSegment`, which are the HIR types that take up the most space.
2022-09-07rustc: Parameterize `ty::Visibility` over used IDVadim Petrochenkov-6/+7
It allows using `LocalDefId` instead of `DefId` when possible, and also encode cheaper `Visibility<DefIndex>` into metadata.
2022-09-01Directly use the `instrument` macro instead of its full pathOli Scherer-10/+10
2022-08-30Rollup merge of #101123 - JohnTitor:rm-register-attr, r=TaKO8KiDylan DPC-11/+1
Remove `register_attr` feature Closes #66080 Signed-off-by: Yuki Okushi <jtitor@2k36.org>
2022-08-28Remove `register_attr` featureYuki Okushi-11/+1
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
2022-08-27rustc_middle: Remove `Visibility::Invisible`Vadim Petrochenkov-2/+8
2022-08-23Remove FnItemRibKind.Camille GILLOT-11/+1
2022-08-23Improve local generic parameter suggestions.Camille GILLOT-4/+4
2022-08-23Create specific ConstantHasGenerics for ConstantItemRibKind.Camille GILLOT-3/+9
2022-07-25Unused tuple fields in rustc_resolve.Camille GILLOT-2/+2
2022-06-20Provide a segment res in more casesMichael Goulet-0/+1
2022-06-15implement `MacroData`Takayuki Maeda-1/+1
2022-05-20Remove `crate` visibility usage in compilerJacob Pratt-8/+8
2022-05-07Permit asm_const and asm_sym to reference outer generic paramsGary Guo-32/+2
2022-05-02Use a yes/no enum instead of a bool.Oli Scherer-2/+2
The bool's meaning wasn't obvious to me at some call sites.
2022-05-01resolve: Rename `unusable_binding` to `ignore_binding`Vadim Petrochenkov-45/+32
2022-05-01resolve: Merge `last_import_segment` into `Finalize`Vadim Petrochenkov-25/+5
2022-05-01resolve: Pass full `Finalize` in nearly all casesVadim Petrochenkov-16/+14
2022-05-01resolve: Turn `enum Finalize` into an optional structVadim Petrochenkov-7/+7
2022-04-17Lint elided lifetimes in path on the AST.Camille GILLOT-1/+1
2022-04-14Reimplement lowering of sym operands for asm! so that it also works with ↵Amanieu d'Antras-0/+38
global_asm!
2022-04-12Handle `unusable_binding` more compactly.Vadim Petrochenkov-17/+14
2022-04-12Fix imports.Camille GILLOT-8/+3
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-07-14 09:31:09 +0000