| Age | Commit message (Collapse) | Author | Lines | |
|---|---|---|---|---|
| 2024-07-29 | Reformat `use` declarations. | Nicholas Nethercote | -1/+2 | |
| The previous commit updated `rustfmt.toml` appropriately. This commit is the outcome of running `x fmt --all` with the new formatting options. | ||||
| 2024-01-12 | check rust lints when an unknown lint is detected | yukang | -0/+28 | |
| 2023-11-27 | rustc_span: Use correct edit distance start length for suggestions | Martin Nordholts | -1/+5 | |
| Otherwise the suggestions can be off-base for non-ASCII identifiers. For example suggesting that `Ok` is a name similar to `读文`. | ||||
| 2023-08-04 | Rollup merge of #114351 - ttsugriy:sort-by-words, r=fee1-dead | Matthias Krüger | -2/+2 | |
| [rustc_span][perf] Remove unnecessary string joins and allocs. Comparing vectors of string parts yields the same result but avoids unnecessary `join` and potential allocation for resulting `String`. This code is cold so it's unlikely to have any measurable impact, but considering but since it's also simpler, why not? :) | ||||
| 2023-08-02 | [rustc_span][perf] Hoist lookup sorted by words out of the loop. | Taras Tsugrii | -1/+2 | |
| @lqd commented on https://github.com/rust-lang/rust/pull/114351 asking if `sort_by_words(lookup)` is computed repeatedly. I was assuming that rustc should have no difficulties to hoist it automatically outside of the loop to avoid repeated pure computation, but according to https://godbolt.org/z/frs8Kj1rq it seems like I was wrong: original version seems to have 2 calls per loop iteration ``` .LBB16_3: mov rbx, qword ptr [r13] mov r14, qword ptr [r13 + 8] lea rdi, [rsp + 40] mov rsi, rbx mov rdx, r14 call example::sort_by_words lea rdi, [rsp + 64] mov rsi, qword ptr [rsp + 8] mov rdx, qword ptr [rsp + 16] call example::sort_by_words mov rdi, qword ptr [rsp + 40] mov rdx, qword ptr [rsp + 56] mov rsi, qword ptr [rsp + 64] cmp rdx, qword ptr [rsp + 80] mov qword ptr [rsp + 32], rdi mov qword ptr [rsp + 24], rsi jne .LBB16_5 call qword ptr [rip + bcmp@GOTPCREL] test eax, eax sete al mov dword ptr [rsp + 4], eax mov rsi, qword ptr [rsp + 72] test rsi, rsi jne .LBB16_8 jmp .LBB16_9 ``` but the manually hoisted version just 1: ``` .LBB16_3: mov r13, qword ptr [r15] mov r14, qword ptr [r15 + 8] lea rdi, [rsp + 64] mov rsi, r13 mov rdx, r14 call example::sort_by_words mov rdi, qword ptr [rsp + 64] mov rdx, qword ptr [rsp + 16] cmp qword ptr [rsp + 80], rdx mov qword ptr [rsp + 32], rdi jne .LBB16_5 mov rsi, qword ptr [rsp + 8] call qword ptr [rip + bcmp@GOTPCREL] test eax, eax sete bpl mov rsi, qword ptr [rsp + 72] test rsi, rsi jne .LBB16_8 jmp .LBB16_9 ``` This code is probably not very hot, but there is no reason to leave such a low hanging fruit. | ||||
| 2023-08-01 | [rustc_span][perf] Remove unnecessary string joins and allocs. | Taras Tsugrii | -2/+2 | |
| Comparing vectors of string parts yields the same result but avoids unnecessary `join` and potential allocation for resulting `String`. This code is cold so it's unlikely to have any measurable impact, but considering but since it's also simpler, why not? :) | ||||
| 2023-04-10 | Fix typos in compiler | DaniPopes | -1/+1 | |
| 2023-04-06 | add comment | yukang | -0/+3 | |
| 2023-03-26 | add comments and cleanup | yukang | -3/+10 | |
| 2023-03-20 | Fix issue when there are multiple candidates for edit_distance_with_substrings | yukang | -4/+20 | |
| 2023-02-19 | Make public API, docs algorithm-agnostic | Jacob Pratt | -0/+229 | |
