about summary refs log tree commit diff
path: root/compiler/rustc_trait_selection
AgeCommit message (Collapse)AuthorLines
2023-01-14new trait solver: rebase impl substs for gats correctlyMichael Goulet-1/+1
2023-01-13Delay normalization bugs instead of reporting themMichael Goulet-8/+4
2023-01-13Suggest lifetime bound in illegal Copy implMichael Goulet-14/+30
2023-01-13copy self type is implied wfMichael Goulet-1/+14
2023-01-13Check ADT fields for copy implementations considering regionsMichael Goulet-14/+36
2023-01-13Rebase conflictsMichael Goulet-7/+7
2023-01-13Consolidate two almost duplicated fn info extraction routinesMichael Goulet-84/+138
2023-01-13Rollup merge of #106754 - compiler-errors:ty-infer-method-is-confusing, r=lcnrYuki Okushi-2/+5
Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer` Makes sure people are aware that they may have a type variable *or* an int/float variable. r? `@oli-obk` https://github.com/rust-lang/rust/pull/106322#issuecomment-1376913539 but I could instead implement your solution, let me know. (This will conflict with #106322 for now, ignore that :smile:)
2023-01-13Auto merge of #106004 - fee1-dead-contrib:const-closures, r=oli-obkbors-16/+20
Const closures cc https://github.com/rust-lang/rust/issues/106003
2023-01-12is_ty_infer -> is_ty_or_numeric_inferMichael Goulet-2/+5
2023-01-12HACK: Handle escaping bound vars from the canonical queryMichael Goulet-1/+1
2023-01-12Implement dummy query responses and a jank instantiateMichael Goulet-38/+97
2023-01-12Rollup merge of #106322 - compiler-errors:CollectAllMismatches-infer-vars, ↵nils-5/+8
r=oli-obk Handle inference variables in `CollectAllMismatches` correctly 1. Fix #106240 2. Treat int/float type variables correctly (see `src/test/ui/iterators/invalid-iterator-chain-with-int-infer.rs`), so we can point out things like "`Iterator::Item` changed to `{integer}` here"
2023-01-12Auto merge of #106760 - compiler-errors:rollup-0bogyco, r=compiler-errorsbors-289/+118
Rollup of 8 pull requests Successful merges: - #103236 (doc: rewrite doc for signed int::{carrying_add,borrowing_sub}) - #103800 (Stabilize `::{core,std}::pin::pin!`) - #106097 (Migrate mir_build diagnostics 2 of 3) - #106170 (Move autoderef to `rustc_hir_analysis`) - #106323 (Stabilize f16c_target_feature) - #106360 (Tweak E0277 `&`-removal suggestions) - #106524 (Label `struct/enum constructor` instead of `fn item`, mention that it should be called on type mismatch) - #106739 (Remove `<dyn AstConv<'tcx>>::fun(c, ...)` calls in favour of `c.astconv().fun(...)`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
2023-01-11Rollup merge of #106360 - estebank:remove-borrow-suggestion, r=compiler-errorsMichael Goulet-34/+94
Tweak E0277 `&`-removal suggestions Fix #64068, fix #84837.
2023-01-11Rollup merge of #106170 - compiler-errors:autoderef-to-analysis, r=lcnrMichael Goulet-255/+24
Move autoderef to `rustc_hir_analysis` Not sure if this is a change we actually want, but autoderef really is only (functionally) used by `rustc_hir_analysis` and `rustc_hir_typeck`, so it probably should live there. Instead, implement a separate autoderef helper in `TypeErrCtxt` for the one use-case that goes against the ordering of the crate graph..
2023-01-12Rollup merge of #106748 - clubby789:on-unimplemented-fmt-verify, ↵Matthias Krüger-29/+32
r=compiler-errors Clean up `OnUnimplementedFormatString::verify` Lift the always-allowed symbols to a static array and replace a `match iter().find(...)` with `iter().any(...)`
2023-01-12Rollup merge of #106596 - estebank:verbose-e0271, r=compiler-errorsMatthias Krüger-7/+46
Hide more of long types in E0271 Fix #40186.
2023-01-12Rollup merge of #106309 - compiler-errors:prefer-non-err-candidates, r=oli-obkMatthias Krüger-1/+5
Prefer non-`[type error]` candidates during selection Fixes #102130 Fixes #106351 r? types note: Alternatively we could filter out error where-clauses during param-env construction? But we still need to filter out impls with errors during `match_impl`, I think.
2023-01-12fix fmt and blessDeadbeef-6/+2
2023-01-12attempt to make a minimal example workDeadbeef-16/+24
2023-01-11Clean up `OnUnimplementedFormatString::verify`clubby789-29/+32
2023-01-11Hide more of long types in E0271Esteban Küber-7/+46
Fix #40186.
2023-01-11Use the root trait predicate to determine whether to remove referencesEsteban Küber-0/+8
Fix #84837.
2023-01-11fix rebaseEsteban Küber-2/+1
2023-01-11Account for type paramsEsteban Küber-29/+59
2023-01-11Make `&`-removal suggestion verboseEsteban Küber-24/+47
2023-01-11Move autoderef to rustc_hir_analysisMichael Goulet-255/+24
2023-01-11Rollup merge of #106705 - compiler-errors:new-solver-err-properly, r=lcnrMatthias Krüger-11/+25
Report fulfillment errors in new trait solver Causes fewer ICEs when testing the new solver :smile:
2023-01-11Rollup merge of #106703 - compiler-errors:impl-derived-span, r=estebankMatthias Krüger-4/+24
Note predicate span on `ImplDerivedObligation` Seems obvious to point out the where-clause that introduces the `ImplDerivedObligation` :) r? `@estebank`
2023-01-11Filter impl and where-clause candidates that reference errorsMichael Goulet-1/+5
2023-01-11Handle inference variables in CollectAllMismatches correctlyMichael Goulet-5/+8
2023-01-11Note predicate span on ImplDerivedObligationMichael Goulet-4/+24
2023-01-11Report fulfillment errors in new trait solverMichael Goulet-11/+25
2023-01-11Rollup merge of #106397 - compiler-errors:new-solver-impl-wc, r=lcnrnils-6/+21
Check `impl`'s `where` clauses in `consider_impl_candidate` in experimental solver Check impl's nested predicates as part of the recursive evaluate in `consider_impl_candidate`. <sub>Unless, for some reason, these are intentionally **not** checked here -- in which case, I really don't understand where they're being checked...<sub> r? ```@lcnr```
2023-01-11Change `src/test` to `tests` in source files, fix tidy and testsAlbert Larsan-4/+4
2023-01-11Rollup merge of #106521 - oskgo:remove-E0280, r=jackh726Yuki Okushi-7/+11
remove E0280 After looking at #61137 I tried my hand at E0280. I'm unable to find a reasonable example that emits the error. There are a couple of old examples that compile with the current compiler ([#26217](https://github.com/rust-lang/rust/issues/26217), [#42114](https://github.com/rust-lang/rust/issues/42114), [#27113](https://github.com/rust-lang/rust/issues/27113)) and there is a [bug with chalk](https://github.com/rust-lang/rust/blob/b7cdb635c4b973572307ad288466fba64533369c/src/test/ui/chalkify/bugs/async.rs) that makes it emit the error, with a couple more chalk bugs on zulip. It seems like the error is supposed to be emitted from unfulfilled where bounds, of which two are related to borrow checking (error in where T: 'a or where 'a: 'b) and thus tend to emit errors like "lifetime may not live long enough" from borrow checking instead. The final case is with type equality constraints (where <T as Iterator>::Item == u32), which is unimplemented ([#20041](https://github.com/rust-lang/rust/issues/20041)). That such different problems are supposed to have the same error code also seems strange to me. Since the error seems to only be emitted when using chalk I propose to remove it and replace it with an ICE instead. A crater run might be warranted. Pinging `@jackh726` due to removal of chalk test that now ICEs.
2023-01-10remove E0280 and ICE insteadbowlerman-7/+11
2023-01-10Rollup merge of #106204 - compiler-errors:no-take-opaques-in-compare, r=oli-obkYuki Okushi-3/+0
No need to take opaques in `check_type_bounds` `InferCtxt` already has its defining use anchor set to err r? ``@oli-obk``
2023-01-09Assert defining anchor is set in take_opaque_typesMichael Goulet-3/+0
2023-01-09Check impl's where clauses in consider_impl_candidate in experimental solverMichael Goulet-6/+21
2023-01-09Rollup merge of #106389 - compiler-errors:no-canonicalized, r=lcnrfee1-dead-41/+41
Simplify some canonical type alias names * delete the `Canonicalized<'tcx>` type alias in favor for `Canonical<'tcx>` * `CanonicalizedQueryResponse` -> `CanonicalQueryResponse` I don't particularly care about the latter, but it should be consistent. We could alternatively delete the first alias and rename the struct to `Canonicalized`, and then keep the name of `CanonicalizedQueryResponse` untouched.
2023-01-09Rollup merge of #105655 - RedDocMD:bug-105645, r=oli-obkfee1-dead-0/+7
Remove invalid case for mutable borrow suggestion If we have a call such as `foo(&mut buf)` and after reference collapsing the type is inferred as `&T` where-as the required type is `&mut T`, don't suggest `foo(&mut mut buf)`. This is wrong syntactically and the issue lies elsewhere, not in the borrow. Fixes #105645
2023-01-09Clean upkadmin-23/+9
Simplify match statement Add multiple tests - 1 test for checking `N + 1 + 1` does not unify with `N+1` - 2 tests for checking that a function that uses two parameters only returns the parameter that is actually used. - Check exact repeat predicates
2023-01-09Check for duplicateskadmin-3/+15
2023-01-09Set !const_evaluatable if ambig. and not inferredkadmin-12/+10
This prevents an ICE due to a value not actually being evaluatable later.
2023-01-09Change based on commentskadmin-7/+26
Instead of just switching to a probe, check for different matches, and see how many there are. If one, unify it, otherwise return true and let it be unified later.
2023-01-09Change commit_if_ok to probekadmin-8/+3
2023-01-08Rollup merge of #106497 - chenyukang:yukang/fix-106443-sugg-clone, r=estebankMichael Goulet-1/+62
Suggest using clone when we have &T and T implemented Clone Fixes #106443
2023-01-08Add type flags support for Ty and Const late-bound regionsMichael Goulet-4/+3