about summary refs log tree commit diff
path: root/docs/dev/style.md
AgeCommit message (Collapse)AuthorLines
2022-07-08Update remaining GitHub URLsJonas Schievink-2/+2
2022-06-11fix typo in style.mdChris Burgess-1/+1
2022-05-30Update commit/PR styleJonas Schievink-2/+2
2022-03-27Fix typo in the style documentationMarius Ungureanu-1/+1
Was going through the documentation itself and found this typo just waiting to be fixed
2022-01-26minor: fix a typo in the style guideWaffle Maybe-2/+2
2021-09-25internal: add => () rule; emphasize `n_items` ruleAleksey Kladov-1/+21
2021-09-04internal: deduplicateAleksey Kladov-0/+23
2021-08-30internal: make scheduling control flow more obviousAleksey Kladov-0/+19
There should be only one place where we need to check if we want to start background activities.
2021-08-24internal: use idiomatic form of assertionsAleksey Kladov-1/+3
Ideally, we should just return an InvalidParameter dialog here, but that shows error message to the end user, and we generally avoid that
2021-08-11internal: document that ascription is preferred to a turbo fishAleksey Kladov-0/+20
2021-08-10minor: reword a bitAleksey Kladov-2/+2
2021-08-10internal: document codebase stance on using functional combinatorsAleksey Kladov-0/+25
2021-08-03feat: filter out duplicate macro completionsAleksey Kladov-0/+1
closes #9303
2021-08-02internal: explain that we don't `ref` in style.mdAleksey Kladov-0/+9
2021-07-26docs: Fix several typos and grammar mistakesAlexander Gonzalez-6/+6
2021-07-19internal: explain why we avoid serializing everythingAleksey Kladov-1/+1
2021-07-12internal: remove erroneous default implAleksey Kladov-1/+5
2021-07-08minor: one more usless typeAleksey Kladov-0/+1
2021-07-06internal: ensure consistent passing for config paramsAleksey Kladov-37/+68
We pass "context" parametes first, so configs should be on the left. "Bigger" context wins, so configs goes after db.
2021-07-04minor: styleAleksey Kladov-1/+31
2021-06-15internal: document that we don't #[ignore] testsAleksey Kladov-0/+7
2021-05-17minor: adjust config nameAleksey Kladov-4/+5
2021-05-14internal: remove one more immutable treeAleksey Kladov-0/+22
2021-05-13Cleanup importsAleksey Kladov-0/+7
2021-05-06internal: explain why sentence-per-lineAleksey Kladov-1/+1
2021-05-04simplify macro expansion codeAleksey Kladov-0/+33
Using `Option` arguments such that you always pass `None` or `Some` at the call site is a code smell.
2021-04-19internal: Add guidelines for release notes PR descriptionsLaurențiu Nicola-0/+11
2021-04-15Fix typo in style guideJonas Schievink-1/+1
2021-04-13internal: don't use `#[should_panic]` for testsAleksey Kladov-0/+10
2021-04-06Small grammar fixesKirill Bulatov-5/+5
2021-04-05internal: explain "extract if condition" refactoringAleksey Kladov-1/+20
2021-04-02internal: document style for helper functions and variablesAleksey Kladov-1/+40
2021-04-02internal: document Cargo.lock maintenance processAleksey Kladov-2/+2
2021-03-16Prefer match to if let elseAleksey Kladov-0/+21
2021-03-14Fix `cargo xtask lint` referencesLaurențiu Nicola-2/+2
2021-03-08Use upstream cov-markLaurențiu Nicola-1/+1
2021-03-03Clarify comparison ruleAleksey Kladov-1/+7
2021-02-20Fix typosazzamsa-3/+3
2021-02-12Document config patternAleksey Kladov-0/+60
2021-02-03Fix spelling mistakes in docs/devLukas Wirth-6/+6
2021-02-02add useless types to the styleguideAleksey Kladov-0/+14
2021-01-26Make always-assert crate reusableAleksey Kladov-1/+1
2021-01-25Fix typo in style guideLaurențiu Nicola-3/+4
2021-01-22Promote marksAleksey Kladov-6/+16
2021-01-22Style: use the right stringAleksey Kladov-0/+12
2021-01-20Avoid intermediate collectionsAleksey Kladov-1/+33
2021-01-20Don't show runnable suggestions for other filesAleksey Kladov-0/+3
It't be actually great to have these once we have run anything dialog, but for run the thing at point it makes sense to show a limited set.
2021-01-14Introduce more appropriate assertion mechanismAleksey Kladov-0/+5
rust-analyzer is a long-running program, so we *should* handle assertion failures. See also https://www.sqlite.org/assert.html.
2021-01-11Encourage gifsAleksey Kladov-0/+2
2021-01-10Use T! for bool keywordsLaurențiu Nicola-0/+21