summary refs log tree commit diff
path: root/src/librustc/middle
AgeCommit message (Collapse)AuthorLines
2016-02-23Revert "Auto merge of #30533 - nikomatsakis:fulfillment-tree, r=aturon"Niko Matsakis-474/+227
This reverts commit c14b615534ebcd5667f594c86d18eebff6afc7cb, reversing changes made to dda25f2221cc7dd68ed28254665dc7d25e2648ed. This caused a regression in compiler performance and backporting the fix to beta was deemed too risky and too challenging, since it is non-trivial and builds on prior commits in various ways. Conflicts: src/librustc/middle/traits/fulfill.rs src/librustc_data_structures/lib.rs
2016-02-18Split dummy in region inference graph into distinct source and sink nodes.Felix S. Klock II-3/+10
Why do this: The RegionGraph representation previously conflated all of the non-variable regions (i.e. the concrete regions such as lifetime parameters to the current function) into a single dummy node. A single dummy node leads DFS on a graph `'a -> '_#1 -> '_#0 -> 'b` to claim that `'_#1` is reachable from `'_#0` (due to `'a` and `'b` being conflated in the graph representation), which is incorrect (and can lead to soundness bugs later on in compilation, see #30438). Splitting the dummy node ensures that DFS will never introduce new ancestor relationships between nodes for variable regions in the graph.
2016-01-18fix path to region inference documentationBenjamin Peterson-1/+1
2016-01-18Auto merge of #30953 - KalitaAlexey:17823-get-rid-of-duplicate-error, r=nrcbors-3/+21
2016-01-18simplify E0308 message for primitive typeskalita.alexey-3/+21
2016-01-17Auto merge of #30978 - nikomatsakis:fulfillment-tree-add-fixme, r=aturonbors-1/+1
r? @aturon
2016-01-17add fixme number into codeNiko Matsakis-1/+1
2016-01-17Rollup merge of #30943 - alexcrichton:stabilize-1.7, r=aturonManish Goregaokar-10/+13
This commit stabilizes and deprecates the FCP (final comment period) APIs for the upcoming 1.7 beta release. The specific APIs which changed were: Stabilized * `Path::strip_prefix` (renamed from `relative_from`) * `path::StripPrefixError` (new error type returned from `strip_prefix`) * `Ipv4Addr::is_loopback` * `Ipv4Addr::is_private` * `Ipv4Addr::is_link_local` * `Ipv4Addr::is_multicast` * `Ipv4Addr::is_broadcast` * `Ipv4Addr::is_documentation` * `Ipv6Addr::is_unspecified` * `Ipv6Addr::is_loopback` * `Ipv6Addr::is_unique_local` * `Ipv6Addr::is_multicast` * `Vec::as_slice` * `Vec::as_mut_slice` * `String::as_str` * `String::as_mut_str` * `<[T]>::clone_from_slice` - the `usize` return value is removed * `<[T]>::sort_by_key` * `i32::checked_rem` (and other signed types) * `i32::checked_neg` (and other signed types) * `i32::checked_shl` (and other signed types) * `i32::checked_shr` (and other signed types) * `i32::saturating_mul` (and other signed types) * `i32::overflowing_add` (and other signed types) * `i32::overflowing_sub` (and other signed types) * `i32::overflowing_mul` (and other signed types) * `i32::overflowing_div` (and other signed types) * `i32::overflowing_rem` (and other signed types) * `i32::overflowing_neg` (and other signed types) * `i32::overflowing_shl` (and other signed types) * `i32::overflowing_shr` (and other signed types) * `u32::checked_rem` (and other unsigned types) * `u32::checked_shl` (and other unsigned types) * `u32::saturating_mul` (and other unsigned types) * `u32::overflowing_add` (and other unsigned types) * `u32::overflowing_sub` (and other unsigned types) * `u32::overflowing_mul` (and other unsigned types) * `u32::overflowing_div` (and other unsigned types) * `u32::overflowing_rem` (and other unsigned types) * `u32::overflowing_neg` (and other unsigned types) * `u32::overflowing_shl` (and other unsigned types) * `u32::overflowing_shr` (and other unsigned types) * `ffi::IntoStringError` * `CString::into_string` * `CString::into_bytes` * `CString::into_bytes_with_nul` * `From<CString> for Vec<u8>` * `From<CString> for Vec<u8>` * `IntoStringError::into_cstring` * `IntoStringError::utf8_error` * `Error for IntoStringError` Deprecated * `Path::relative_from` - renamed to `strip_prefix` * `Path::prefix` - use `components().next()` instead * `os::unix::fs` constants - moved to the `libc` crate * `fmt::{radix, Radix, RadixFmt}` - not used enough to stabilize * `IntoCow` - conflicts with `Into` and may come back later * `i32::{BITS, BYTES}` (and other integers) - not pulling their weight * `DebugTuple::formatter` - will be removed * `sync::Semaphore` - not used enough and confused with system semaphores Closes #23284 cc #27709 (still lots more methods though) Closes #27712 Closes #27722 Closes #27728 Closes #27735 Closes #27729 Closes #27755 Closes #27782 Closes #27798
2016-01-16std: Stabilize APIs for the 1.7 releaseAlex Crichton-10/+13
This commit stabilizes and deprecates the FCP (final comment period) APIs for the upcoming 1.7 beta release. The specific APIs which changed were: Stabilized * `Path::strip_prefix` (renamed from `relative_from`) * `path::StripPrefixError` (new error type returned from `strip_prefix`) * `Ipv4Addr::is_loopback` * `Ipv4Addr::is_private` * `Ipv4Addr::is_link_local` * `Ipv4Addr::is_multicast` * `Ipv4Addr::is_broadcast` * `Ipv4Addr::is_documentation` * `Ipv6Addr::is_unspecified` * `Ipv6Addr::is_loopback` * `Ipv6Addr::is_unique_local` * `Ipv6Addr::is_multicast` * `Vec::as_slice` * `Vec::as_mut_slice` * `String::as_str` * `String::as_mut_str` * `<[T]>::clone_from_slice` - the `usize` return value is removed * `<[T]>::sort_by_key` * `i32::checked_rem` (and other signed types) * `i32::checked_neg` (and other signed types) * `i32::checked_shl` (and other signed types) * `i32::checked_shr` (and other signed types) * `i32::saturating_mul` (and other signed types) * `i32::overflowing_add` (and other signed types) * `i32::overflowing_sub` (and other signed types) * `i32::overflowing_mul` (and other signed types) * `i32::overflowing_div` (and other signed types) * `i32::overflowing_rem` (and other signed types) * `i32::overflowing_neg` (and other signed types) * `i32::overflowing_shl` (and other signed types) * `i32::overflowing_shr` (and other signed types) * `u32::checked_rem` (and other unsigned types) * `u32::checked_neg` (and other unsigned types) * `u32::checked_shl` (and other unsigned types) * `u32::saturating_mul` (and other unsigned types) * `u32::overflowing_add` (and other unsigned types) * `u32::overflowing_sub` (and other unsigned types) * `u32::overflowing_mul` (and other unsigned types) * `u32::overflowing_div` (and other unsigned types) * `u32::overflowing_rem` (and other unsigned types) * `u32::overflowing_neg` (and other unsigned types) * `u32::overflowing_shl` (and other unsigned types) * `u32::overflowing_shr` (and other unsigned types) * `ffi::IntoStringError` * `CString::into_string` * `CString::into_bytes` * `CString::into_bytes_with_nul` * `From<CString> for Vec<u8>` * `From<CString> for Vec<u8>` * `IntoStringError::into_cstring` * `IntoStringError::utf8_error` * `Error for IntoStringError` Deprecated * `Path::relative_from` - renamed to `strip_prefix` * `Path::prefix` - use `components().next()` instead * `os::unix::fs` constants - moved to the `libc` crate * `fmt::{radix, Radix, RadixFmt}` - not used enough to stabilize * `IntoCow` - conflicts with `Into` and may come back later * `i32::{BITS, BYTES}` (and other integers) - not pulling their weight * `DebugTuple::formatter` - will be removed * `sync::Semaphore` - not used enough and confused with system semaphores Closes #23284 cc #27709 (still lots more methods though) Closes #27712 Closes #27722 Closes #27728 Closes #27735 Closes #27729 Closes #27755 Closes #27782 Closes #27798
2016-01-16Auto merge of #30934 - oli-obk:simplify_const_eval, r=alexcrichtonbors-20/+6
the `None` and the `DefVariant` paths were unused anyway.
2016-01-16Auto merge of #30533 - nikomatsakis:fulfillment-tree, r=aturonbors-227/+474
This PR introduces an `ObligationForest` data structure that the fulfillment context can use to track what's going on, instead of the current flat vector. This enables a number of improvements: 1. transactional support, at least for pushing new obligations 2. remove the "errors will be reported" hack -- instead, we only add types to the global cache once their entire subtree has been proven safe. Before, we never knew when this point was reached because we didn't track the subtree. - this in turn allows us to limit coinductive reasoning to structural traits, which sidesteps #29859 3. keeping the backtrace should allow for an improved error message, where we give the user full context - we can also remove chained obligation causes This PR is not 100% complete. In particular: - [x] Currently, types that embed themselves like `struct Foo { f: Foo }` give an overflow when evaluating whether `Foo: Sized`. This is not a very user-friendly error message, and this is a common beginner error. I plan to special-case this scenario, I think. - [x] I should do some perf. measurements. (Update: 2% regression.) - [x] More tests targeting #29859 - [ ] The transactional support is not fully integrated, though that should be easy enough. - [ ] The error messages are not taking advantage of the backtrace. I'd certainly like to do 1 through 3 before landing, but 4 and 5 could come as separate PRs. r? @aturon // good way to learn more about this part of the trait system f? @arielb1 // already knows this part of the trait system :)
2016-01-16simplify some codeOliver 'ker' Schneider-20/+6
2016-01-16Document `ObligationForest` better.Niko Matsakis-1/+1
2016-01-16Pacify tidy.Niko Matsakis-1/+2
2016-01-16Implement a hacky version of the DAG support we ultimately want, leavingNiko Matsakis-6/+52
a FIXME for later.
2016-01-16Detect cycles and specialize error reporting for Sized. It is importantNiko Matsakis-7/+187
to get the `Sized` error usable, since that hits new users frequently. Further work is needed for the error reporting for non-Sized cycle cases; those currently just fallback to the old path. Also adjust tests.
2016-01-16Permit coinductive match only for purely OIBIT backtraces.Niko Matsakis-11/+38
Better safe than sorry.
2016-01-16Fix bug in new stall checking code, it should consider integer variablesNiko Matsakis-1/+1
too.
2016-01-16fallout from removing the `errors_will_be_reported` flagNiko Matsakis-30/+35
2016-01-16only insert global predicates into the global cache once we'veNiko Matsakis-36/+27
completely proven them to be true
2016-01-16enable coinductive reasoning for structural traits, this isNiko Matsakis-0/+13
potentially just a stopgap measure
2016-01-16Auto merge of #30930 - oli-obk:fix/30887, r=arielb1bors-67/+7
this makes sure the checks run before typeck (which might use the constant or const function to calculate an array length) and gives prettier error messages in case of for loops and such (since they aren't expanded yet). fixes #30887 r? @pnkfelix
2016-01-16Auto merge of #30896 - petrochenkov:vkindmeta, r=alexcrichtonbors-8/+3
Also add tests for use of empty structs in cross-crate scenarios Some tests are commented out, they depend on fixes from https://github.com/rust-lang/rust/pull/30882
2016-01-15Auto merge of #30446 - michaelwu:associated-const-type-params-pt1, ↵bors-21/+30
r=nikomatsakis This provides limited support for using associated consts on type parameters. It generally works on things that can be figured out at trans time. This doesn't work for array lengths or match arms. I have another patch to make it work in const expressions. CC @eddyb @nikomatsakis
2016-01-15Preserve struct/variant kinds in metadataVadim Petrochenkov-8/+3
Add tests for use of empty structs in cross-crate scenarios
2016-01-15move const block checks before lowering stepOliver Schneider-67/+7
this makes sure the checks run before typeck (which might use the constant or const function to calculate an array length) and gives prettier error messages in case of for loops and such (since they aren't expanded yet).
2016-01-14Support generic associated constsMichael Wu-21/+30
2016-01-14switch the fulfillment context to use the new obligation forest;Niko Matsakis-129/+90
this commit won't build because, as of this version, no coinductive reasoning at all is really supported
2016-01-14modify trait checker to track the variables on which trait resolution isNiko Matsakis-46/+69
stalled rather than keeping this annoying mark; I checked that the original compile-time regression that the mark was intended to fix (https://github.com/rust-lang/rust/issues/18208) was still reasonable, but I've not done exhaustive measurements to see how important this "optimization" really is anymore
2016-01-14Require stability annotations on fields of tuple variantsVadim Petrochenkov-15/+1
2016-01-11Rollup merge of #30737 - Ms2ger:MutateMode, r=sanxiynSimonas Kazlauskas-10/+12
2016-01-08Change error scheme so that if projection fails we generate `A::B` instead ↵Niko Matsakis-5/+20
of `TyError`
2016-01-08Remove ErrorCandidate in favor of just generating an ambiguous resultNiko Matsakis-11/+11
2016-01-08Make coherence more tolerant of error types.Niko Matsakis-1/+4
Fixes #29857. Fixes #30589.
2016-01-07Rename fold_subitems_with to super_fold_withJeffrey Seyfried-180/+180
2016-01-07Refactor away extension traits RegionEscape and HasTypeFlagsJeffrey Seyfried-155/+132
2016-01-07Create a visitor for `TypeFoldable`s and use it to implement RegionEscape ↵Jeffrey Seyfried-682/+523
and HasTypeFlags (fixes #20298)
2016-01-06Auto merge of #30532 - nikomatsakis:cross-item-dependencies, r=mwbors-258/+455
This is roughly the same as my previous PR that created a dependency graph, but that: 1. The dependency graph is only optionally constructed, though this doesn't seem to make much of a difference in terms of overhead (see measurements below). 2. The dependency graph is simpler (I combined a lot of nodes). 3. The dependency graph debugging facilities are much better: you can now use `RUST_DEP_GRAPH_FILTER` to filter the dep graph to just the nodes you are interested in, which is super help. 4. The tests are somewhat more elaborate, including a few known bugs I need to fix in a second pass. This is potentially a `[breaking-change]` for plugin authors. If you are poking about in tcx state or something like that, you probably want to add `let _ignore = tcx.dep_graph.in_ignore();`, which will cause your reads/writes to be ignored and not affect the dep-graph. After this, or perhaps as an add-on to this PR in some cases, what I would like to do is the following: - [x] Write-up a little guide to how to use this system, the debugging options available, and what the possible failure modes are. - [ ] Introduce read-only and perhaps the `Meta` node - [x] Replace "memoization tasks" with node from the map itself - [ ] Fix the shortcomings, obviously! Notably, the HIR map needs to register reads, and there is some state that is not yet tracked. (Maybe as a separate PR.) - [x] Refactor the dep-graph code so that the actual maintenance of the dep-graph occurs in a parallel thread, and the main thread simply throws things into a shared channel (probably a fixed-size channel). There is no reason for dep-graph construction to be on the main thread. (Maybe as a separate PR.) Regarding performance: adding this tracking does add some overhead, approximately 2% in my measurements (I was comparing the build times for rustdoc). Interestingly, enabling or disabling tracking doesn't seem to do very much. I want to poke at this some more and gather a bit more data -- in some tests I've seen that 2% go away, but on others it comes back. It's not entirely clear to me if that 2% is truly due to constructing the dep-graph at all. The next big step after this is write some code to dump the dep-graph to disk and reload it. r? @michaelwoerister
2016-01-06Use `memoized` helper more often.Niko Matsakis-27/+15
2016-01-06Fix numerous typos, renamings, and minor nits raised by mw.Niko Matsakis-2/+2
2016-01-06Stop re-exporting MutateMode's variants.Ms2ger-10/+12
2016-01-05Workaround stage0 bugNiko Matsakis-1/+1
2016-01-05Refactor compiler to make use of dep-tracking-maps. Also, in cases whereNiko Matsakis-248/+400
we were using interior mutability (RefCells, TyIvar), add some reads/writes.
2016-01-05Annotate the compiler with information about what it is doing when.Niko Matsakis-13/+66
2016-01-05Add DepGraph to tcx.Niko Matsakis-1/+5
2016-01-05Introduce the DepGraph and DepTracking map abstractions,Niko Matsakis-1/+1
along with a README explaining how they are to be used
2016-01-06Auto merge of #30492 - wesleywiser:fix_extra_drops, r=pnkfelixbors-1/+34
Fixes #28159
2016-01-03Refactor candidate selectionFlorian Hahn-11/+12
2016-01-02Use for_each_implFlorian Hahn-24/+15
2016-01-02Manually check trait implementationsFlorian Hahn-12/+31
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-07-14 22:37:15 +0000