about summary refs log tree commit diff
path: root/src/librustc_resolve
AgeCommit message (Collapse)AuthorLines
2020-05-03resolve: Relax fresh binding disambiguation slightly to fix regressionVadim Petrochenkov-6/+10
2020-05-02fix rustdoc warningsTshepang Lekhonkhobe-3/+3
2020-04-28Use the query system to allocate.Camille GILLOT-2/+2
2020-04-27Rollup merge of #71438 - estebank:resolve-sugg-tiny, r=petrochenkovDylan DPC-15/+24
Tweak some suggestions in `rustc_resolve`
2020-04-27Rollup merge of #71419 - contrun:wrong-namespace-rustc-resolve, r=petrochenkovDylan DPC-45/+83
add message for resolution failure because wrong namespace closes https://github.com/rust-lang/rust/issues/71406
2020-04-26Tweak some suggestions in `rustc_resolve`Esteban Küber-15/+24
2020-04-26use defkind.descr in wrong namespace resolve failureYI-18/+21
2020-04-26Rollup merge of #70043 - mark-i-m:def-kind-more, r=eddybDylan DPC-4/+16
Add all remaining `DefKind`s. r? @eddyb or @Centril ~~I'm not sure if this is what you were thinking of. There are also a few places where I'm not sure what the correct choice is because I don't fully understand the meaning of some variants.~~ ~~In general, it feels a bit odd to add some of these as `DefKind`s (e.g. `Arm`) because they don't feel like definitions. Are there things that it makes sense not to add?~~
2020-04-25Rollup merge of #71544 - cuviper:filter_map_next, r=Mark-SimulacrumDylan DPC-6/+3
Replace filter_map().next() calls with find_map() These are semantically the same, but `find_map()` is more concise.
2020-04-24Replace filter_map().next() calls with find_map()Josh Stone-6/+3
These are semantically the same, but `find_map()` is more concise.
2020-04-24Avoid unused Option::map resultsJosh Stone-2/+6
These are changes that would be needed if we add `#[must_use]` to `Option::map`, per #71484.
2020-04-24Remove `Option` from the return type of `def_kind`.Eduard-Mihai Burtescu-1/+2
2020-04-24add a few more DefKindsmark-4/+15
make Map::def_kind take LocalDefId Co-Authored-By: Vadim Petrochenkov <vadim.petrochenkov@gmail.com> crates are DefKind::Mod
2020-04-24Rollup merge of #71235 - estebank:lt-sugg-2, r=ecstatic-morseDylan DPC-127/+126
Tweak `'static` suggestion code Fix #71196.
2020-04-23Address comments from reviewmarmeladema-11/+6
2020-04-23Modify `as_local_hir_id` to return a bare `HirId`marmeladema-12/+8
2020-04-23Modify `as_local_hir_id` to accept a `LocalDefId` instead of a `DefId`marmeladema-8/+19
2020-04-23librustc_middle: return LocalDefId instead of DefId in local_def_idmarmeladema-5/+9
2020-04-22Rollup merge of #71256 - cuviper:must_use_replace, r=estebankDylan DPC-2/+2
Lint must_use on mem::replace This adds a hint on `mem::replace`, "if you don't need the old value, you can just assign the new value directly". This is in similar spirit to the `must_use` on `ManuallyDrop::take`.
2020-04-22review commentEsteban Küber-1/+2
2020-04-22Tweak wordingEsteban Küber-2/+17
2020-04-22Tweak `'static` suggestion codeEsteban Küber-127/+110
Fix #71196.
2020-04-22add message for resolution failure because wrong namespaceYI-45/+80
2020-04-19Dogfood more or_patterns in the compilerJosh Stone-103/+112
2020-04-18remove build warningsTshepang Lekhonkhobe-3/+3
Code blocks that are not annotated are assumed to be Rust
2020-04-17Fix unused results from mem::replaceJosh Stone-2/+2
2020-04-16don't clone types that are copy (clippy::clone_on_copy)Matthias Krüger-2/+2
2020-04-14Remove `DUMMY_HIR_ID`marmeladema-8/+0
2020-04-14Rename AssocKind::Method to AssocKind::FnRustin-Liu-2/+2
Rename fn_has_self_argument to fn_has_self_parameter Rename AssocItemKind::Method to AssocItemKind::Fn Refine has_no_input_arg Refine has_no_input_arg Revert has_no_input_arg Refine suggestion_descr Move as_def_kind into AssocKind Signed-off-by: Rustin-Liu <rustin.liu@gmail.com> Fix tidy check issue Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
2020-04-09Auto merge of #70909 - marmeladema:issue70853/librustc_hir-local-def-id, r=eddybbors-37/+52
librustc_hir: return LocalDefId instead of DefId in local_def_id Its a first try to remove a few calls to `expect_local` and use `LocalDefId` instead of `DefId` where possible for #70853 This adds some calls to `.to_def_id()` to get a `DefId` back when needed. I don't know if I should push `LocalDefId` even further and change, for example, `Res::Def` to accept a `LocalDefId` instead of a `DefId` as second argument. cc @ecstatic-morse
2020-04-08Rollup merge of #70912 - estebank:reduce-type-param-sugg-verbosity, r=davidtwcoDylan DPC-2/+1
Do not suggest adding type param when `use` is already suggested Fix #70365, cc #70572.
2020-04-08librustc_resolve: fixup nit in previous commitmarmeladema-3/+3
2020-04-07Do not suggest adding type param when `use` is already suggestedEsteban Küber-2/+1
Fix #70365, cc #70572.
2020-04-08librustc_hir: return LocalDefId instead of DefId in local_def_idmarmeladema-36/+51
2020-04-03def_collector, visit_fn: account for no bodyMazdak Farrokhzad-4/+3
2020-04-01Rollup merge of #70081 - lcnr:issue68387, r=varkorDylan DPC-1/+1
add `unused_braces` lint Add the lint `unused_braces` which is warn by default. `unused_parens` is also extended and now checks anon consts. closes #68387 r? @varkor
2020-03-31fix internal lint falloutBastian Kauschke-1/+1
2020-03-30try_resolve_as_non_binding: span_bug -> delay_span_bugMazdak Farrokhzad-9/+8
2020-03-30rustc -> rustc_middle part 3 (rustfmt)Mazdak Farrokhzad-22/+22
2020-03-30rustc -> rustc_middle part 2Mazdak Farrokhzad-22/+22
2020-03-30rustc -> rustc_middle part 1Mazdak Farrokhzad-1/+1
2020-03-25Rename `def_span` to `guess_head_span`Esteban Küber-6/+7
2020-03-25Rollup merge of #70373 - Centril:canon-imports, r=Mark-SimulacrumMazdak Farrokhzad-1/+1
normalize some imports & prefer direct ones r? @Mark-Simulacrum
2020-03-24normalize some imports, prefer direct ones.Mazdak Farrokhzad-1/+1
2020-03-24resolve: Remove `rustc_attrs` as a standalone feature gateVadim Petrochenkov-11/+6
Now it only gates specific built-in attributes
2020-03-24Rollup merge of #70077 - Aaron1011:feature/new-def-path-ident, r=petrochenkovMazdak Farrokhzad-1/+4
Store idents for `DefPathData` into crate metadata Previously, we threw away the `Span` associated with a definition's identifier when we encoded crate metadata, causing us to lose location and hygiene information. We now store the identifier's `Span` in a side table, which gets encoded into the crate metadata. When we decode items from the metadata, we combine the name and span back into an `Ident`. This improves the output of several tests, which previously had messages suppressed due to dummy spans. This is a prerequisite for #68686, since throwing away a `Span` means that we lose hygiene information.
2020-03-23Rollup merge of #70233 - petrochenkov:superproc, r=ecstatic-morseMazdak Farrokhzad-1/+8
resolve: Do not resolve visibilities on proc macro definitions twice Fixes https://github.com/rust-lang/rust/issues/68921
2020-03-23Rollup merge of #69942 - estebank:sized-verbose-sugg, r=matthewjasperMazdak Farrokhzad-4/+4
Increase verbosity when suggesting subtle code changes Do not suggest changes that are actually quite small inline, to minimize the likelihood of confusion. Fix #69243.
2020-03-23resolve: Do not resolve visibilities on proc macro definitions twiceVadim Petrochenkov-1/+8
2020-03-23Auto merge of #70296 - Centril:rollup-wvfmb3n, r=Centrilbors-1/+10
Rollup of 9 pull requests Successful merges: - #69251 (#[track_caller] in traits) - #69880 (miri engine: turn error sanity checks into assertions) - #70207 (Use getentropy(2) on macos) - #70227 (Only display definition when suggesting a typo) - #70236 (resolve: Avoid "self-confirming" import resolutions in one more case) - #70248 (parser: simplify & remove unused field) - #70249 (handle ConstKind::Unresolved after monomorphizing) - #70269 (remove redundant closures (clippy::redundant_closure)) - #70270 (Clean up E0449 explanation) Failed merges: r? @ghost