| Age | Commit message (Collapse) | Author | Lines |
|
rustdoc: collapse blanket impls in the same way as normal impls
If the rustdoc setting _Auto-hide trait implementations documentation_ is activated (on by default), normal trait implementations are collapsed by default.
Blanket impls on the other hand are not collapsed. I'm not sure whether this is intended, but considering that the blanket impls for `From`, `Into`, `TryFrom`, ... are on every type, it would reduce the documentation bloat if these would also be collapsed when the setting is active.
(I'm not really familiar with the codebase and therefore just copied the code for the normal impl collapsing, but I could deduplicate it into a method, of course, too.)
|
|
r=petrochenkov,QuietMisdreavus
RFC 2008: Enum Variants
Part of #44109. See [Zulip topic](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/rfc-2008/near/132663140) for previous discussion.
r? @petrochenkov
cc @nikomatsakis
|
|
|
|
This commit adds support for non-exhaustive enum variants in rustdoc,
extending the existing support for non-exhaustive enums and structs.
|
|
Fix code block display in portability element in dark theme
Fixes #59261.
r? @QuietMisdreavus
A little screenshot:
<img width="521" alt="Screenshot 2019-03-26 at 00 37 49" src="https://user-images.githubusercontent.com/3050060/54961082-9a41c600-4f5f-11e9-8040-ae6f26d368ff.png">
|
|
Fix moving text in search tabs headers
Fixes #59005.
Now, the text in the search tabs headers isn't moving anymore.
r? @QuietMisdreavus
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Fix tables display
Fixes #58134.
cc @lzutao
r? @QuietMisdreavus
|
|
r=oli-obk
Fix search results interactions
The bug is visible when you search for "none": the second tab is empty and therefore it messes with the classes. Then when you try to use arrows on the third tab, it just crashes (because only 2 "search-results" are present and you're on tab 3).
r? @QuietMisdreavus
|
|
r=QuietMisdreavus
Improve stability tags display
The issue was the font color on dark theme. Fixed now:
<img width="352" alt="screenshot 2019-02-08 at 14 15 24" src="https://user-images.githubusercontent.com/3050060/52483276-bd810380-2bb3-11e9-8d46-95368569ac85.png">
r? @QuietMisdreavus
|
|
|
|
Don't default on std crate when manipulating browser history
Fixes #58263.
r? @QuietMisdreavus
|
|
Cleanup JS a bit
r? @QuietMisdreavus
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
GuillaumeGomez:dont-apply-impl-collapse-rules-to-trait-impls, r=Manishearth
Don't apply impl block collapse rules to trait impls
Fixes #58147.
r? @QuietMisdreavus
|
|
r=QuietMisdreavus
Prevent automatic collapse of methods impl blocks
Fixes #57582.
r? @QuietMisdreavus
|
|
r=Manishearth
[rustdoc] Improve file list display
Improve a bit the arrows to show a folder's file and the arrow to show/hide the left panel.
r? @QuietMisdreavus
|
|
rustdoc: wrap stability tags in colored spans
A cosmetic change to make the stability tags stand out a bit against the docs. Opening for discussion.
Before:


After:


r? @QuietMisdreavus
|
|
Re-enable history api on file:// protocol
Fixes #57135.
I tested locally on chrome (since it was the browser having issues with history management on `file://` protocol) and it worked fine so I guess we can re-enable it.
r? @QuietMisdreavus
|
|
|
|
|
|
|
|
|
|
Fix invalid background color
As discussed in #57814.
r? @QuietMisdreavus
|
|
|
|
Default images
Add default rust logo (the image at the top of the sidebar) and default favicon. No more missing image or inexistent icon on the documentation tabs!
r? @QuietMisdreavus
|
|
|
|
|
|
Fix non-clickable urls
Fixes #57695
I didn't find anywhere where this rule was useful. Why did you add it @JohnHeitmann?
r? @QuietMisdreavus
|
|
Fixes text becoming invisible when element targetted
Fixes #57628.
r? @QuietMisdreavus
|
|
Fix sources sidebar not showing up
Fixes #57601.
The order of imports made it so that the sidebar creation was called before the sidebar sources were created. Like this, when the sources are loaded, they create the sidebar as expected.
r? @QuietMisdreavus
|
|
|
|
|
|
|
|
|
|
[rustdoc] Fix crates filtering box not being filled
Currently, the filter crate box (at the left of the search input) is always empty. To get the number of keys of dictionary in JS, you need to call `Object.keys()` on it.
r? @QuietMisdreavus
|
|
|
|
Simplify foreign type rendering.
Simplified foreign type rendering by switching from tables to flexbox. Also, removed some seemingly extraneous elements like “ghost” spans.
Reduces element count on the `std::iter::Iterator` page by 30%. On my laptop it drops Iterator page load time from ~15s to ~10s. Frame times during scrolling are a hair lower too.
Known visual changes (happy to tweak based on feedback):
* The main `impl ...` headers are now getting the default, larger, h3 font size. This was an accident, but I liked how it turned out so I didn't fix it.
* There's a hair less vertical spacing between the end of a where block and the start of the next fn. Now, all spacing is consistent. I think this looks a bit worse. I may tweak vertical spacing more here or in a follow-up that cleans up vertical spacing more broadly.
* "[src]" links are all sized at 17px. A few were 19px in the original.
I haven't yet done heavy cross-browser or cross-crate testing. I was hoping to get a quick thumbs up or thumbs down here at this first draft, then if this is on the right track I'll spend some time on that testing.
TODO:
- [x] Test on Chrome
- [x] Test on Firefox
- [ ] ~~Test on UC Android~~
- [x] Test on Edge
- [x] Test on iOS safari
- [x] Test on desktop safari
- [x] Update automated tests
- [x] Increase vertical margin
- [x] Fix "Important traits for" hover overlap
- [x] Wait for #55798 to land & merge it
|