about summary refs log tree commit diff
path: root/src/librustdoc/html
AgeCommit message (Collapse)AuthorLines
2022-12-22Auto merge of #104889 - GuillaumeGomez:fix-impl-block-in-const-expr, r=notriddlebors-1/+1
Fix impl block in const expr Fixes #83026. The problem was that we didn't visit block expressions. Considering how big the [walk_expr](https://doc.rust-lang.org/nightly/nightly-rustc/src/rustc_hir/intravisit.rs.html#678) function is, I decided to instead implement the `hir` visitor on the struct. It also answers the question which was in a comment for `RustdocVisitor`: we should have used a visitor instead of our ad-hoc implementation. Adding this visitor also added some extra checks that weren't present before (check changes in `rustdoc-ui` tests). r? `@notriddle`
2022-12-22Fix ICEkadmin-4/+4
Left a todo awhile ago (I think), so fill it in to print a const for `Term`s.
2022-12-21rustdoc: simplify CSS and DOM for more-scraped-examplesMichael Howell-14/+8
This gets rid of the more-scraped-examples-inner wrapper, instead nesting the children directly and using absolute positioning for the toggle line.
2022-12-21rustdoc: simplify link anchor to section expand JSMichael Howell-7/+5
2022-12-20Rollup merge of #105972 - notriddle:notriddle/anchor, r=GuillaumeGomezMatthias Krüger-6/+2
rustdoc: simplify section anchor CSS Since f50bf8636e3b0296db82e631fe95c84324a46ccc changed anchors to be always positioned absolute, specifying it on hover as well is redundant.
2022-12-20rustdoc: simplify section anchor CSSMichael Howell-6/+2
Since f50bf8636e3b0296db82e631fe95c84324a46ccc changed anchors to be always positioned absolute, specifying it on hover as well is redundant.
2022-12-20rustdoc: prevent CSS layout of line numbers shrinking into nothingMichael Howell-0/+1
2022-12-20Rollup merge of #105914 - GuillaumeGomez:simplify-css-examples-code-blocks, ↵Matthias Krüger-10/+0
r=notriddle rustdoc: Simplify CSS for scraped code examples code blocks It's another approach than https://github.com/rust-lang/rust/pull/105894 for https://github.com/rust-lang/rust/pull/105823. I simply removed the extra style added for the scraped code blocks which appears to be unneeded. r? `@notriddle`
2022-12-20Rollup merge of #105912 - notriddle:notriddle/pre-line-height, r=GuillaumeGomezMatthias Krüger-0/+1
rustdoc: force pre tags to have the default line height Fixes #105906
2022-12-19Simplify CSS for code examples code blocksGuillaume Gomez-10/+0
2022-12-19rustdoc: remove width-limiter from source pages, stop overriding CSSMichael Howell-6/+2
2022-12-19rustdoc: force pre tags to have the default line heightMichael Howell-0/+1
Fixes #105906
2022-12-17Rollup merge of #105789 - notriddle:notriddle/examples-margin, r=GuillaumeGomezMatthias Krüger-9/+4
rustdoc: clean up margin CSS for scraped examples * This stops applying a margin to the additional example links. Because these links are `display: inline`, it doesn't actually do anything. * This switches from using a margin-bottom with a special exception for the examples themselves, plus an additional margin on the hide button, to instead using just margin-top on the examples, with an exception for the first one. No user-visible changes should result from this.
2022-12-17Rollup merge of #105780 - GuillaumeGomez:read-more-links, r=notriddleMatthias Krüger-8/+24
rustdoc: Don't add "Read more" link if there is no extra content Fixes #105677.
2022-12-16rustdoc: clean up margin CSS for scraped examplesMichael Howell-9/+4
* This stops applying a margin to the additional example links. Because these links are `display: inline`, it doesn't actually do anything. * This switches from using a margin-bottom with a special exception for the examples themselves, plus an additional margin on the hide button, to instead using just margin-top on the examples, with an exception for the first one. No user-visible changes should result from this.
2022-12-16Don't add "Read more" link if there is no extra contentGuillaume Gomez-8/+24
2022-12-16Rollup merge of #105764 - notriddle:notriddle/src-sidebar-toggle, ↵Matthias Krüger-11/+11
r=GuillaumeGomez rustdoc: name the source page sidebar-toggle `#src-sidebar-toggle` The old name doesn't get across where it's really supposed to be used.
2022-12-16Rollup merge of #105757 - notriddle:notriddle/sub-settings, r=GuillaumeGomezMatthias Krüger-6/+0
rustdoc: remove unused CSS `.sub-settings` Obsoleted when 9625ed8be7fa66c3ee5f78180a3d5911817096f6 changed the DOM.
2022-12-16Rollup merge of #105756 - notriddle:notriddle/example-wrap-tooltip, ↵Matthias Krüger-12/+6
r=GuillaumeGomez rustdoc: simplify CSS for codeblock tooltips Instead of making its parts `display: none` and then changing it on hover, just make the pseudo-element itself on hover.
2022-12-15rustdoc: name the source page sidebar-toggle `#src-sidebar-toggle`Michael Howell-11/+11
The old name doesn't get across where it's really supposed to be used.
2022-12-15rustdoc: remove unused CSS `.sub-settings`Michael Howell-6/+0
Obsoleted when 9625ed8be7fa66c3ee5f78180a3d5911817096f6 changed the DOM.
2022-12-15rustdoc: simplify CSS for codeblock tooltipsMichael Howell-12/+6
Instead of making its parts `display: none` and then changing it on hover, just make the pseudo-element itself on hover.
2022-12-15Migrate Jump to def links background to CSS variableGuillaume Gomez-11/+7
2022-12-15Rollup merge of #105730 - notriddle:notriddle/item-info-before, r=GuillaumeGomezMatthias Krüger-6/+0
rustdoc: remove no-op CSS `.item-info:before { color }` No content is set, so this pseudo-element does not exist. The CSS was obsoleted by 73d0f7c7b68784f1db0a1f53855c20d118a7e8b0.
2022-12-15Rollup merge of #105724 - ↵Matthias Krüger-1/+0
notriddle:notriddle/scrape-example-src-line-numbers, r=GuillaumeGomez rustdoc: remove no-op CSS `.scrape-example .src-line-numbers { margin: 0 }` This is the default CSS for `<pre>` tags in `.code-wrapper` anyway, so this line does nothing.
2022-12-15Rollup merge of #105707 - notriddle:notriddle/kbd-cursor, ↵Matthias Krüger-1/+0
r=jhpratt,GuillaumeGomez rustdoc: remove unnecessary CSS `kbd { cursor: default }` Added along with theme picker changes in https://github.com/rust-lang/rust/pull/47686/files#diff-7dc22a0530802d77c2f2ec9e834024a5657b6eab4055520fca46edc99a544413R1144, but no reason seems to have been given at the time for why this particular rule was added. Removing this rule results in `<kbd>` elements getting an I-bar, while the rule causes them to use the "default" arrow, but since selecting the text in these elements works fine, the I-bar is not misleading.
2022-12-14rustdoc: remove no-op CSS `.item-info:before { color }`Michael Howell-6/+0
No content is set, so this pseudo-element does not exist. The CSS was obsoleted by 73d0f7c7b68784f1db0a1f53855c20d118a7e8b0.
2022-12-14rustdoc: remove no-op CSS `.scrape-example .src-line-numbers { margin: 0 }`Michael Howell-1/+0
This is the default CSS for `<pre>` tags in `.code-wrapper` anyway, so this line does nothing.
2022-12-14rustdoc: remove unnecessary CSS `kbd { cursor: default }`Michael Howell-1/+0
Added along with theme picker changes in e78f1392b79779fa184f9a63e7be04ac7074a1c2, but no reason seems to have been given at the time for why this particular rule was added. Removing this rule results in `<kbd>` elements getting an I-bar, while the rule causes them to use the "default" arrow, but since selecting the text in these elements works fine, the I-bar is not misleading.
2022-12-14Rollup merge of #105684 - GuillaumeGomez:improve-rustdoc-var-name, r=notriddleMatthias Krüger-5/+5
Improve rustdoc markdown variable naming Opened on the right repository this time. :laughing: r? `@notriddle`
2022-12-14Rollup merge of #105676 - notriddle:notriddle/impl-docblock, r=GuillaumeGomezMatthias Krüger-0/+1
rustdoc: add CSS margin between `impl` docblock and its items ## Before ![image](https://user-images.githubusercontent.com/1593513/207471025-c27c298b-4d48-461b-918b-a965b09db4f1.png) ## After ![image](https://user-images.githubusercontent.com/1593513/207471759-1bbabf71-0932-441c-b044-ad0e392ba552.png)
2022-12-14Rollup merge of #105665 - notriddle:notriddle/popover-css-merge, ↵Matthias Krüger-6/+3
r=GuillaumeGomez rustdoc: simplify popover CSS * Merge the color-changing block into the regular rules, which was probably written that way because it used to be in the theme files, but has no reason to be written this way now that it's in rustdoc.css * Get rid of redundant `display: block`, since `position: absolute` blockifies the layout anyway.
2022-12-13rustdoc: add CSS margin between `impl` docblock and its itemsMichael Howell-0/+1
2022-12-13rustdoc: simplify popover CSSMichael Howell-6/+3
* Merge the color-changing block into the regular rules, which was probably written that way because it used to be in the theme files, but has no reason to be written this way now that it's in rustdoc.css * Get rid of redundant `display: block`, since `position: absolute` blockifies the layout anyway.
2022-12-13rustdoc: apply `pre-wrap` CSS to code-wrapped linksMichael Howell-2/+2
This is common syntax used for intra-doc links, so fixing it should help with doc formatting.
2022-12-13Improve rustdoc markdown variable namingGuillaume Gomez-5/+5
2022-12-13Rollup merge of #105639 - notriddle:notriddle/text-css, r=GuillaumeGomezMatthias Krüger-2/+1
rustdoc: remove `type="text/css" from stylesheet links MDN directly recommends this in <https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link>, since "CSS is the only stylesheet language used on the web." Like 07a243b2a46384235d7e2c08688978b7cf018973, but a few places that were missed the first time.
2022-12-13Rollup merge of #105629 - notriddle:notriddle/method-toggle-trait, ↵Matthias Krüger-3/+3
r=GuillaumeGomez rustdoc: stop treating everything in a trait item as a method This was added in 0b9b4b70683db6ef707755f520f139eb7b92a944 to fix the spacing on trait pages, but stopped being needed because 791f04e5a47ee78951552c7ed1545b2b01a44c74 stopped styling method-toggle. By only putting the method-toggle class on actual methods, the JS setting does the right thing.
2022-12-12rustdoc: remove `type="text/css" from stylesheet linksMichael Howell-2/+1
MDN directly recommends this in <https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link>, since "CSS is the only stylesheet language used on the web." Like 07a243b2a46384235d7e2c08688978b7cf018973, but a few places that were missed the first time.
2022-12-12rustdoc: stop treating everything in a trait item as a methodMichael Howell-3/+3
This was added in 0b9b4b70683db6ef707755f520f139eb7b92a944 to fix the spacing on trait pages, but stopped being needed because 791f04e5a47ee78951552c7ed1545b2b01a44c74 stopped styling method-toggle. By only putting the method-toggle class on actual methods, the JS setting does the right thing.
2022-12-12rustdoc: remove no-op CSS `.source pre { overflow: auto }`Michael Howell-1/+0
Since source pages use the `example-wrap` wrapper, this rule became redundant because there is already an `overflow-x: auto` rule.
2022-12-11Extend rustdoc hashtag prepended line testGuillaume Gomez-0/+8
2022-12-11Rollup merge of #105539 - GuillaumeGomez:hashtag-prepended-lines-non-rust, ↵Matthias Krüger-3/+41
r=notriddle rustdoc: Only hide lines starting with `#` in rust code blocks Fixes https://github.com/rust-lang/rust/issues/105527. So before approving, this is a big question: in rust code blocks, in a line starts with a `#`, we hide it in the output. However, should we do the same for non-rust code blocks too? I think it's a bit problematic to do it because `#` can be used for many things but I prefer to check first with everyone (might also be worth updating documentation too). cc ``@rust-lang/rustdoc`` r? ``@notriddle``
2022-12-10Add test for non-rust code block hashtag prepended linesGuillaume Gomez-0/+37
2022-12-10Don't take into account hashtag prepended lines if not in rust code blockGuillaume Gomez-3/+4
2022-12-10Clean up lifetimes in rustdoc syntax highlightingNilstrieb-24/+24
Removes a few lifetimes and renames some.
2022-12-09Rollup merge of #105504 - notriddle:notriddle/stab-css, r=GuillaumeGomezMatthias Krüger-27/+13
rustdoc: make stability badge CSS more consistent # Before ![image](https://user-images.githubusercontent.com/1593513/206763667-8e0deb74-be63-4906-8229-9a7eb51725c2.png) ![image](https://user-images.githubusercontent.com/1593513/206764007-6301c0e8-4594-4a41-ba93-105824dffee6.png) # After ![image](https://user-images.githubusercontent.com/1593513/206763698-e187cee2-3a50-4e48-b7b5-c3cfa41a797d.png) ![image](https://user-images.githubusercontent.com/1593513/206764058-3999ee67-1439-4c98-8216-b90575342aa8.png) # Description * They all get rounded corners now. A test case has been added for this, too. * There are now broadly two kinds of stability badge, where there used to be three: item-info "fat badge", and the "thin badge" in both item tables and in docblocks (which got merged). The fat badges can have icons, while the thin badges can't. * The old Ayu design doesn't make sense to me. Does anyone know why it was done that way?
2022-12-09Rollup merge of #105480 - notriddle:notriddle/sidebar-toggle-mobile-center, ↵Matthias Krüger-1/+0
r=GuillaumeGomez rustdoc: remove no-op mobile CSS `#sidebar-toggle { text-align }` Since 8b001b4da0716936e0ca32303cc0e3c5e53e42f8 make the sidebar toggle a flex container, and already centers its content in desktop mode, this rule doesn't do anything.
2022-12-09rustdoc: make stability badge CSS more consistentMichael Howell-27/+13
* They all get rounded corners now. A test case has been added for this, too. * There are now broadly two kinds of stability badge, where there used to be three: item-info "fat badge", and the "thin badge" in both item tables and in docblocks (which got merged). The fat badges can have icons, while the thin badges can't.
2022-12-09Rollup merge of #105442 - notriddle:notriddle/docblock-table-css, ↵Matthias Krüger-10/+7
r=GuillaumeGomez rustdoc: clean up docblock table CSS # Preview http://notriddle.com/notriddle-rustdoc-demos/table-2/test_dingus/fn.test.html # Before ![image](https://user-images.githubusercontent.com/1593513/206364287-1b80eaaf-2e0e-4138-8b56-4aa8ff39abac.png) # After ![image](https://user-images.githubusercontent.com/1593513/206364209-d287d165-31be-4de1-9b43-05b35ce2a86b.png) # Details * The rule `display: block` had no noticeable effect. Technically, because markdown tables have a tbody and thead, they get wrapped in an [anonymous table box] in the CSS tree, nested within the `<table>` element's block layout box. This rule was added in #87230 to make the table side-scrolling, but this same issue was doubly fixed in #88742 by wrapping it in an explicit `<div>` tag. Since accessibility advocates recommend the wrapper div over marking the table as `display: block`, we'll stick with that. https://adrianroselli.com/2020/11/under-engineered-responsive-tables.html * The rule `width: calc(100% - 2px)` had no visible effect, because the anonymous table box was not affected. * The style is tweaked to basically be the same style GitHub uses. In particular, it adds zebra stripes, and removes dotted borders. https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/Markdown.20table.20styling [anonymous table box]: https://www.w3.org/TR/CSS2/tables.html#anonymous-boxes
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-02-26 04:03:43 +0000