| Age | Commit message (Collapse) | Author | Lines | |
|---|---|---|---|---|
| 2019-02-11 | Use `Rc<[Symbol]>` instead of `Vec<Symbol>` to reduce # of allocs | Oliver Scherer | -2/+2 | |
| 2019-02-11 | Require a list of features to allow in `allow_internal_unstable` | Oliver Scherer | -1/+4 | |
| 2019-02-07 | libsyntax => 2018 | Taiki Endo | -9/+10 | |
| 2019-02-06 | Overhaul `syntax::fold::Folder`. | Nicholas Nethercote | -4/+3 | |
| This commit changes `syntax::fold::Folder` from a functional style (where most methods take a `T` and produce a new `T`) to a more imperative style (where most methods take and modify a `&mut T`), and renames it `syntax::mut_visit::MutVisitor`. The first benefit is speed. The functional style does not require any reallocations, due to the use of `P::map` and `MoveMap::move_{,flat_}map`. However, every field in the AST must be overwritten; even those fields that are unchanged are overwritten with the same value. This causes a lot of unnecessary memory writes. The imperative style reduces instruction counts by 1--3% across a wide range of workloads, particularly incremental workloads. The second benefit is conciseness; the imperative style is usually more concise. E.g. compare the old functional style: ``` fn fold_abc(&mut self, abc: ABC) { ABC { a: fold_a(abc.a), b: fold_b(abc.b), c: abc.c, } } ``` with the imperative style: ``` fn visit_abc(&mut self, ABC { a, b, c: _ }: &mut ABC) { visit_a(a); visit_b(b); } ``` (The reductions get larger in more complex examples.) Overall, the patch removes over 200 lines of code -- even though the new code has more comments -- and a lot of the remaining lines have fewer characters. Some notes: - The old style used methods called `fold_*`. The new style mostly uses methods called `visit_*`, but there are a few methods that map a `T` to something other than a `T`, which are called `flat_map_*` (`T` maps to multiple `T`s) or `filter_map_*` (`T` maps to 0 or 1 `T`s). - `move_map.rs`/`MoveMap`/`move_map`/`move_flat_map` are renamed `map_in_place.rs`/`MapInPlace`/`map_in_place`/`flat_map_in_place` to reflect their slightly changed signatures. - Although this commit renames the `fold` module as `mut_visit`, it keeps it in the `fold.rs` file, so as not to confuse git. The next commit will rename the file. | ||||
| 2019-01-13 | Implement basic input validation for built-in attributes | Vadim Petrochenkov | -0/+5 | |
| 2018-12-25 | Remove licenses | Mark Rousskov | -10/+0 | |
| 2018-08-28 | Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc. | Eduard-Mihai Burtescu | -2/+2 | |
| 2018-08-19 | mv (mod) codemap source_map | Donato Sciarra | -1/+1 | |
| 2018-06-27 | Implement `#[macro_export(local_inner_macros)]` | Vadim Petrochenkov | -0/+1 | |
| 2018-06-23 | hygiene: Merge `NameAndSpan` into `ExpnInfo` | Vadim Petrochenkov | -8/+6 | |
| 2018-05-17 | Add edition to expansion info | Vadim Petrochenkov | -1/+2 | |
| 2018-04-06 | Rename `PathSegment::identifier` to `ident` | Vadim Petrochenkov | -1/+1 | |
| 2017-11-26 | limit packed copy-out to non-generic Copy structs | Ariel Ben-Yehuda | -1/+1 | |
| 2017-08-30 | Make fields of `Span` private | Vadim Petrochenkov | -1/+1 | |
| 2017-08-12 | syntax: #[allow_internal_unsafe] bypasses the unsafe_code lint in macros. | Eduard-Mihai Burtescu | -0/+1 | |
| 2017-04-03 | Fix bug parsing `#[derive]` macro invocations. | Jeffrey Seyfried | -1/+2 | |
| 2017-03-29 | Merge `ExpnId` and `SyntaxContext`. | Jeffrey Seyfried | -24/+26 | |
| 2017-03-14 | Liberalize attributes. | Jeffrey Seyfried | -25/+20 | |
| 2017-03-14 | Refactor `Attribute` to use `Path` and `TokenStream` instead of `MetaItem`. | Jeffrey Seyfried | -2/+2 | |
| 2017-02-12 | Allow using inert attributes from `proc_macro_derive`s with ↵ | Jeffrey Seyfried | -135/+35 | |
| `#![feature(proc_macro)]`. | ||||
| 2017-02-12 | Move legacy custom derives collection into `resolver.find_attr_invoc()`. | Jeffrey Seyfried | -35/+1 | |
| 2017-02-05 | Move derive macro expansion into the MacroExpander | Josh Driver | -0/+218 | |
| This removes the expand_derives function, and sprinkles the functionality throughout the Invocation Collector, Expander and Resolver. | ||||
