about summary refs log tree commit diff
path: root/src/libsyntax/parse
AgeCommit message (Collapse)AuthorLines
2017-12-22Auto merge of #46732 - estebank:silence-recovered-blocks, r=petrochenkovbors-2/+6
Do not emit type errors on recovered blocks When a parse error occurs on a block, the parser will recover and create a block with the statements collected until that point. Now a flag stating that a recovery has been performed in this block is propagated so that the type checker knows that the type of the block (which will be identified as `()`) shouldn't be checked against the expectation to reduce the amount of irrelevant diagnostic errors shown to the user. Fix #44579.
2017-12-21Do not emit type errors on recovered blocksEsteban Küber-2/+6
When a parse error occurs on a block, the parser will recover and create a block with the statements collected until that point. Now a flag stating that a recovery has been performed in this block is propagated so that the type checker knows that the type of the block (which will be identified as `()`) shouldn't be checked against the expectation to reduce the amount of irrelevant diagnostic errors shown to the user.
2017-12-21Auto merge of #45930 - jplatte:generics_refactoring, r=eddybbors-24/+30
Generics refactoring (groundwork for const generics) These changes were suggested by @eddyb. After this change, the `Generics` contain one `Vec` of an enum for the generic parameters, rather than two separate `Vec`s for lifetime and type parameters. Type params and const params will need to be in a shared `Vec` to preserve their ordering, and moving lifetimes into the same `Vec` should simplify the code that processes `Generics`.
2017-12-21Add GenericParam, refactor Generics in ast, hir, rustdocJonas Platte-24/+30
The Generics now contain one Vec of an enum for the generic parameters, rather than two separate Vec's for lifetime and type parameters. Additionally, places that previously used Vec<LifetimeDef> now use Vec<GenericParam> instead.
2017-12-21Rollup merge of #46827 - petrochenkov:assocrecov2, r=estebankGuillaume Gomez-11/+51
syntax: Follow-up to the incorrect qpath recovery PR cc https://github.com/rust-lang/rust/pull/46788 Add tests checking that "priority" of qpath recovery is higher than priority of unary and binary operators Fix regressed parsing of paths with fn-like generic arguments r? @estebank
2017-12-21Auto merge of #46531 - cramertj:no-mo-modrs, r=nikomatsakisbors-43/+99
Implement non-mod.rs mod statements Fixes https://github.com/rust-lang/rust/issues/45385, cc https://github.com/rust-lang/rust/issues/44660 This will fail tidy right now because it doesn't recognize my UI tests as feature-gate tests. However, I'm not sure if compile-fail will work out either because compile-fail usually requires there to be error patterns in the top-level file, which isn't possible with this feature. What's the recommended way to handle this?
2017-12-20Fix parsing of paths with fn-like generic argumentsVadim Petrochenkov-9/+11
2017-12-20Move impls for qpath recovery trait from `ast.rs`Vadim Petrochenkov-2/+40
2017-12-19Implement non-mod.rs mod statementsTaylor Cramer-43/+99
2017-12-19Remove a token after closing delimiter from the span of macro in type positiontopecongiro-1/+1
2017-12-17syntax: recovery for incorrect associated item paths like `[T; N]::clone`Vadim Petrochenkov-20/+50
2017-12-17syntax: Rename `P::unwrap` into `P::into_inner`Vadim Petrochenkov-2/+2
2017-12-16in which `..` is suggested for erroneous `...` in struct field patternsZack M. Davis-1/+13
Resolves #46718.
2017-12-14When attempting to write str with single quote suggest double quotesEsteban Küber-1/+27
2017-12-14add trait aliases to ASTAlex Burka-14/+25
2017-12-14Use PathBuf instead of String where applicableOliver Schneider-32/+36
2017-12-09Use Try syntax for Option in place of macros or matchMatt Brubeck-4/+1
2017-12-07Auto merge of #46497 - AgustinCB:issue-46311, r=petrochenkovbors-13/+1
Modify message for keyword as identifier name This is a temporary solution to #46311. The message is generic enough to cover both cases and is probably a fine enough solution to the specific problem described in the task. However, the underlying reason for this to be wrong is that `next_token_inner` returns `Lifetime` even if the token is a label. That's not simple, as the syntax for both can be quite similar and it may need to take a look to the next token to make a decision. I'm not sure I have enough knowledge about the project to be able to solve that (yet!), so I thought I'll fix the immediate problem first.
2017-12-07address commentsAgustin Chiappe Berrini-3/+9
2017-12-07Auto merge of #46187 - notriddle:patch-1, r=QuietMisdreavusbors-1/+1
Rename C-like enum to Field-less enum There is no need to reference the C programming language to explain this concept.
2017-12-06and refactor to just move the checkingAgustin Chiappe Berrini-21/+3
2017-12-02Auto merge of #46381 - estebank:expected-span, r=nikomatsakisbors-5/+22
Point to next token when it is in the expected line r? @nikomatsakis
2017-12-02Auto merge of #46343 - jseyfried:fix_hygiene_bug, r=nrcbors-3/+10
Fix hygiene bug. Fixes #42708. r? @nrc
2017-12-02Auto merge of #45904 - sunjay:gat-parser, r=nikomatsakisbors-4/+43
Generic Associated Types Parsing & Name Resolution Hi! This PR adds parsing for generic associated types! :tada: :tada: :tada: Tracking Issue: #44265 ## Notes For Reviewers * [x] I still need to add the stdout and stderr files to my ui tests. It takes me a *long* time to compile the compiler locally, so I'm going to add this as soon as possible in the next day or so. * [ ] My current ui tests aren't very good or very thorough. I'm reusing the `parse_generics` and `parse_where_clause` methods from elsewhere in the parser, so my changes work without being particularly complex. I'm not sure if I should duplicate all of the generics test cases for generic associated types. It might actually be appropriate to duplicate everything here, since we don't want to rely on an implementation detail in case it changes in the future. If you think so too, I'll adapt all of the generics test cases into the generic associated types test cases. * [ ] There is still more work required to make the run-pass tests pass here. In particular, we need to make the following errors disappear: ``` error[E0110]: lifetime parameters are not allowed on this type --> ./src/test/run-pass/rfc1598-generic-associated-types/streaming_iterator.rs:23:41 | 23 | bar: <T as StreamingIterator>::Item<'static>, | ^^^^^^^ lifetime parameter not allowed on this type ``` ``` error[E0261]: use of undeclared lifetime name `'a` --> ./src/test/run-pass/rfc1598-generic-associated-types/iterable.rs:15:47 | 15 | type Iter<'a>: Iterator<Item = Self::Item<'a>>; | ^^ undeclared lifetime ``` There is a FIXME comment in streaming_iterator. If you uncomment that line, you get the following: ``` error: expected one of `!`, `+`, `,`, `::`, or `>`, found `=` --> ./src/test/run-pass/rfc1598-generic-associated-types/streaming_iterator.rs:29:45 | 29 | fn foo<T: for<'a> StreamingIterator<Item<'a>=&'a [i32]>>(iter: T) { /* ... */ } | ^ expected one of `!`, `+`, `,`, `::`, or `>` here ``` r? @nikomatsakis
2017-12-01Testing and fixesSunjay Varma-1/+1
2017-12-01Parsing where clauses correctly and documenting the grammar being parsedSunjay Varma-2/+8
2017-12-01Added run-pass tests for associated generic typesSunjay Varma-2/+2
2017-12-01Parsing generics in both trait items and impl itemsSunjay Varma-3/+36
2017-12-01Auto merge of #45997 - estebank:pub-ident, r=nikomatsakisbors-10/+111
Account for missing keyword in fn/struct definition Fix #38911.
2017-11-30Implement RFC 2128 (use_nested_groups)Pietro Albini-58/+85
This commit adds support for nested groups inside `use` declarations, such as `use foo::{bar, sub::{baz::Foo, *}};`.
2017-11-29Point to next token when it is in the expected lineEsteban Küber-5/+22
2017-11-28Fix hygiene bug.Jeffrey Seyfried-3/+10
2017-11-25Changed from note to span_suggestion_shortcolinmarsh19-1/+2
2017-11-25Fixed Err by passing "err"colinmarsh19-1/+1
2017-11-25Remove semicolon notecolinmarsh19-1/+5
Added note that specifies a semicolon should be removed after a given struct
2017-11-24Consume trailing doc comments to avoid parse errorsEsteban Küber-3/+2
2017-11-24Revert to correct recovery behaviorEsteban Küber-0/+1
2017-11-24Emit `DocComment` in bad location error but continue parsing struct fieldsEsteban Küber-2/+10
2017-11-24Suggest macro call when not sure that it is fn definitionEsteban Küber-19/+16
2017-11-24Do not attemt to continue parsing after `pub ident`Esteban Küber-105/+23
Try to identify the following code in order to provide better diagnostics, but return the error to bail out early during the parse.
2017-11-24Do not rewind parser and ignore following blocksEsteban Küber-52/+179
When encountering `pub ident`, attempt to identify the code that comes afterwards, wether it is a brace block (assume it is a struct), a paren list followed by a colon (assume struct) or a paren list followed by a block (assume a fn). Consume those blocks to avoid any further parser errors and return a `Placeholder` item in order to allow the parser to continue. In the case of unenclosed blocks, the behavior is the same as it is currently: no further errors are processed.
2017-11-24Account for missing keyword in fn/struct definitionEsteban Küber-1/+52
2017-11-22Update parser.rsMichael Howell-1/+1
2017-11-21Auto merge of #45771 - petrochenkov:crate, r=nikomatsakisbors-3/+15
Support `::crate` in paths cc https://github.com/rust-lang/rust/issues/45477 Fixes https://github.com/rust-lang/rust/issues/45229
2017-11-21Support `::crate` in pathsVadim Petrochenkov-3/+15
2017-11-20address review commentsAlex Burka-3/+2
2017-11-19use -Z flag instead of env varAlex Burka-1/+2
2017-11-11Accept interpolated patterns in trait method parametersVadim Petrochenkov-17/+9
Remove some outdated messages from "no patterns allowed" errors
2017-11-10Auto merge of #45773 - Badel2:dotdoteq, r=petrochenkovbors-15/+19
Add error for `...` in expressions Follow-up to https://github.com/rust-lang/rust/pull/44709 Tracking issue: https://github.com/rust-lang/rust/issues/28237 * Using `...` in expressions was a warning, now it's an error * The error message suggests using `..` or `..=` instead, and explains the difference * Updated remaining occurrences of `...` to `..=` r? petrochenkov
2017-11-08Auto merge of #45452 - estebank:colon-typo, r=nikomatsakisbors-44/+88
Detect `=` -> `:` typo in let bindings When encountering a let binding type error, attempt to parse as initializer instead. If successful, it is likely just a typo: ```rust fn main() { let x: Vec::with_capacity(10); } ``` ``` error: expected type, found `10` --> file.rs:3:31 | 3 | let x: Vec::with_capacity(10, 20); | -- ^^ | || | |help: did you mean assign here?: `=` | while parsing the type for `x` ``` Fix #43703.