summary refs log tree commit diff
path: root/src/test/ui/lifetimes/lifetime-errors
AgeCommit message (Collapse)AuthorLines
2020-03-12update testsMark Mansi-5/+5
2020-02-22update some testsMark Mansi-5/+5
2020-02-05Account for `fn()` types in lifetime suggestionsEsteban Küber-6/+2
2020-02-05review commentsEsteban Küber-1/+1
2020-02-05Suggest `'r` instead of `'lifetime`Esteban Küber-2/+2
2020-02-05When suggesting lifetimes, propose adding the new lifetime to all argumentsEsteban Küber-2/+2
2020-02-05Use spans for input borrowed types unrelated to return typeEsteban Küber-1/+5
2020-01-19review commentsEsteban Küber-1/+1
2020-01-19When encountering an expected named lifetime and none are present, suggest ↵Esteban Küber-1/+5
adding one
2019-11-18Auto merge of #58281 - mark-i-m:synthesis, r=estebankbors-0/+12
Add outlives suggestions for some lifetime errors This PR implements suggestion diagnostics for some lifetime mismatch errors. When the borrow checker finds that some lifetime 'a doesn't outlive some other lifetime 'b that it should outlive, then in addition to the current lifetime error, we also emit a suggestion for how to fix the problem by adding a bound: - If a and b are normal named regions, suggest to add the bound `'a: 'b` - If b is static, suggest to replace a with static - If b also needs to outlive a, they must be the same, so suggest unifying them We start with a simpler implementation that avoids diagnostic regression or implementation complexity: - We only makes suggestions for lifetimes the user can already name (eg not closure regions or elided regions) - For now, we only emit a help note, not an actually suggestion because it is significantly easier. Finally, there is one hack: it seems that implicit regions in async fn are given the name '_ incorrectly. To avoid suggesting '_: 'x, we simply filter out such lifetimes by name. For more info, see this internals thread: https://internals.rust-lang.org/t/mechanical-suggestions-for-some-borrow-checker-errors/9049/3 TL;DR Make suggestions to add a `where 'a: 'b` constraint for some lifetime errors. Details are in the paper linked from the internals thread above. r? @estebank TODO - [x] Clean up code - [x] Only make idiomatic suggestions - [x] don't suggest naming `&'a self` - [x] rather than `'a: 'static`, suggest replacing `'a` with `'static` - [x] rather than `'a: 'b, 'b: 'a`, suggest replacing `'a` with `'b` or vice versa - [x] Performance (maybe need a perf run when this is closer to the finish line?) - perf run was clean... - EDIT: perf run seems to only check non-error performance... How do we check that error performance didn't regress? - [x] Needs ui tests - [x] Integrate the `help` message into the main lifetime `error`
2019-11-07Update ui testsGuillaume Gomez-0/+25
2019-10-27update testsMark Mansi-0/+12
2019-09-12update testsMark Mansi-3/+3
2019-06-13Create fewer basic blocks in match MIR loweringMatthew Jasper-3/+3
2019-05-29Update ui test suite to use dynmemoryruins-9/+9
2019-05-12Change compare mode to use -Zborrowck=mirMatthew Jasper-0/+379
2019-05-03Update testsChristopher Vittal-52/+14
2019-04-25Rollup merge of #60160 - xldenis:fix-overlapping-zero-width-annotation, ↵Mazdak Farrokhzad-3/+1
r=estebank Fix #58270, fix off-by-one error in error diagnostics. This fixes #58270 by checking if two diagnostics overlap completely when we're calculating the line offset for each message.
2019-04-22Fix #58270, fix off-by-one error in error diagnostics.Xavier Denis-3/+1
2019-04-22Remove double trailing newlinesvarkor-3/+0
2019-04-18hide `--explain` hint if error has no extended infoAndy Russell-25/+0
2019-03-11Update testsVadim Petrochenkov-47/+47
2018-12-25Remove licensesMark Rousskov-406/+45
2018-10-17Update output for borrowck=migrate compare mode.David Wood-379/+0
This commit updates the test output for the updated NLL compare mode that uses `-Z borrowck=migrate` rather than `-Z borrowck=mir`. The previous commit changes `compiletest` and this commit only updates `.nll.stderr` files.
2018-10-15Deduplicate testsShotaro Yamada-45/+0
* `ui/lifetimes/lifetime-errors/ex3-both-anon-regions-both-are-structs-4` and `ex3-both-anon-regions-both-are-structs-3` * `ui/lint/lint-group-style` and `lint-group-nonstandard-style`
2018-09-19Update ui testsMatthew Jasper-8/+8
2018-09-12use structured suggestion for "missing mut" labelAndy Russell-5/+5
Fixes #54133.
2018-09-01Update testsBasile Desloges-302/+0
2018-08-27remove `let x = baz` which was obscuring the real errorNiko Matsakis-8/+8
2018-08-19Fix typos found by codespell.Matthias Krüger-2/+2
2018-08-14Update testsMatthew Jasper-33/+30
2018-08-14Merged migrated compile-fail tests and ui tests. Fixes #46841.David Wood-0/+1974
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-04-27 16:25:57 +0000