| Age | Commit message (Collapse) | Author | Lines | |
|---|---|---|---|---|
| 2021-12-17 | Fix typo in "new region bound" suggestion | Esteban Kuber | -2/+2 | |
| The lifetime name shoud always appear in text surrounded by `. | ||||
| 2021-11-14 | Move some tests to more reasonable directories | Caio | -0/+59 | |
| 2021-11-06 | Move some tests to more reasonable directories | Caio | -0/+53 | |
| 2021-10-18 | Remove regionck member constraint handling and leave it to mir borrowck | Oli Scherer | -52/+7 | |
| 2021-10-15 | simplify constrain_opaque_types | Niko Matsakis | -30/+40 | |
| 2021-09-30 | Rollup merge of #88838 - FabianWolff:issue-88472, r=estebank | Manish Goregaokar | -3/+4 | |
| Do not suggest importing inaccessible items Fixes #88472. For this example: ```rust mod a { struct Foo; } mod b { type Bar = Foo; } ``` rustc currently emits: ``` error[E0412]: cannot find type `Foo` in this scope --> test.rs:6:16 | 6 | type Bar = Foo; | ^^^ not found in this scope | help: consider importing this struct | 6 | use a::Foo; | ``` this is incorrect, as applying this suggestion leads to ``` error[E0603]: struct `Foo` is private --> test.rs:6:12 | 6 | use a::Foo; | ^^^ private struct | note: the struct `Foo` is defined here --> test.rs:2:5 | 2 | struct Foo; | ^^^^^^^^^^^ ``` With my changes, I get: ``` error[E0412]: cannot find type `Foo` in this scope --> test.rs:6:16 | 6 | type Bar = Foo; | ^^^ not found in this scope | = note: this struct exists but is inaccessible: a::Foo ``` As for the wildcard mentioned in #88472, I would argue that the warning is actually correct, since the import _is_ unused. I think the real issue is the wrong suggestion, which I have fixed here. | ||||
| 2021-09-26 | Improve diagnostics for inaccessible items | Fabian Wolff | -2/+5 | |
| 2021-09-26 | Do not suggest importing inaccessible items | Fabian Wolff | -4/+2 | |
| 2021-09-26 | Remove box syntax from most places in src/test outside of the issues dir | est31 | -25/+15 | |
| 2021-09-09 | Ignore automatically derived impls of `Clone` and `Debug` in dead code analysis | Fabian Wolff | -0/+1 | |
| 2021-08-30 | `feature(const_generics)` -> `feature(const_param_types)` | lcnr | -23/+0 | |
| 2021-08-11 | Modify structured suggestion output | Esteban Küber | -8/+8 | |
| * On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span | ||||
| 2021-07-22 | bless nll tests | Oli Scherer | -2/+2 | |
| 2021-07-20 | Get back the more precise suggestion spans of old regionck | Oli Scherer | -2/+2 | |
| 2021-07-14 | Warn about useless assignments of variables/fields to themselves | Fabian Wolff | -0/+1 | |
| 2021-06-22 | Updated tests to reflect specified types in E0121 | Deadbeef | -4/+4 | |
| 2021-03-29 | Suggest box/pin/arc ing receiver on method calls | Esteban Küber | -0/+10 | |
| 2020-11-10 | Rollup merge of #76765 - guswynn:async_return, r=tmandry | Jonas Schievink | -96/+128 | |
| Make it more clear what an about async fn's returns when referring to what it returns see #76547 This is *likely* not the ONLY place that this happens to be unclear, but we can move this fn to rustc_middle or something like that and reuse it if need be, to apply it to more diagnostics One outstanding question I have is, if the fn returns (), should I make the message more clear (what about `fn f()` vs `fn f() -> ()`, can you tell those apart in the hir?) R? `@tmandry` `@rustbot` modify labels +A-diagnostics +T-compiler | ||||
| 2020-10-20 | review comments | Esteban Küber | -3/+3 | |
| 2020-10-20 | Tweak "object unsafe" errors | Esteban Küber | -18/+25 | |
| Fix #77598. | ||||
| 2020-10-17 | Make it more clear when complaining about async fn's return types | Gus Wynn | -96/+128 | |
| 2020-10-16 | stabilize union with 'ManuallyDrop' fields and 'impl Drop for Union' | Ralf Jung | -3/+0 | |
| 2020-09-02 | pretty: trim paths of unique symbols | Dan Aloni | -8/+8 | |
| If a symbol name can only be imported from one place for a type, and as long as it was not glob-imported anywhere in the current crate, we can trim its printed path and print only the name. This has wide implications on error messages with types, for example, shortening `std::vec::Vec` to just `Vec`, as long as there is no other `Vec` importable anywhere. This adds a new '-Z trim-diagnostic-paths=false' option to control this feature. On the good path, with no diagnosis printed, we should try to avoid issuing this query, so we need to prevent trimmed_def_paths query on several cases. This change also relies on a previous commit that differentiates between `Debug` and `Display` on various rustc types, where the latter is trimmed and presented to the user and the former is not. | ||||
| 2020-07-22 | Further tweak wording of E0759 and introduce E0767 | Esteban Küber | -4/+4 | |
| 2020-07-09 | Reword incorrect `self` token suggestion | Esteban Küber | -3/+3 | |
| 2020-06-19 | Account for multiple impl/dyn Trait in return type when suggesting `'_` | Esteban Küber | -0/+5 | |
| 2020-06-15 | Change E0758 to E0759 to avoid conflict with #72912 | Esteban Küber | -4/+4 | |
| 2020-06-15 | small tweaks | Esteban Küber | -8/+3 | |
| 2020-06-15 | Register new eror code | Esteban Küber | -0/+2 | |
| 2020-06-15 | Use note for requirement source span | Esteban Küber | -6/+15 | |
| 2020-06-15 | review comments: wording | Esteban Küber | -3/+3 | |
| 2020-06-15 | Tweak wording and add error code | Esteban Küber | -7/+7 | |
| 2020-06-15 | Reduce verbosity of suggestion message and mention lifetime in label | Esteban Küber | -3/+3 | |
| 2020-05-30 | Tweak wording and spans of `'static` `dyn Trait`/`impl Trait` requirements | Esteban Küber | -18/+9 | |
| 2020-05-30 | review comment: tweak wording and account for span overlap | Esteban Küber | -2/+2 | |
| 2020-05-30 | Account for returned `dyn Trait` evaluating to `'static` lifetime | Esteban Küber | -4/+4 | |
| Provide a suggestion for `dyn Trait + '_` when possible. | ||||
| 2020-05-07 | reword "possible candidate" import suggestion | Andy Russell | -1/+1 | |
| 2020-03-23 | Update tests | John Kåre Alsaker | -16/+76 | |
| 2020-03-12 | update tests | Mark Mansi | -57/+57 | |
| 2020-02-28 | Account for arbitrary self types in E0599 | Esteban Küber | -5/+3 | |
| 2020-02-28 | Tweak wording | Esteban Küber | -1/+1 | |
| 2020-02-28 | Mention the full path of the implementing trait | Esteban Küber | -1/+1 | |
| 2020-02-28 | On single local candidate, use span label | Esteban Küber | -3/+3 | |
| 2020-02-27 | Revert "Backport only: avoid ICE on bad placeholder type" | Esteban Küber | -16/+2 | |
| This reverts commit 1cb555a1dc809a8d310354678ef9c43f01e41ad4. | ||||
| 2020-02-27 | Rollup merge of #69324 - estebank:ice-break-backport-bad-placeholder-type, ↵ | Yuki Okushi | -2/+16 | |
| r=Centril Backport only: avoid ICE on bad placeholder type #69148 has a proper fix, but it is too big to backport. This change avoids the ICE by actually emitting an appropriate error. The output will be duplicated in some cases, but that's better than the avoidable ICE. r? @Centril | ||||
| 2020-02-22 | update some tests | Mark Mansi | -57/+57 | |
| 2020-02-20 | Backport only: avoid ICE on bad placeholder type | Esteban Küber | -2/+16 | |
| #69148 has a proper fix, but it is too big to backport. This change avoids the ICE by actually emitting an appropriate error. The output will be duplicated in some cases, but that's better than the avoidable ICE. | ||||
| 2020-02-14 | Update tests | Matthew Jasper | -202/+5 | |
| 2020-02-09 | --bless --compare-mode=nll | Matthias Prechtl | -1/+1 | |
| 2020-02-02 | Use more appropriate spans on object unsafe traits and provide structured ↵ | Esteban Küber | -7/+12 | |
| suggestions when possible | ||||
