rust - https://github.com/rust-lang/rust

Age	Commit message (Collapse)	Author	Lines
2023-01-11	Move /src/test to /tests	Albert Larsan	-96/+0

2023-01-05	Tweak wording of fn call with wrong number of args	Esteban Küber	-2/+2

2022-12-13	Make some diagnostics not depend on the source of what they reference being ↵	Oli Scherer	-3/+0
	available
2022-09-03	Shrink suggestion span of argument mismatch error	Michael Goulet	-6/+6

2022-08-12	Point out a single arg if we have a single arg incompatibility	Michael Goulet	-2/+2

2022-06-10	Bless tests.	Camille GILLOT	-0/+5

2022-04-16	Implementation for 65853	Jack Huey	-18/+22
	This attempts to bring better error messages to invalid method calls, by applying some heuristics to identify common mistakes. The algorithm is inspired by Levenshtein distance and longest common sub-sequence. In essence, we treat the types of the function, and the types of the arguments you provided as two "words" and compute the edits to get from one to the other. We then modify that algorithm to detect 4 cases: - A function input is missing - An extra argument was provided - The type of an argument is straight up invalid - Two arguments have been swapped - A subset of the arguments have been shuffled (We detect the last two as separate cases so that we can detect two swaps, instead of 4 parameters permuted.) It helps to understand this argument by paying special attention to terminology: "inputs" refers to the inputs being expected by the function, and "arguments" refers to what has been provided at the call site. The basic sketch of the algorithm is as follows: - Construct a boolean grid, with a row for each argument, and a column for each input. The cell [i, j] is true if the i'th argument could satisfy the j'th input. - If we find an argument that could satisfy no inputs, provided for an input that can't be satisfied by any other argument, we consider this an "invalid type". - Extra arguments are those that can't satisfy any input, provided for an input that could be satisfied by another argument. - Missing inputs are inputs that can't be satisfied by any argument, where the provided argument could satisfy another input - Swapped / Permuted arguments are identified with a cycle detection algorithm. As each issue is found, we remove the relevant inputs / arguments and check for more issues. If we find no issues, we match up any "valid" arguments, and start again. Note that there's a lot of extra complexity: - We try to stay efficient on the happy path, only computing the diagonal until we find a problem, and then filling in the rest of the matrix. - Closure arguments are wrapped in a tuple and need to be unwrapped - We need to resolve closure types after the rest, to allow the most specific type constraints - We need to handle imported C functions that might be variadic in their inputs. I tried to document a lot of this in comments in the code and keep the naming clear.
2021-08-11	Modify structured suggestion output	Esteban Küber	-4/+4
	* On suggestions that include deletions, use a diff inspired output format * When suggesting addition, use `+` as underline * Color highlight modified span
2021-06-20	Specify if struct/enum in arg mismatch error	Smitty	-1/+1

2020-10-15	ensure arguments are included in count mismatch span	Andy Russell	-15/+27

2020-02-11	On mismatched argument count point at arguments	Esteban Küber	-12/+16

2019-10-24	Increase spacing for suggestions in diagnostics	Esteban Küber	-0/+4
	Make the spacing between the code snippet and verbose structured suggestions consistent with note and help messages.
2019-03-11	Update tests	Vadim Petrochenkov	-10/+10

2018-12-25	Remove licenses	Mark Rousskov	-6/+6

2018-03-14	update tests	Guillaume Gomez	-1/+1

2018-02-26	Update UI tests	Vadim Petrochenkov	-4/+4

2018-02-26	Update UI tests	Vadim Petrochenkov	-11/+11

2018-02-25	Update ui tests	Guillaume Gomez	-0/+1

2017-12-10	Point at whole method call instead of args	Esteban Küber	-7/+7
	To avoid confusion in cases where the code is ```rust fn foo() {} / foo( \| bar() \| ^^^ current diagnostics point here for arg count mismatch \| ); \|_^ new diagnostic span points here ``` as this leads to confusion making people think that the diagnostic is talking about `bar`'s arg count, not `foo`'s. Point at `fn`s definition on arg mismatch, just like we do for closures.
2017-11-24	Merge cfail and ui tests into ui tests	Oliver Schneider	-10/+10

2017-11-16	Remove left over dead code from suggestion diagnostic refactoring	Oliver Schneider	-4/+0

2017-10-13	Pass the full span for method calls	Geoffry Song	-13/+41

2017-08-28	Suggest `Ok(())` when encountering `Ok()`	Oliver Schneider	-0/+45