about summary refs log tree commit diff
path: root/src/test/ui/suggestions
AgeCommit message (Collapse)AuthorLines
2018-11-22Suggest correct syntax when writing type arg instead of assoc typeEsteban Küber-0/+39
When confusing an associated type with a type argument, suggest the appropriate syntax. Given `Iterator<isize>`, suggest `Iterator<Item = isize>`.
2018-11-10in which the E0618 "expected function" diagnostic gets a makeoverZack M. Davis-0/+24
Now the main span focuses on the erroneous not-a-function callee, while showing the entire call expression is relegated to a secondary span. In the case where the erroneous callee is itself a call, we point out the definition, and, if the call expression spans multiple lines, tentatively suggest a semicolon (because we suspect that the "outer" call is actually supposed to be a tuple). The new `bug!` assertion is, in fact, safe (`confirm_builtin_call` is only called by `check_call`, which is only called with a first arg of kind `ExprKind::Call` in `check_expr_kind`). Resolves #51055.
2018-10-18Auto merge of #54979 - estebank:path-unsized, r=nikomatsakisbors-0/+21
Custom E0277 diagnostic for `Path` r? @nikomatsakis we have a way to target `Path` exclusively, we need to identify the correct text to show to consider #23286 fixed.
2018-10-10Custom E0277 diagnostic for `Path`Esteban Küber-0/+21
2018-10-09Reword `rustc_on_unimplemented` errors for `Iterator`Esteban Küber-9/+9
- Detect one element array of `Range` type, which is potentially a typo: `for _ in [0..10] {}` where iterating between `0` and `10` was intended. (#23141) - Suggest `.bytes()` and `.chars()` for `String`. - Suggest borrowing or `.iter()` on arrays (#36391) - Suggest using range literal when iterating on integers (#34353) - Do not suggest `.iter()` by default (#50773, #46806)
2018-08-15Split tests more and bless them againashtneoi-602/+653
2018-08-15Move tests into their own directoryashtneoi-0/+0
2018-08-15Re-bless testashtneoi-0/+63
2018-08-15Test move-into-Fn/FnMut errors tooashtneoi-2/+530
2018-08-15Add another FIXME about suggestionsashtneoi-81/+83
2018-08-15Bless UI testsashtneoi-21/+21
2018-08-15Test patterns in tuplesashtneoi-71/+249
2018-08-15Coalesce var-is-not-Copy notes per moveashtneoi-141/+40
2018-08-15Dedup suggestionsashtneoi-102/+643
2018-08-15Remove unnecessary underscoreashtneoi-7/+7
2018-08-15Change TODOs to FIXMEsashtneoi-9/+9
2018-08-15Make move errors more consistent with typeck errorsashtneoi-22/+22
2018-08-15Make move error suggestions clearerashtneoi-80/+80
2018-08-15Add backquotes around variable nameashtneoi-51/+51
2018-08-15Fix move errors for index expressionsashtneoi-17/+44
The suggestion logic gave up too early, which kept it from suggesting borrowing index expressions.
2018-08-15Test move errors for index expressionsashtneoi-80/+313
2018-08-15Add more TODOsashtneoi-3/+3
2018-08-15Suggest match ergonomics, not `ref`/`ref mut`ashtneoi-0/+933
2018-08-14Merged migrated compile-fail tests and ui tests. Fixes #46841.David Wood-0/+394
2018-07-18Implement existential typesOliver Schneider-3705/+0
2018-07-17Fix doc linkFelix Rabe-1/+1
The link for comparison: - https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types--sized (broken) - https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types-and-sized (fixed) This commit is the result of (first) searching via: find src -type f -print0 | xargs -0 fgrep -l dynamically-sized-types--sized and then replacing all relevant occurrences via: find src/{libcore,test/ui} -type f -print0 | xargs -0 sed -i.bak \ s/dynamically-sized-types--sized/dynamically-sized-types-and-sized/g find src/{libcore,test/ui} -type f -name '*.bak' -print0 | xargs -0 rm (Note: Commands run on macOS 10.13 (BSD). `sed -i.bak` should work on GNU/Linux as well, but not tested.)
2018-07-12Bless one more testashtneoi-0/+11
2018-07-12span_suggestioncsmoe-12/+1
2018-07-12add nll stderrcsmoe-0/+11
2018-07-12update testcsmoe-3/+3
2018-07-12lint with ref_spancsmoe-1/+1
2018-07-12update testcsmoe-0/+25
2018-07-12Also test `&mut self` suggestionashtneoi-4/+24
2018-07-12Reimplement some "add `mut`" suggestions under NLLashtneoi-3/+11
Specifically, `&self` -> `&mut self` and explicit `ref` -> `ref mut`. Implicit `ref` isn't handled yet and causes an ICE.
2018-07-12Add `ref mut` suggestion testashtneoi-0/+52
2018-07-11Rollup merge of #52231 - lqd:error_mesg, r=GuillaumeGomezGuillaume Gomez-2/+2
Fix typo in error message E0277 Fix a typo we stumbled upon by accident :) r? @estebank
2018-07-10Fix typo in error message E0277Rémy Rakic-2/+2
2018-07-09Fix issue #51515 and update testashtneoi-2/+12
2018-07-09Add test case from issue #51515ashtneoi-0/+35
2018-07-07Added UI testcases for #52049Pramod Bisht-0/+44
2018-07-01Do not suggest changes to str literal if it isn't oneEsteban Küber-0/+28
2018-07-01Auto merge of #51883 - estebank:placement-suggestion, r=varkorbors-0/+31
Suggest correct comparison against negative literal When parsing as emplacement syntax (`x<-1`), suggest the correct syntax for comparison against a negative value (`x< -1`). Fix #45651.
2018-06-29Fix incorrect type mismatch label pointing at return typeEsteban Küber-3/+34
2018-06-28Suggest correct comparison against negative literalEsteban Küber-0/+31
When parsing as emplacement syntax (`x<-1`), suggest the correct syntax for comparison against a negative value (`x< -1`).
2018-06-28Provide existing ref suggestions for more E0308 errorsEsteban Küber-1/+4
2018-06-26Rollup merge of #51104 - zackmdavis:dynamo, r=nikomatsakisPietro Albini-1/+1
add `dyn ` to display of dynamic (trait) types ~~I'm not sure we want the `dyn` in the E0277 "trait bound [...] is not satisfied" messages ("bound" sounds like a different thing in contrast to the names of specific trait-object types like `Box<dyn Trait>`), but I'm finding the code I would need to change that hard to follow—the [display object seems to](https://github.com/rust-lang/rust/blob/f0805a4421449bd6fe3096d63820fbebe2bfcd1d/src/librustc/traits/error_reporting.rs#L600) be a [`Predicate::Trait`](https://github.com/rust-lang/rust/blob/f0805a4421449bd6fe3096d63820fbebe2bfcd1d/src/librustc/ty/mod.rs#L962) variant, whose [`Display` implementation](https://github.com/rust-lang/rust/blob/f0805a4421449bd6fe3096d63820fbebe2bfcd1d/src/librustc/util/ppaux.rs#L1309) calls `.print` on its `PolyTraitPredicate` member, [which is a type alias](https://github.com/rust-lang/rust/blob/f0805a4421449bd6fe3096d63820fbebe2bfcd1d/src/librustc/ty/mod.rs#L1112) for `ty::Binder<TraitPredicate<'tcx>>`, whose [`Display` implementation](https://github.com/rust-lang/rust/blob/f0805a4421449bd6fe3096d63820fbebe2bfcd1d/src/librustc/util/ppaux.rs#L975-L985) ... _&c._— so maybe it's time to pull-request this and see what reviewers think.~~ Resolves #49277 (?). r? @nikomatsakis
2018-06-23structured suggestion and rewording for `...` expression syntax errorZack M. Davis-0/+30
Now that `..=` inclusive ranges are stabilized, people probably shouldn't be using `...` even in patterns, even if it's still legal there (see #51043). To avoid drawing attention to `...` being a real thing, let's reword this message to just say "unexpected token" rather "cannot be used in expressions".
2018-06-23add `dyn` to display of dynamic (trait) type namesZack M. Davis-1/+1
The `dyn Trait` syntax was stabilized in 199ee327. Resolves #49277.
2018-06-22Auto merge of #51670 - estebank:issue-51634, r=oli-obkbors-3/+69
Don't suggest incorrect syntax Fix #51634.
2018-06-22Auto merge of #51463 - estebank:error-codes, r=nikomatsakisbors-3/+4
Various changes to existing diagnostics * [Add code to `invalid ABI` error, add span label, move list to help to make message shorter](https://github.com/rust-lang/rust/pull/51463/commits/23ae5af274defa9ff884f593e44a2bbcaf814a02): ``` error[E0697]: invalid ABI: found `路濫狼á́́` --> $DIR/unicode.rs:11:8 | LL | extern "路濫狼á́́" fn foo() {} //~ ERROR invalid ABI | ^^^^^^^^^ invalid ABI | = help: valid ABIs: cdecl, stdcall, fastcall, vectorcall, thiscall, aapcs, win64, sysv64, ptx-kernel, msp430-interrupt, x86-interrupt, Rust, C, system, rust-intrinsic, rust-call, platform-intrinsic, unadjusted ``` * [Add code to incorrect `pub` restriction error](https://github.com/rust-lang/rust/pull/51463/commits/e96fdea8a38f39f99f8b9a4000a689187a457e08) * [Add message to `rustc_on_unimplemented` attributes in core to have them set a custom message _and_ label](https://github.com/rust-lang/rust/pull/51463/commits/2cc7e5ed307aee936c20479cfdc7409d6b52a464): ``` error[E0277]: `W` does not have a constant size known at compile-time --> $DIR/unsized-enum2.rs:33:8 | LL | VA(W), | ^ `W` does not have a constant size known at compile-time | = help: the trait `std::marker::Sized` is not implemented for `W` = help: consider adding a `where W: std::marker::Sized` bound = note: no field of an enum variant may have a dynamically sized type ``` ``` error[E0277]: `Foo` cannot be sent between threads safely --> $DIR/E0277-2.rs:26:5 | LL | is_send::<Foo>(); | ^^^^^^^^^^^^^^ `Foo` cannot be sent between threads safely | = help: the trait `std::marker::Send` is not implemented for `Foo` ``` ``` error[E0277]: can't compare `{integer}` with `std::string::String` --> $DIR/binops.rs:16:7 | LL | 5 < String::new(); | ^ no implementation for `{integer} < std::string::String` and `{integer} > std::string::String` | = help: the trait `std::cmp::PartialOrd<std::string::String>` is not implemented for `{integer}` ``` ``` error[E0277]: can't compare `{integer}` with `std::result::Result<{integer}, _>` --> $DIR/binops.rs:17:7 | LL | 6 == Ok(1); | ^^ no implementation for `{integer} == std::result::Result<{integer}, _>` | = help: the trait `std::cmp::PartialEq<std::result::Result<{integer}, _>>` is not implemented for `{integer}` ``` ``` error[E0277]: a collection of type `i32` cannot be built from an iterator over elements of type `i32` --> $DIR/type-check-defaults.rs:16:19 | LL | struct WellFormed<Z = Foo<i32, i32>>(Z); | ^ a collection of type `i32` cannot be built from `std::iter::Iterator<Item=i32>` | = help: the trait `std::iter::FromIterator<i32>` is not implemented for `i32` note: required by `Foo` --> $DIR/type-check-defaults.rs:15:1 | LL | struct Foo<T, U: FromIterator<T>>(T, U); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` * [Add link to book for `Sized` errors](https://github.com/rust-lang/rust/pull/51463/commits/1244dc7c283323aea1a3457a4458d590a3e160c8): ``` error[E0277]: `std::fmt::Debug + std::marker::Sync + 'static` does not have a constant size known at compile-time --> $DIR/const-unsized.rs:13:29 | LL | const CONST_0: Debug+Sync = *(&0 as &(Debug+Sync)); | ^^^^^^^^^^^^^^^^^^^^^^ `std::fmt::Debug + std::marker::Sync + 'static` does not have a constant size known at compile-time | = help: the trait `std::marker::Sized` is not implemented for `std::fmt::Debug + std::marker::Sync + 'static` = note: to learn more, visit <https://doc.rust-lang.org/book/second-edition/ch19-04-advanced-types.html#dynamically-sized-types--sized> = note: constant expressions must have a statically known size ``` * [Point to previous line for single expected token not found](https://github.com/rust-lang/rust/pull/51463/commits/48165168fb0f059d8536cd4a2276b609d4a7f721) (if the current token is in a different line)
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-07-13 09:39:08 +0000