about summary refs log tree commit diff
path: root/src/tools/clippy
AgeCommit message (Collapse)AuthorLines
2019-06-21submodules: Update clippy from 149a988 to 5a11ed7bLzu Tao-7/+34
2019-06-19Update clippy from 868f168c to 149a988Lzu Tao-7/+7
2019-06-18submodules: update clippy from be5d17fe to 868f168cMatthias Krüger-9/+7
Changes: ```` rustup https://github.com/rust-lang/rust/pull/61836/ fix suggestion for floating points inequality ````
2019-06-16submodules: update clippy from 7b2a7a22 to be5d17feMatthias Krüger-8/+10
Changes: ```` Fix wrong lifetime of TyCtxt Use replace_region_in_file for creating the lint list Restructure rename tests Register rename to the LintStore. Rename REDUNDANT_STATIC_LIFETIME to REDUNDANT_STATIC_LIFETIMES. Remove pub from RedundantStaticLifetime.visit_type function. Rename const_static_lifetime to redundant_static_lifetime. Merge StaticConst and StaticStatic lints into StaticConst. Use RedundantStaticLifetime in StaticStatic. Move type-checking logic in StaticConst to RedundantStaticLifetime. Add lint for statics with explicit static lifetime. minor fix make it pass dogfood run rustfmt fix padding and put clippy someplaces show default lint levels group printing prelim arg parse move Lint static def into its own module switch to sorted usable lints Update clippy_dev/src/main.rs initial commit for help improvements on clippy-driver ````
2019-06-13submodules: update clippy from c0dbd34b to 7b2a7a22Matthias Krüger-8/+8
Changes: ```` Fix wrong lifetime of TyCtxt travis: Wait at most 30 minutes for base test Typos and minor grammar corrections Adds lint for integer division redundant_closure_for_method_calls fixes: lint does not trigger when there is a difference in mutability lint does not trigger when the method belongs to a trait which is not implemebted directly (Deref) Fix implicit_return docs rustup https://github.com/rust-lang/rust/pull/61758/files Remove wrong lifetime from LintContext Workaround for rust-lang/rustfmt#3615 Fixing eta with respect to lazy evaluation. ````
2019-06-09submodules: update clippy from 71be6f62 to c0dbd34bMatthias Krüger-7/+7
Changes: ```` travis: disable rls integration test. rustup https://github.com/rust-lang/rust/pull/61669/ Add OUTER_EXPN_INFO lint ````
2019-06-06submodules: update clippy from 20da8f45 to 71be6f62Matthias Krüger-11/+7
Changes: ```` rustup https://github.com/rust-lang/rust/pull/57428/ Remove `to_string()`s from CompilerLintFunctions Fix comment grammar Fix .map(..).unwrap_or_else(..) bad suggestion add suggestions for print/write with newline lint ````
2019-06-03Update clippyManish Goregaokar-8/+10
2019-06-01Update clippyManish Goregaokar-10/+8
2019-05-30submodules: update clippy from fb33fad0 to d2f51228Matthias Krüger-8/+10
Changes: ```` Rustup to https://github.com/rust-lang/rust/pull/61203 rustup https://github.com/rust-lang/rust/pull/60928 rustup https://github.com/rust-lang/rust/pull/61164 (which is included in https://github.com/rust-lang/rust/pull/61274) ````
2019-05-28Update clippy submoduleOliver Scherer-7/+9
2019-05-26Update clippy submoduleOliver Scherer-10/+8
2019-05-22Update clippy submoduleOliver Scherer-11/+9
2019-05-18Update clippyManish Goregaokar-13/+10
2019-05-16Update clippyManish Goregaokar-7/+16
2019-05-14submodules: update clippy from 3710ec59 to ad3269c4Matthias Krüger-19/+7
Changes: ```` Rustfmt all the things Clippy dogfood Update for compiletest changes Use symbols instead of strings Rustup to rustc 1.36.0-nightly (1764b2972 2019-05-12) Add regression test for identity_conversion FP UI test cleanup: Extract many_single_char_names tests Add tests for empty_loop lint Add in_macro again Rename in_macro to in_macro_or_desugar ````
2019-05-11Update clippyManish Goregaokar-9/+17
2019-05-08submodules: update clippy from fc96aa03 to 341c96afMatthias Krüger-9/+9
Changes: ```` rustup https://github.com/rust-lang/rust/pull/60586 Add test for #771. Clean up while_loop tests ````
2019-05-04submodules: update clippy from 2ed0b3bf to fc96aa03Matthias Krüger-8/+10
Changes: ```` Rustup to rustc 1.36.0-nightly (13fde05b1 2019-05-03) Fix link in into_iter_on_array documentation remove function body from "too many args" span check closure arguments before use it format code fix suggestion for search_is_some fix suggestion for search_is_some naively change |&x| to |x| in stderr file cargo fmt useless_let_if_seq handle interior mutability ````
2019-05-01Update clippyManish Goregaokar-8/+8
2019-04-29Update clippyManish Goregaokar-12/+8
2019-04-29Update clippyManish Goregaokar-9/+10
2019-04-25submodules: update clippy from 9897442f to 8c0e038fMatthias Krüger-15/+10
Changes: ```` Rustup for https://github.com/rust-lang/rust/pull/59042 Update pulldown_cmark to 0.5 Only run AppVeyor on r+, try and the master branch Remove approx_constant known problems Suppress let_and_return if let has attributes Add test for or_fun_call macro suggestion UI test cleanup: Extract needless_range_loop tests Change "if types change" to "if you later change the type" ````
2019-04-23Update clippyManish Goregaokar-9/+15
2019-04-21Update ClippyIgor Matuszewski-8/+10
Fixes fallout from https://github.com/rust-lang/rust/pull/60124. Closes #60154.
2019-04-19submodules: update clippy from fbb3a47b to cafbe7f2Matthias Krüger-10/+8
Changes: ```` Update compiletest_rs Typo Fix dogfood error Add lint PathBufPushOverwrite Update *.stderr file Remove code duplication Format code Add test for debug_assert!(false) Don't lint debug_assert!(false) Add run-rustfix for option_map_or_none lint Move two cast_lossless tests to their correct files Change naive_bytecount applicability MaybeIncorrect Add tests for declare_lint_pass and impl_lint_pass Use lint pass macros Document `declare_lint_pass!` Fix lint_without_lint_pass internal lint Use {get,match}_def_path from LateContext Remove uplifted functions {get,match}_def_path from Clippy Add run-rustfix for len_zero lint Add run-rustfix for bool_comparison lint Add run-rustfix for deref_addrof lint while_let_loop uses placeholders in suggestions Remove rust-toolchain file from clippy_dev Update adding_lints.md Update PULL_REQUEST_TEMPLATE Add new lint checklist Create PULL_REQUEST_TEMPLATE Only suggest .copied() for Option right now Also suggest .copied() when .clone() is called on a Copy type Suggest .copied() instead of .cloned() in map_clone when dealing with references Deny rustc internal lints Remove clippy::default_hash_types internal lint Enable -Zunstable-options in .cargo/config ````
2019-04-14Update clippyManish Goregaokar-9/+9
2019-04-12Update Clippyflip1995-8/+10
2019-04-09submodules: update clippy from 92612c9d to 37f5c1ecMatthias Krüger-10/+8
Changes: ```` Remove force-host and explain no-prefer-dynamic Escape a single quote in single_char_pattern hint cargo fmt Re-add tmp feature to compiletest Remove libtest from deps Re-allow clippy::identity_conversion in compiletest Use latest compiletest-rs Revert tests/compile-test.rs to 61aa5c957c219abe1fb2d1b5e51db8b365b4f565 Fix ICE in suspicious_else_formatting use a multispan for MANY_SINGLE_CHAR_NAMES Add missing `// run-pass` annotations to ICE tests Remove clippy_dev as dev-dependency NFC: fix typos rustup https://github.com/rust-lang/rust/pull/59657 Add TransmutingNull Lint * Late Lint pass, catches: * One liner: 0 -> null -> transmute * One liner: std:null() -> transmute * Const (which resolves to null) -> transmute * UI Test case for Lint * Updated test for issue 3849, because now the lint that code generated is in Clippy. * Expanded `const.rs` miri-based Constant Folding code, to cover raw pointers Run rustfmt Set level of identity_conversion FP to warn Rustup to https://github.com/rust-lang/rust/pull/58805 rustup 41316f0449025394fdca6606d3fdb3b8f37a9872 Updated source to match with recent rustc `master` toolchain changes Fix dogfood error of question_mark lint fix Fix question_mark lint+test use `span_lint_and_sugg` in `explicit_counter_loop` Fix some test failures Hacky rustup run cargo fmt rustup https://github.com/rust-lang/rust/pull/59096/ Change explicit_counter_loop's message to add parentheses if necessary Change explicit_counter_loop's message to reflect original variable name cargo fmt Add rustfix tests for mistyped_literal_suffix lint Move some `unreadable_literal` ui tests to correct file Add implementation for the EarlyLintPass trait into the Adding Lints documentation. Add rust-toolchain for clippy_dev ````
2019-03-18Update Clippy, RLS and RustfmtMateusz Mikuła-8/+10
2019-03-10Update clippyManish Goregaokar-5/+10
2019-03-08update clippyljedrz-8/+5
2019-03-03Update ClippyIgor Matuszewski-5/+8
2019-02-25update clippyljedrz-5/+5
2019-02-20update clippy: partially HirIdifyljedrz-10/+5
2019-02-19Update clippy to rust-lang/rust-clippy@d61b25419beManish Goregaokar-7/+9
2019-02-18Update Clippy to rust-lang/rust-clippy@32ee30flip1995-12/+7
2019-02-03submodule: update clippy from 6ce78d1 to 3bda548Hirokazu Hata-10/+11
2019-01-30submodules: update clippy from f1753522 to 6ce78d12Matthias Krüger-8/+10
Changes: ```` wildcard_match_arm: Update lint count. wildcard_match_arm: add nesting issue to known. wildcard_match_arm: lint only enum matches. wildcard_match_arm: update ui test stderr wildcard_match_arm: format test. wilcard_match_arm: run rustfmt. wildcard_match_arm: add lint properly. wildcard_match_arm: rename function. wildcard_match_arm: add simple ui test. wildcard_match_arm: expand lint scope. Change match_wild lint name to WILDCARD_MATCH_ARM. Add match_wild lint (#3649). fetch_prs_between: add .sh file ending cargo fmt Update various docs Use built-in entry_fn detection over self-built cargo fmt Reorganize conditionals: Run faster checks first Maybe fix ICE? Add initial version of const_fn lint Fix `unit_arg` false positive Rustfmt Check hypothetically failing conversion Remove tests for deprecated items Update more changed iterator paths Atomics constants are now handled by the deprecation lint Update changed iterator paths Update const slice processing update test stderr run cargo fmt rustup https://github.com/rust-lang/rust/pull/57907/ Fix documentation for `slow_vector_initialization` rustup https://github.com/rust-lang/rust/pull/57726 Remove unsafe_vector_initialization from added lints Prevent incorrect cast_lossless suggestion in const_fn Incorporate review suggestions Fix dogfood tests on Appveyor test(versioncheck): Use .no_deps() test(versioncheck): Fix version equality check chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1 dependencies: update itertools from 0.7 to 0.8 Add script to fetch GitHub PRs between two commits gitattributes: Treat .fixed files as rust files Update changelog with all changes since 0.0.212 Fix `expect_fun_call` lint suggestions ````
2019-01-24submodules: update clippy from 280069dd to f1753522Matthias Krüger-6/+8
Changes: ```` Rustup allow assertions_on_constants for collapsible_if and missing_test_files Improving comments. Added rustfix to the test. Improve span shortening. Added "make_return" and "blockify" convenience methods in Sugg and used them in "needless_bool". Fixed potential mistakes with nesting. Added tests. Fix automatic suggestion on `use_self`. run ./util/dev update_lints add assert(true/false, some message) tests change assert_checks to assertions_on_constants run ./util/dev update_lints Add unreachable!() as option Add assert(true) and assert(false) lints ````
2019-01-22submodules: update clippy from 1838bfe5 to 280069ddMatthias Krüger-9/+7
Changes: ```` Rustfmt all the things Don't make decisions on values that don't represent the decision Rustup Actually check for constants. formatting fix Update clippy_lints/src/needless_bool.rs formatting fix needless bool lint suggestion is wrapped in brackets if it is an "else" clause of an "if-else" statement Remove negative integer literal checks. Fix `implicit_return` false positives. ````
2019-01-21submodules: update clippy from 1b89724b to 1838bfe5Matthias Krüger-16/+8
Changes: ```` Fixing typo in CONTRIBUTING.md Fix breakage due to rust-lang/rust#57651 Run rustfmt Fixed breakage due to rust-lang/rust#57489 Fix breakage due to rust-lang/rust#57755 Catch up with `format_args` change Fix bad `while_let_on_iterator` suggestion. rustup https://github.com/rust-lang/rust/pull/57747 Fixing issues pointed out by dogfood tests. Update to collect all the files then throw the error. Adding a test for checking if test files are missing. Remove bors.toml add applicability to lint name suggestion ````
2019-01-15submodules: update clippy from c63b6349 to 1b89724bMatthias Krüger-10/+15
Changes: ```` Really fix issue number in `map_clone` test Fix issue number in `map_clone` test Remove `map_clone` fixed known problem Fix `map_clone` bad suggestion Add run-rustfix to unnecessary_fold Add run-rustfix to unit_arg test Add run-rustfix for types test Add run-rustfix to starts_ends_with Add run-rustfix to replace_const test Add run-rustfix to redundant_field_names Missing docs: don't require documenting Global Asm items. Add run-rustfix for precedence test Add run-rustfix to mem_replace test Add run-rustfix to map_clone test Add run-rustfix to large_digit_groups Add run-rustfix to into_iter_on_ref Add run-rustfix to infallible_destructuring_match Add rustfix to inconsistent_digit_grouping test Add run-rustfix to explicit_write test Add run-rustfix to excessive_precision test Add run-rustfix to duration_subsec test Disable deprecated_cfg_attr lint for inner attributes Add run-rustfix to collapsible_if test Update Readme Update Readme for (arguably) better readability rustup: the features if_while_or_patterns has been stabilized Fix comments in clippy_lints/src/len_zero.rs readme: update travis badge to reflect migration from travis-ci.org to travis-ci.com Remove all copyright license headers Move cast_ref_to_mut list to correctness group Rustftmt Don't import ty::Ref in cast_ref_to_mut lint Move a hint to an error message in cast_ref_to_mut lint Add a note to cast_ref_to_mut lint Use ty::Ref instead of ty::TyKind::Ref cast_ref_to_mut lint Add missing ` in default lint Improve tests and exclude nested impls Update `unwrap_get` code review suggestions Update known problems Restrict use_self on nested items Improve `get_unwrap` suggestion ````
2019-01-07submodules: update clippy from 39bd8449 to c63b6349Matthias Krüger-8/+11
Changes: ```` Revert "tests: used_underscore_binding_macro: disable random_state lint." Revert "Auto merge of #3603 - xfix:random-state-lint, r=phansch" rustup https://github.com/rust-lang/rust/pull/56837 rustup (don't know the exact PR unfortunately) Add itertools to integration tests tests: used_underscore_binding_macro: disable random_state lint. Trigger `use_self` lint in local macros Add run-rustfix where it already passes rustup: https://github.com/rust-lang/rust/pull/55517 Make clippy work with parallel rustc Add ui/for_kv_map test for false positive in #1279 Update to latest compiletest-rs release add testcase for #3462 deps: bump rustc_tools_util version from 0.1.0 to 0.1.1 just in case... Use compiletest's aux-build header instead of include macro rustc_tool_utils: fix failure to create proper non-repo version string when used in crates on crates.io, bump version rustfmt UI test cleanup: Extract ifs_same_cond tests Extract IteratorFalsePositives into option_helpers.rs UI test cleanup: Extract for_kv_map lint tests UI test cleanup: Extract lint from methods.rs test Fix test for rust-lang/rust#57250 Limit infinite_iter collect() check to known types Some improvements to util documentation Use hashset for name blacklist Reformat random_state tests Use node_id_to_type_opt instead of node_it_to_type in random_state Check pattern equality while checking declaration equality random_state lint Move constant write checks to temporary_assignment lint Use an FxHashSet for valid idents in documentation lint Fix suggestion for unnecessary_ref lint Update CONTRIBUTING.md for rustfix tests Update .fixed files via update-references.sh Run rustfix on first UI test Use WIP branch for compiletest_rs ````
2018-12-30submodules: update clippy from f7bdf500 to 39bd8449Matthias Krüger-8/+8
Changes: ```` UI test cleanup: Extract iter_skip_next from methods.rs Update test output after rebase Remove false negatives from known problems Implement use_self for tuple structs Document known problems rustup https://github.com/rust-lang/rust/pull/56225/ Remove unnecessary `use` statements after `cargo fix` Apply cargo fix --edition-idioms fixes Use match ergonomics for booleans lint Use match ergonomics for block_in_if_condition lint Use match ergonomics for bit_mask lint Use match ergonomics for attrs lint Use match ergonomics for assign_ops lint Use match ergonomics for artithmetic lint Use match ergonomics for approx_const lint Remove crate:: prefixes from crate paths Support array indexing expressions in unused write to a constant Mark writes to constants as side-effect-less Update README local run command to remove syspath Remove unsafe from consts clippy lints Fix formatting Merge new_without_default_derive into new_without_default Only print out question_mark lint when it actually triggered Add failing test Reinserted commata Recomend `.as_ref()?` in certain situations Deduplicate some code? ````
2018-12-28submodules: update clippy from fc24fce7 to f7bdf500Matthias Krüger-7/+9
Fixes clippy toolstate Changes: ```` Match on ast/hir::ExprKind::Err Update *.stderr files Use -Zui-testing flag Mention S-inactive-closed PRs in the CONTRIBUTING.md tests: fix formatting and update test output base tests: make sure to fail CI if tests need formatting base tests: switch to nightly toolchain before checking formatting of tests with rustfmt rustup https://github.com/rust-lang/rust/pull/57069 Rustfmt. fix breakage from rust-lang/rust#57088 fix a couple of ftrivial typos (NFC). update CARGO_CLIPPY_HELP string to suggest tool lints. rustc_tools_util: add readme rustc_tool_utils: expand Cargo.toml with a few keywords in preparation for crates.io release Fix macro detection in `empty_loop`. Changed `macro_backtrace()` to `in_macro()`. Fix lint detection on macro expansion. ````
2018-12-23submodules: update clippy from a416c5e0 to fc24fce7Matthias Krüger-13/+7
Fixes clippy tool state Changes: ```` FIXME > TODO rustup https://github.com/rust-lang/rust/pull/56992 Document map_clone known problems #498 Remove header link test: panic at map_unit_fn.rs:202 for map() without args rm unused file map_unit_fn.stderr panic at map_unit_fn.rs:202 for map() without args Change contrib.md hierarchy, link to it from readme Workaround rust-lang/rust#43081 Teach `suspicious_else_formatting` about `if .. {..} {..}` Link to `rustc_driver` crate in plugin mutex_atomic: Correct location of AtomicBool and friends Update README local run command to specify syspath Do not mark as_ref as useless if it's followed by a method call Changes lint sugg to bitwise and operator `&` Run update_lints after renaming Rename lint to MODULE_NAME_REPETITIONS Add renaming tests Move renaming to the right place Implements lint for order comparisons against bool fix(module_name_repeat): Try to register renamed lint, not valid yet Fix an endless loop in the tests. Fix `implicit_return` false positives. chore(moduel_name_repeat): Rename stutter lint to module_name_repeat to avoid ableist language Make integration tests fail on 'E0463' base tests: make sure cargo-clippy binary can be called directly Revert "Merge pull request #3257 from o01eg/remove-sysroot" ````
2018-12-15submodules: update clippy from b7a431ea to a416c5e0Matthias Krüger-19/+12
Changes: ```` rustup rust-lang/rust#52994 Fix test Line length fix Remove references to sized for end users Remove DUMMY_SP Add suggestion for replacement Update lint definitions Lint for Vec<Box<T: Sized>> - Closes #3530 Fix doc_markdown mixed case false positive question_mark: Suggest Some(opt?) for if-else redundant_field_names: Do not trigger on path with type params question_mark: Lint only early returns question_mark: Fix applicability Remove obsolete comment new_without_default, partialeq_ne_impl: Use span_lint_node Update .stderr after rebase cargo fmt and remove stabilized feature Make suggestion Applicability::MachineApplicable Address review feedback Extract method Check array lengths to prevent OOB access Add suggestion for explicit_write lint Fix write_with_newline escaping false positive ````
2018-12-13Update ClippyIgor Matuszewski-14/+16
2018-12-08submodules: update clippy from 1df5766c to a3c77f6aMatthias Krüger-14/+14
Changes: ```` s/rustfmt-preview/rustfmt/ Swap if branches Fix c_void false positive caused by libc refactoring rustup https://github.com/rust-lang/rust/pull/56502 ( .hir -> .hir() ) typo: emum → enum Fix format. Add sysroot gettinh code to dogfood tests. Add sysroot getting code to tests. Don't try to determine sysroot. rustc_driver will use default value. Fix suggestion for multiple derefs Fix `clone_on_copy` not detecting derefs sometimes ````
generated by cgit-pink 1.4.1-3-g733a5 (git 2.37.1) at 2026-04-27 02:56:59 +0000