summary refs log tree commit diff
path: root/src/tools/tidy
AgeCommit message (Collapse)AuthorLines
2024-06-06Rollup merge of #126064 - GuillaumeGomez:migrate-run-make-manual-crate-name, ↵Jubilee-1/+0
r=jieyouxu Migrate `run-make/manual-crate-name` to `rmake.rs` Part of https://github.com/rust-lang/rust/issues/121876. r? ``@jieyouxu``
2024-06-06Migrate `run-make/manual-crate-name` to `rmake.rs`Guillaume Gomez-1/+0
2024-06-06skip `src/tools/libcxx-version` from tidyonur-ozkan-0/+1
Signed-off-by: onur-ozkan <work@onurozkan.dev>
2024-06-05Rollup merge of #125622 - oli-obk:define_opaque_types15, r=compiler-errorsMatthias Krüger-2/+1
Winnow private method candidates instead of assuming any candidate of the right name will apply partially reverts https://github.com/rust-lang/rust/pull/60721 My original motivation was just to avoid the `delay_span_bug` (by attempting to thread the `ErrorGuaranteed` through to here). But then I realized that the error message is wrong. It refers to the `Foo<A>::foo` instead of `Foo<B>::foo`. This is almost invisible, because both functions are the same, but on different lines, so `-Zui-testing` makes it so the test is the same no matter which of these two functions is referenced. But there's a much more obvious bug: If `Foo<B>` does not have a `foo` method at all, but `Foo<A>` has a private `foo` method, then we'll refer to that one. This has now been fixed, and we report a normal `method not found` error. The way this is done is by creating a list of all possible private functions (just like we create a list of the public functions that can actually be called), and then winnowing it by analyzing where bounds and `Self` types to see if any of the found methods can actually apply (again, just like with the list of public functions). I wonder if there is room for doing the same thing with unstable functions instead of running all of method resolution twice. r? ``@compiler-errors`` for method resolution stuff
2024-06-05Rollup merge of #125683 - Oneirical:patience-testing-test, r=jieyouxuJubilee-3/+0
Rewrite `suspicious-library`, `resolve-rename` and `incr-prev-body-beyond-eof` `run-make` tests in `rmake.rs` format Part of #121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Some oddly specific ignore flags in `incr-prev-body-beyond-eof`: ```rs // ignore-none // ignore-nvptx64-nvidia-cuda ``` it could be interesting to run a try job, but it seems there is no nvidia-cuda in the CI settings (`jobs.yml`). try-job: armhf-gnu
2024-06-04rewrite suspicious-library in rmakeOneirical-1/+0
2024-06-04Give test a more useful nameOli Scherer-1/+0
2024-06-04Move tests to a more appropriate directoryOli Scherer-1/+1
2024-06-04Show that it will pick up the entirely wrong function as a private candidateOli Scherer-1/+1
2024-06-03Auto merge of #125383 - Oneirical:bundle-them-up, r=jieyouxubors-3/+0
Rewrite `emit`, `mixing-formats` and `bare-outfile` `run-make` tests in `rmake.rs` format Part of #121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). try-job: x86_64-msvc
2024-06-02Remove some allowed-makefilesOneirical-3/+0
2024-06-02Rollup merge of #125808 - ↵Jubilee-1/+0
GuillaumeGomez:migrate-run-make-c-link-to-rust-dylib, r=jieyouxu Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs` Part of https://github.com/rust-lang/rust/issues/121876. First commit comes from https://github.com/rust-lang/rust/pull/125773. r? `@jieyouxu`
2024-06-02Rollup merge of #125849 - GuillaumeGomez:migrate-emit-named-files, r=jieyouxuJubilee-1/+0
Migrate `run-make/emit-named-files` to `rmake.rs` Part of https://github.com/rust-lang/rust/issues/121876. r? `@jieyouxu`
2024-06-02Migrate `run-make/c-link-to-rust-dylib` to `rmake.rs`Guillaume Gomez-1/+0
2024-06-01Migrate `run-make/emit-named-files` to `rmake.rs`Guillaume Gomez-1/+0
2024-06-01Migrate `run-make/cdylib` to `rmake.rs`Guillaume Gomez-1/+0
2024-05-30compiletest: clarify COMPILETEST_NEEDS_ALL_LLVM_COMPONENTS errorRalf Jung-0/+3
also improve wording for an ignore reason
2024-05-30Auto merge of #125744 - fmease:rollup-ky7d098, r=fmeasebors-5/+0
Rollup of 7 pull requests Successful merges: - #125653 (Migrate `run-make/const-prop-lint` to `rmake.rs`) - #125662 (Rewrite `fpic`, `simple-dylib` and `issue-37893` `run-make` tests in `rmake.rs` or ui test format) - #125699 (Streamline `x fmt` and improve its output) - #125701 ([ACP 362] genericize `ptr::from_raw_parts`) - #125723 (Migrate `run-make/crate-data-smoke` to `rmake.rs`) - #125733 (Add lang items for `AsyncFn*`, `Future`, `AsyncFnKindHelper`'s associated types) - #125734 (ast: Revert a breaking attribute visiting order change) r? `@ghost` `@rustbot` modify labels: rollup
2024-05-30Rollup merge of #125723 - GuillaumeGomez:migrate-run-make-crate-data-smoke, ↵León Orell Valerian Liehr-1/+0
r=jieyouxu Migrate `run-make/crate-data-smoke` to `rmake.rs` Part of https://github.com/rust-lang/rust/issues/121876. r? ``@jieyouxu``
2024-05-30Rollup merge of #125662 - Oneirical:more-tests-again, r=jieyouxuLeón Orell Valerian Liehr-3/+0
Rewrite `fpic`, `simple-dylib` and `issue-37893` `run-make` tests in `rmake.rs` or ui test format Part of #121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
2024-05-30Rollup merge of #125653 - GuillaumeGomez:migrate-const-prop-lint, r=jieyouxuLeón Orell Valerian Liehr-1/+0
Migrate `run-make/const-prop-lint` to `rmake.rs` Part of https://github.com/rust-lang/rust/issues/121876. r? ``@jieyouxu``
2024-05-29Auto merge of #125702 - workingjubilee:tell-tidy-about-csky, r=nikicbors-0/+1
Give tidy the good news about C-SKY It seems this was overlooked in https://github.com/rust-lang/rust/pull/125472 because we don't test C-SKY much yet. Fixes #125697 r? `@erikdesjardins`
2024-05-29give tidy the good news about C-SKYJubilee Young-0/+1
2024-05-29rewrite and rename issue-37893 to rmakeOneirical-2/+0
2024-05-29convert simple-dylib to ui testOneirical-1/+0
2024-05-29Migrate `run-make/crate-data-smoke` to `rmake.rs`Guillaume Gomez-1/+0
2024-05-29Remove Makefiles from allowed_run_make_makefilesChris Denton-5/+0
2024-05-29Migrate `run-make/const-prop-lint` to `rmake.rs`Guillaume Gomez-1/+0
2024-05-29Rollup merge of #125638 - Oneirical:lets-find-some-tests, r=jieyouxu许杰友 Jieyou Xu (Joe)-3/+0
Rewrite `lto-smoke`, `simple-rlib` and `mixing-deps` `run-make` tests in `rmake.rs` format Part of #121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
2024-05-29Rollup merge of #125226 - madsmtm:fix-mac-catalyst-tests, r=workingjubilee许杰友 Jieyou Xu (Joe)-2/+1
Make more of the test suite run on Mac Catalyst Combined with https://github.com/rust-lang/rust/pull/125225, the only failing parts of the test suite are in `tests/rustdoc-js`, `tests/rustdoc-js-std` and `tests/debuginfo`. Tested with: ```console ./x test --target=aarch64-apple-ios-macabi library/std ./x test --target=aarch64-apple-ios-macabi --skip=tests/rustdoc-js --skip=tests/rustdoc-js-std --skip=tests/debuginfo tests ``` Will probably put up a PR later to enable _running_ on (not just compiling for) Mac Catalyst in CI, though not sure where exactly I should do so? `src/ci/github-actions/jobs.yml`? Note that I've deliberately _not_ enabled stack overflow handlers on iOS/tvOS/watchOS/visionOS (see https://github.com/rust-lang/rust/issues/25872), but rather just skipped those tests, as it uses quite a few APIs that I'd be weary about getting rejected by the App Store (note that Swift doesn't do it on those platforms either). r? ``@workingjubilee`` CC ``@thomcc`` ``@rustbot`` label O-ios O-apple
2024-05-28rewrite incr-prev-body-beyond-eof in rmakeOneirical-1/+0
2024-05-28rewrite resolve-rename in rmakeOneirical-1/+0
2024-05-28Rewrite simple-rlib to rmakeOneirical-1/+0
2024-05-28Make more of the test suite run on Mac CatalystMads Marquart-2/+1
This adds the `only-apple`/`ignore-apple` compiletest directive, and uses that basically everywhere instead of `only-macos`/`ignore-macos`. Some of the updates in `run-make` are a bit redundant, as they use `ignore-cross-compile` and won't run on iOS - but using Apple in these is still more correct, so I've made that change anyhow.
2024-05-28Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs`Guillaume Gomez-1/+0
2024-05-27rewrite mixing-deps in rmakeOneirical-1/+0
2024-05-27rewrite lto-smoke to rmakeOneirical-1/+0
2024-05-27Rollup merge of #125542 - ↵Matthias Krüger-1/+0
GuillaumeGomez:migrate-rustdoc-verify-output-files, r=jieyouxu Migrate rustdoc verify output files Part of https://github.com/rust-lang/rust/issues/121876. r? ```@jieyouxu```
2024-05-27Rollup merge of #125339 - tbu-:pr_tidy_ui_tests_u32, r=clubby789Matthias Krüger-4/+4
The number of tests does not depend on the architecture's pointer width Use `u32` instead of `usize` for counting them.
2024-05-27Migrate `run-make/rustdoc-verify-output-files` to `rmake.rs`Guillaume Gomez-1/+0
2024-05-27Rollup merge of #125607 - GuillaumeGomez:migrate-compile-stdin, r=jieyouxuGuillaume Gomez-1/+0
Migrate `run-make/compile-stdin` to `rmake.rs` Part of https://github.com/rust-lang/rust/issues/121876. r? `@jieyouxu`
2024-05-27Migrate `run-make/compile-stdin` to `rmake.rs`Guillaume Gomez-1/+0
2024-05-26Rollup merge of #125307 - workingjubilee:uproot-entry-limit, r=Mark-SimulacrumMatthias Krüger-13/+2
tidy: stop special-casing tests/ui entry limit It is genuinely more annoying to have this error, now that this value is below the general `ENTRY_LIMIT` cap, when one is trying to clean out tests from tests/ui! This code has served its purpose well, let it rest now rather than force it to continue haunting us.
2024-05-25Rollup merge of #125472 - erikdesjardins:component, r=clubby789Matthias Krüger-0/+30
tidy: validate LLVM component names in tests LLVM component names are not immediately obvious (they usually omit any suffixes on the target arch name), and if they're incorrect, the test will silently never run. This happened [here](https://github.com/rust-lang/rust/pull/125220#discussion_r1612626002), and it would be nice to prevent it.
2024-05-24Migrate `run-make/rustdoc-with-output-dir-option` to `rmake.rs`Guillaume Gomez-1/+0
2024-05-23tidy: validate LLVM component names in testsErik Desjardins-0/+30
LLVM component names are not immediately obvious (they usually omit any suffixes on the target arch name), and if they're incorrect, the test will silently never run.
2024-05-23Rollup merge of #125445 - GuillaumeGomez:rustdoc-migrate-short-out-dir, ↵Guillaume Gomez-1/+0
r=jieyouxu Migrate `run-make/rustdoc-with-short-out-dir-option` to `rmake.rs` Part of https://github.com/rust-lang/rust/issues/121876. r? `@jieyouxu`
2024-05-23Rollup merge of #125401 - ↵León Orell Valerian Liehr-1/+0
GuillaumeGomez:migrate-rustdoc-scrape-examples-macros, r=jieyouxu Migrate `run-make/rustdoc-scrape-examples-macros` to `rmake.rs` Part of https://github.com/rust-lang/rust/issues/121876. r? `````@jieyouxu`````
2024-05-23Rollup merge of #125227 - Oneirical:seventh, r=jieyouxuLeón Orell Valerian Liehr-1/+0
Migrate `run-make/issue-30063` to `rmake` Part of #121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). (Sorry about the [inconvenience](https://github.com/rust-lang/rust/pull/125224#issuecomment-2118340932) of all these PRs, this is the last one batched for today. I will discuss how we can cut these down a bit.) The last check was previously commented out in the Makefile, and I have readded it. If it fails the CI, this can be reconsidered.
2024-05-23Rollup merge of #125224 - Oneirical:sixth, r=jieyouxuLeón Orell Valerian Liehr-1/+0
Migrate `run-make/issue-53964` to `rmake` Part of #121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). This is extremely similar to #125146. Could it be interesting to merge the two in some way? This one seems to do the same thing as the #125146, but with an added check that a useless lint is not shown.