| Age | Commit message (Collapse) | Author | Lines |
|
Even when at curly braces, otherwise the parser can get stuck.
This has happened in the past in #18625, but it was just worked around instead of handling the root of the problem. Now this happened again in #20171. IMO we can't let `err_and_bump()` not bump, that's too confusing and invites errors. We can (as I did) workaround the worse recovery instead.
|
|
|
|
Miri subtree update
r? `@ghost`
|
|
|
|
They need to return `!`, unlike diverging ordinary assignments. See the comment in the code.
|
|
[COMPILETEST-UNTANGLE 4/N] Improve compiletest config documentation
This is part of a patch series to untangle `compiletest` to hopefully nudge it towards being more maintainable.
This PR should contain **no functional changes**.
This is pulled out to its own PR to make follow-up changes easier to review.
There are *intentionally* a *lot* of FIXME comments, intended to be gradually addressed in follow-ups.
r? `@Kobzol`
|
|
|
|
previous behavior was inconsistent with existing extra checks.
|
|
|
|
shims::fs adding more fields to FileMetadata
|
|
|
|
addressing, partially at least, FIXME comment and
targetting unixes, adding device, user and group ids.
|
|
|
|
Including a bunch of FIXMEs.
|
|
|
|
|
|
|
|
This makes it work for box patterns and in rust-analyzer.
|
|
|
|
`tests/ui`: A New Order [14/N]
> [!NOTE]
>
> Intermediate commits are intended to help review, but will be squashed prior to merge.
Some `tests/ui/` housekeeping, to trim down number of tests directly under `tests/ui/`. Part of rust-lang/rust#133895.
r? `@jieyouxu`
|
|
Remove names_imported_by_glob_use query.
Based on https://github.com/rust-lang/rust/pull/143247
r? ``@ghost`` for perf
|
|
If the remote process is terminated by a signal, make `remote-test-client` exit
with the code `128 + <signal-number>` instead of always `3`. This follows common
practice among tools such as bash [^1]:
> When a command terminates on a fatal signal whose number is N, Bash uses the
> value 128+N as the exit status.
It also allows us to differentiate between `run-pass` and `run-crash` ui tests
without special case code in compiletest for that when `remote-test-client` is
used.
[^1]: https://www.gnu.org/software/bash/manual/html_node/Exit-Status.html
|
|
|
|
|
|
Previously, the following configuration in settings.json:
"rust-analyzer.workspace.discoverConfig": {
"command": [
"oops",
"develop-json",
"{arg}"
],
"progressLabel": "rust-analyzer",
"filesToWatch": [
"BUCK",
"TARGETS"
]
},
Would previously cause a crash in rust-analyzer:
thread 'LspServer' panicked at crates/rust-analyzer/src/main_loop.rs:776:84:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
Instead, use more specific panic messages.
|
|
Make __rust_alloc_error_handler_should_panic a function
Fixes rust-lang/rust#143253
`__rust_alloc_error_handler_should_panic` is a static but was being exported as a function.
For most targets this doesn't matter, but Arm64EC Windows uses different decorations for exported variables vs functions, hence it fails to link when `-Z oom=abort` is enabled.
We've had issues in the past with statics like this (see rust-lang/rust#141061) but the tldr; is that Arm64EC needs symbols correctly exported as either a function or data, and data MUST and MUST ONLY be marked `dllimport` when the symbol is being imported from another binary, which is non-trivial to calculate for these compiler-generated statics.
So, instead, the easiest thing to do is to make `__rust_alloc_error_handler_should_panic` a function instead.
Since `__rust_alloc_error_handler_should_panic` isn't involved in any linking shenanigans, I've marked it as `AlwaysInline` with the hopes that the various backends will see that it is just returning a constant and perform the same optimizations as the previous implementation.
r? `@bjorn3`
|
|
Make -Ztrack-diagnostics emit like a note
[#t-compiler/diagnostics > Rendering -Ztrack-diagnostics like a note](https://rust-lang.zulipchat.com/#narrow/channel/147480-t-compiler.2Fdiagnostics/topic/Rendering.20-Ztrack-diagnostics.20like.20a.20note/with/526608647)
As discussed on the Zulip thread above, I want to make `-Ztrack-diagnostics` emit like a `note`. This is because I find its current output jarring, and the fact that it gets rendered completely left-aligned, [even in the middle of a snippet](https://github.com/rust-lang/rust/blob/86e05cd300fac9e83e812c4d46582b48db780d8f/tests/ui/track-diagnostics/track6.stderr), seems like something that should be changed. Turning it into a `note` seems like the best choice, as it would align it with the rest of the output, and `note` is already used for somewhat similar things, like seeing why a lint was fired.
---
Note: turning `-Ztrack-diagnostics` into a `note` will also make `annotate-snippets` API a bit cleaner
|
|
|
|
Improve flycheck and build script progress reporting
|
|
|
|
|
|
|
|
Fix: Resolve HIR display length issues and improve adjustment tooltips
|
|
Co-authored-by: Giga Bowser <45986823+Giga-Bowser@users.noreply.github.com>
|
|
fix: Honor `rust-analyzer.cargo.noDeps` option when fetching sysroot metadata
|
|
Migrate `unmerge_match_arm` Assist to use `SyntaxEditor`
|
|
fix: Fix some things with builtin derives
|
|
|
|
|
|
Replace kw_span by full span for generic const parameters.
Small simplification extracted from https://github.com/rust-lang/rust/pull/127241
|
|
load_workspace`
|
|
1. Err on unions on derive where it's required.
2. Err on `#[derive(Default)]` on enums without `#[default]` variant.
3. Don't add where bounds `T: Default` when expanding `Default` on enums (structs need that, enums not).
Also, because I was annoyed by that, in minicore, add a way to filter on multiple flags in the line-filter (`// :`). This is required for the `Debug` and `Hash` derives, because the derive should be in the prelude but the trait not.
|
|
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#141831 (rustdoc: fix attrs of locally reexported foreign items)
- rust-lang/rust#143364 (don't include `.md` in title)
- rust-lang/rust#143369 (Various refactorings to the metadata loader)
- rust-lang/rust#143379 (Post {beta,stable}-accepted notifications to compiler/bootstrap backport zulip channels on `{beta,stable}-accepted` label application)
- rust-lang/rust#143384 (Update browser-ui-test version to `0.21.1`)
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
|
|
Update browser-ui-test version to `0.21.1`
One day I'll find time and motivation to use `package.json` instead. :laughing:
r? `@Kobzol`
|
|
Signed-off-by: Hayashi Mikihiro <34ttrweoewiwe28@gmail.com>
|
|
Weekly `cargo update`
Automation to keep dependencies in `Cargo.lock` current.
The following is the output from `cargo update`:
```txt
compiler & tools dependencies:
Locking 23 packages to latest compatible versions
Updating anstyle-svg v0.1.8 -> v0.1.9
Updating autocfg v1.4.0 -> v1.5.0
Updating bumpalo v3.18.1 -> v3.19.0
Updating derive-where v1.4.0 -> v1.5.0
Updating errno v0.3.12 -> v0.3.13
Updating indexmap v2.9.0 -> v2.10.0
Updating libredox v0.1.3 -> v0.1.4
Updating owo-colors v4.2.1 -> v4.2.2
Updating pest v2.8.0 -> v2.8.1
Updating pest_derive v2.8.0 -> v2.8.1
Updating pest_generator v2.8.0 -> v2.8.1
Updating pest_meta v2.8.0 -> v2.8.1
Updating r-efi v5.2.0 -> v5.3.0
Updating rustc-build-sysroot v0.5.8 -> v0.5.9
Updating slab v0.4.9 -> v0.4.10
Updating syn v2.0.103 -> v2.0.104
Adding toml v0.8.23
Adding toml_edit v0.22.27
Adding toml_write v0.1.2
Updating tracing-attributes v0.1.29 -> v0.1.30
Updating xattr v1.5.0 -> v1.5.1
Updating zerocopy v0.8.25 -> v0.8.26
Updating zerocopy-derive v0.8.25 -> v0.8.26
note: pass `--verbose` to see 39 unchanged dependencies behind latest
library dependencies:
Locking 0 packages to latest compatible versions
note: pass `--verbose` to see 3 unchanged dependencies behind latest
rustbook dependencies:
Locking 21 packages to latest compatible versions
Updating autocfg v1.4.0 -> v1.5.0
Updating bumpalo v3.18.1 -> v3.19.0
Updating errno v0.3.12 -> v0.3.13
Updating indexmap v2.9.0 -> v2.10.0
Updating markup5ever v0.16.1 -> v0.16.2
Updating pest v2.8.0 -> v2.8.1
Updating pest_derive v2.8.0 -> v2.8.1
Updating pest_generator v2.8.0 -> v2.8.1
Updating pest_meta v2.8.0 -> v2.8.1
Updating r-efi v5.2.0 -> v5.3.0
Updating syn v2.0.103 -> v2.0.104
Adding windows-sys v0.60.2
Adding windows-targets v0.53.2
Adding windows_aarch64_gnullvm v0.53.0
Adding windows_aarch64_msvc v0.53.0
Adding windows_i686_gnu v0.53.0
Adding windows_i686_gnullvm v0.53.0
Adding windows_i686_msvc v0.53.0
Adding windows_x86_64_gnu v0.53.0
Adding windows_x86_64_gnullvm v0.53.0
Adding windows_x86_64_msvc v0.53.0
```
|
|
compiler & tools dependencies:
Locking 23 packages to latest compatible versions
Updating anstyle-svg v0.1.8 -> v0.1.9
Updating autocfg v1.4.0 -> v1.5.0
Updating bumpalo v3.18.1 -> v3.19.0
Updating derive-where v1.4.0 -> v1.5.0
Updating errno v0.3.12 -> v0.3.13
Updating indexmap v2.9.0 -> v2.10.0
Updating libredox v0.1.3 -> v0.1.4
Updating owo-colors v4.2.1 -> v4.2.2
Updating pest v2.8.0 -> v2.8.1
Updating pest_derive v2.8.0 -> v2.8.1
Updating pest_generator v2.8.0 -> v2.8.1
Updating pest_meta v2.8.0 -> v2.8.1
Updating r-efi v5.2.0 -> v5.3.0
Updating rustc-build-sysroot v0.5.8 -> v0.5.9
Updating slab v0.4.9 -> v0.4.10
Updating syn v2.0.103 -> v2.0.104
Adding toml v0.8.23
Adding toml_edit v0.22.27
Adding toml_write v0.1.2
Updating tracing-attributes v0.1.29 -> v0.1.30
Updating xattr v1.5.0 -> v1.5.1
Updating zerocopy v0.8.25 -> v0.8.26
Updating zerocopy-derive v0.8.25 -> v0.8.26
note: pass `--verbose` to see 39 unchanged dependencies behind latest
library dependencies:
Locking 0 packages to latest compatible versions
note: pass `--verbose` to see 3 unchanged dependencies behind latest
rustbook dependencies:
Locking 21 packages to latest compatible versions
Updating autocfg v1.4.0 -> v1.5.0
Updating bumpalo v3.18.1 -> v3.19.0
Updating errno v0.3.12 -> v0.3.13
Updating indexmap v2.9.0 -> v2.10.0
Updating markup5ever v0.16.1 -> v0.16.2
Updating pest v2.8.0 -> v2.8.1
Updating pest_derive v2.8.0 -> v2.8.1
Updating pest_generator v2.8.0 -> v2.8.1
Updating pest_meta v2.8.0 -> v2.8.1
Updating r-efi v5.2.0 -> v5.3.0
Updating syn v2.0.103 -> v2.0.104
Adding windows-sys v0.60.2
Adding windows-targets v0.53.2
Adding windows_aarch64_gnullvm v0.53.0
Adding windows_aarch64_msvc v0.53.0
Adding windows_i686_gnu v0.53.0
Adding windows_i686_gnullvm v0.53.0
Adding windows_i686_msvc v0.53.0
Adding windows_x86_64_gnu v0.53.0
Adding windows_x86_64_gnullvm v0.53.0
Adding windows_x86_64_msvc v0.53.0
|
|
|
|
|