about summary refs log tree commit diff
path: root/src
AgeCommit message (Collapse)AuthorLines
2019-03-23cleanupGuillaume Gomez-13/+24
2019-03-23Use `if let` instead of `match`varkor-13/+10
2019-03-23Auto merge of #59096 - ljedrz:HirIdify_AccessLevel, r=Zoxcbors-52/+55
middle: replace NodeId with HirId in AccessLevels Pushing the limits of HirIdification (#57578). Replaces `NodeId` with `HirId` in `middle::privacy::AccessLevels`. Actually this time I was more successful and cracked it; I probably tried to HirIdify too much at once when I attempted it last time ^^. r? @Zoxc
2019-03-23Fix invalid DWARF for enums when using thinltoPhilip Craig-11/+64
We were setting the same identifier for both the DW_TAG_structure_type and the DW_TAG_variant_part. This becomes a problem when using thinlto becauses it uses the identifier as a key for a map of types that is used to delete duplicates based on the ODR, so one of them is deleted as a duplicate, resulting in invalid DWARF. The DW_TAG_variant_part isn't a standalone type, so it doesn't need an identifier. Fix by omitting its identifier.
2019-03-23fs::copy() set file mode earlyHarald Hoyer-59/+83
A convenience method like fs::copy() should try to prevent pitfalls a normal user doesn't think about. In case of an empty umask, setting the file mode early prevents temporarily world readable or even writeable files, because the default mode is 0o666. In case the target is a named pipe or special device node, setting the file mode can lead to unwanted side effects, like setting permissons on `/dev/stdout` or for root setting permissions on `/dev/null`. copy_file_range() returns EINVAL, if the destination is a FIFO/pipe or a device like "/dev/null", so fallback to io::copy, too. Use `fcopyfile` on MacOS instead of `copyfile`. Fixes: https://github.com/rust-lang/rust/issues/26933 Fixed: https://github.com/rust-lang/rust/issues/37885
2019-03-23Auto merge of #59058 - petrochenkov:assocrecov3, r=estebankbors-92/+217
syntax: Better recovery for `$ty::AssocItem` and `ty!()::AssocItem` This PR improves on https://github.com/rust-lang/rust/pull/46788 covering a few missing cases. Fixes https://github.com/rust-lang/rust/issues/52307 Fixes https://github.com/rust-lang/rust/issues/53776 r? @estebank
2019-03-22review commentsEsteban Küber-2/+2
2019-03-22extend on-unimplemented docsEsteban Küber-2/+3
2019-03-22Add suggestion to use `&*var` when `&str: From<String>` is expectedEsteban Küber-0/+41
2019-03-22Add note to address check_match errorsEsteban Küber-3/+4
2019-03-22address review commentsEsteban Küber-24/+13
2019-03-22Do not `track_errors` in `register_plugins`Esteban Küber-14/+12
2019-03-22Continue running after `typeck_item_bodies` has failedEsteban Küber-6/+9
2019-03-22Remove track_errors from check_matchEsteban Küber-10/+14
2019-03-22Reword type ascription note to reduce verbosityEsteban Küber-65/+11
2019-03-22Review commentEsteban Küber-12/+12
2019-03-22Hide "type ascription is experimental error" unless it's the only oneEsteban Küber-26/+11
In order to minimize the verbosity of common syntax errors that are parsed as type ascription, hide the feature gate error unless there are no other errors being emitted by the parser.
2019-03-22Only suggest let assignment for type ascription if we find an equals signEsteban Küber-16/+24
2019-03-22Tweak labelsEsteban Küber-7/+8
2019-03-22Expand suggestions for type ascription parse errorsEsteban Küber-18/+358
2019-03-23Auto merge of #58929 - estebank:elide-object, r=zackmdavisbors-21/+74
Elide object safety errors on non-existent trait function Fix #58734. r? @zackmdavis
2019-03-22Correct minimum system LLVM version in testsSamuel Holland-15/+17
Since commit 9452a8dfa3ba, the new debug info format is only generated for LLVM 8 and newer versions. However, the tests still assume that LLVM 7 will use the new debug info format. Fix the tests (and a comment in the code) to match the actual version check.
2019-03-23resolve: collect trait aliases along with traitsSean McArthur-2/+36
2019-03-22Update sys::time impls to have checked_sub_instantLinus Färnstrand-25/+18
2019-03-22ffi: rename VaList::copy to VaList::with_copyDan Robertson-21/+21
Rename `VaList::copy` to `VaList::with_copy`.
2019-03-22Make duration_since use checked_duration_sinceLinus Färnstrand-6/+2
2019-03-22Add/rename checked_duration_since testsLinus Färnstrand-6/+9
2019-03-22Auto merge of #59370 - Centril:rollup, r=Centrilbors-733/+1026
Rollup of 18 pull requests Successful merges: - #59106 (Add peer_addr function to UdpSocket) - #59170 (Add const generics to rustdoc) - #59172 (Update and clean up several parts of CONTRIBUTING.md) - #59190 (consistent naming for Rhs type parameter in libcore/ops) - #59236 (Rename miri component to miri-preview) - #59266 (Do not complain about non-existing fields after parse recovery) - #59273 (some small HIR doc improvements) - #59291 (Make Option<ThreadId> no larger than ThreadId, with NonZeroU64) - #59297 (convert field/method confusion help to suggestions) - #59304 (Move some bench tests back from libtest) - #59309 (Add messages for different verbosity levels. Output copy actions.) - #59321 (Unify E0109, E0110 and E0111) - #59322 (Tweak incorrect escaped char diagnostic) - #59323 (use suggestions for "enum instead of variant" error) - #59327 (Add NAN test to docs) - #59329 (cleanup: Remove compile-fail-fulldeps directory again) - #59347 (Move one test from run-make-fulldeps to ui) - #59360 (Add tracking issue number for `seek_convenience`) Failed merges: r? @ghost
2019-03-22add suggestions to trim_{left,right} deprecationsAndy Russell-4/+20
2019-03-22Rollup merge of #59360 - LukasKalbertodt:patch-2, r=rkruppeMazdak Farrokhzad-2/+2
Add tracking issue number for `seek_convenience` We forgot to do that in #58422
2019-03-22Rollup merge of #59347 - petrochenkov:nomake, r=davidtwcoMazdak Farrokhzad-50/+57
Move one test from run-make-fulldeps to ui The test was written when `--extern` without path didn't exist.
2019-03-22Rollup merge of #59329 - petrochenkov:rmcff, r=alexcrichtonMazdak Farrokhzad-45/+0
cleanup: Remove compile-fail-fulldeps directory again It was already removed once in https://github.com/rust-lang/rust/pull/56444, but was partially resurrected by rebase of some other PR.
2019-03-22Rollup merge of #59327 - Xaeroxe:clamp-doc, r=scottmcmMazdak Farrokhzad-0/+38
Add NAN test to docs Documents and tests NAN behavior for the new (f32, f64)::clamp function.
2019-03-22Rollup merge of #59323 - euclio:enum-instead-of-variant, r=varkorMazdak Farrokhzad-47/+118
use suggestions for "enum instead of variant" error
2019-03-22Rollup merge of #59322 - estebank:diag-tweak, r=davidtwcoMazdak Farrokhzad-72/+51
Tweak incorrect escaped char diagnostic
2019-03-22Rollup merge of #59321 - varkor:unify-E0109-E0110-E0111, r=davidtwcoMazdak Farrokhzad-223/+206
Unify E0109, E0110 and E0111 Error messages should no longer be restricted to specific generic kinds.
2019-03-22Rollup merge of #59309 - o01eg:verbose-copy-files, r=alexcrichtonMazdak Farrokhzad-0/+12
Add messages for different verbosity levels. Output copy actions.
2019-03-22Rollup merge of #59304 - gnzlbg:bench_tests, r=alexcrichtonMazdak Farrokhzad-0/+25
Move some bench tests back from libtest It doesn't make much sense to test these on rust-lang/libtest since they exercise the `#[bench]` macro which is part of rust-lang/rust. This PR moves these tests back here. r? @alexcrichton
2019-03-22Rollup merge of #59297 - euclio:field-method-suggestions, r=estebankMazdak Farrokhzad-53/+98
convert field/method confusion help to suggestions
2019-03-22Rollup merge of #59291 - SimonSapin:nonzero-thread-id, r=alexcrichtonMazdak Farrokhzad-4/+11
Make Option<ThreadId> no larger than ThreadId, with NonZeroU64
2019-03-22Rollup merge of #59273 - llogiq:hir-docs, r=matthewjasperMazdak Farrokhzad-1/+12
some small HIR doc improvements
2019-03-22Rollup merge of #59266 - estebank:struct-parse-recovery, r=petrochenkovMazdak Farrokhzad-58/+111
Do not complain about non-existing fields after parse recovery When failing to parse struct-like enum variants, the ADT gets recorded as having no fields. Record that we have actually recovered during parsing of this variant to avoid complaing about non-existing fields when actually using it. Fix #57361.
2019-03-22Rollup merge of #59236 - mati865:miri-preview, r=oli-obkMazdak Farrokhzad-3/+4
Rename miri component to miri-preview It should fix installation via `rustup` and indicates it's not stable yet.
2019-03-22Rollup merge of #59190 - greg-kargin:master, r=sanxiynMazdak Farrokhzad-56/+56
consistent naming for Rhs type parameter in libcore/ops Rename RHS type parameter occurrences RHS->Rhs to make it consistent throughout files and follow naming conventions.
2019-03-22Rollup merge of #59170 - varkor:const-generics-rustdoc, r=QuietMisdreavus,eddybMazdak Farrokhzad-117/+156
Add const generics to rustdoc Split out from #53645. This work is a collaborative effort with @yodaldevoid. The `FIXME`s are waiting on a refactor to `LazyConst`. I'll address these in a follow up, but I thought it would be better to implement the rest now to avoid bitrot. r? @QuietMisdreavus
2019-03-22Rollup merge of #59106 - LinusU:udp-peer-addr, r=kennytmMazdak Farrokhzad-2/+69
Add peer_addr function to UdpSocket Fixes #59104 This is my first pull request to Rust, so opening early for some feedback. My biggest question is: where do I add tests? Any comments very much appreciated!
2019-03-22Auto merge of #58953 - jethrogb:jb/unify-ffi, r=alexcrichtonbors-809/+186
Unify OsString/OsStr for byte-based implementations As requested in #57860 r? @joshtriplett
2019-03-22Auto merge of #57810 - MikaelUrankar:stack_t_bsd, r=nagisabors-2/+2
FreeBSD 10.x is EOL, in FreeBSD 11 and later, ss_sp is actually a void* …d* [1] dragonflybsd still uses c_char [2] [1] https://svnweb.freebsd.org/base/releng/11.2/sys/sys/signal.h?revision=334459&view=markup#l438 [2] https://github.com/DragonFlyBSD/DragonFlyBSD/blob/master/sys/sys/signal.h#L339
2019-03-22Expand `impl FromIterator for Result` doc to include examples of `Err` and ↵Felix S. Klock II-0/+28
early termination.
2019-03-22Expand `impl FromIterator for Option` doc to include example of early ↵Felix S. Klock II-0/+20
termination.