rust - https://github.com/rust-lang/rust

Age	Commit message (Collapse)	Author	Lines
2023-12-04	Restrict what symbols can be used in `#[diagnostic::on_unimplemented]` ↵	Georg Semmler	-9/+425
	format strings This commit restricts what symbols can be used in a format string for any option of the `diagnostic::on_unimplemented` attribute. We previously allowed all the ad-hoc options supported by the internal `#[rustc_on_unimplemented]` attribute. For the stable attribute we only want to support generic parameter names and `{Self}` as parameters. For any other parameter an warning is emitted and the parameter is replaced by the literal parameter string, so for example `{integer}` turns into `{integer}`. This follows the general design of attributes in the `#[diagnostic]` attribute namespace, that any syntax "error" is treated as warning and subsequently ignored.
2023-11-24	Show number in error message even for one error	Nilstrieb	-5/+5
	Co-authored-by: Adrian <adrian.iosdev@gmail.com>
2023-11-17	Add some additional warnings for duplicated diagnostic items	Georg Semmler	-4/+118
	This commit adds warnings if a user supplies several diagnostic options where we can only apply one of them. We explicitly warn about ignored options here. In addition a small test for these warnings is added.
2023-10-27	Allows `#[diagnostic::on_unimplemented]` attributes to have multiple	Georg Semmler	-0/+66
	notes This commit extends the `#[diagnostic::on_unimplemented]` (and `#[rustc_on_unimplemented]`) attributes to allow multiple `note` options. This enables emitting multiple notes for custom error messages. For now I've opted to not change any of the existing usages of `#[rustc_on_unimplemented]` and just updated the relevant compile tests.
2023-10-20	Fix a span for one of the test cases	Georg Semmler	-29/+15

2023-10-19	Improve the warning messages for the `#[diagnostic::on_unimplemented]`	Georg Semmler	-17/+74
	This commit improves warnings emitted for malformed on unimplemented attributes by: * Improving the span of the warnings * Adding a label message to them * Separating the messages for missing and unexpected options * Adding a help message that says which options are supported
2023-10-11	Handle several `#[diagnostic::on_unimplemented]` attributes correctly	Georg Semmler	-0/+74
	This PR fixes an issues where rustc would ignore subsequent `#[diagnostic::on_unimplemented]` attributes. The [corresponding RFC](https://rust-lang.github.io/rfcs/3368-diagnostic-attribute-namespace.html) specifies that the first matching instance of each option is used. Invalid attributes are linted and otherwise ignored.
2023-10-05	Add a note to duplicate diagnostics	Alex Macleod	-0/+6

2023-09-12	`#[diagnostic::on_unimplemented]` without filters	Georg Semmler	-6/+207
	This commit adds support for a `#[diagnostic::on_unimplemented]` attribute with the following options: * `message` to customize the primary error message * `note` to add a customized note message to an error message * `label` to customize the label part of the error message Co-authored-by: León Orell Valerian Liehr <me@fmease.dev> Co-authored-by: Michael Goulet <michael@errs.io>
2023-07-28	Introduce the `#[diagnostic]` attribute namespace	Georg Semmler	-0/+143
	Co-authored-by: est31 <est31@users.noreply.github.com> Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com> Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>