| Age | Commit message (Collapse) | Author | Lines | |
|---|---|---|---|---|
| 2023-07-08 | Rollup merge of #113005 - compiler-errors:dont-query-normalize, r=cjgillot | Matthias Krüger | -2/+2 | |
| Don't call `query_normalize` when reporting similar impls Firstly, It's sketchy to be using `query_normalize` at all during HIR typeck -- it's asking for an ICE 😅. Secondly, we're normalizing an impl trait ref that potentially has parameter types in `ty::ParamEnv::empty()`, which is kinda sketchy as well. The only UI test change from removing this normalization is that we don't evaluate anonymous constants in impls, which end up giving us really ugly suggestions: ``` error[E0277]: the trait bound `[X; 35]: Default` is not satisfied --> /home/gh-compiler-errors/test.rs:4:5 | 4 | <[X; 35] as Default>::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Default` is not implemented for `[X; 35]` | = help: the following other types implement trait `Default`: &[T] &mut [T] [T; 32] [T; core::::array::{impl#30}::{constant#0}] [T; core::::array::{impl#31}::{constant#0}] [T; core::::array::{impl#32}::{constant#0}] [T; core::::array::{impl#33}::{constant#0}] [T; core::::array::{impl#34}::{constant#0}] and 27 others ``` So just fold the impls with a `BottomUpFolder` that calls `ty::Const::eval`. This doesn't work totally correctly with generic-const-exprs, but it's fine for stable code, and this is error reporting after all. | ||||
| 2023-06-27 | Don't sort strings right after we just sorted by types | Michael Goulet | -2/+2 | |
| 2023-06-24 | fix test | asquared31415 | -3/+28 | |
| 2023-05-09 | Rollup merge of #110583 - Ezrashaw:tweak-make-mut-spans, r=estebank | Dylan DPC | -15/+15 | |
| tweak "make mut" spans when assigning to locals Work towards fixing #106857 This PR just cleans up a lot of spans which is helpful before properly fixing the issues. Best reviewed commit-by-commit. r? `@estebank` | ||||
| 2023-05-08 | Tweak borrow suggestion | Michael Goulet | -8/+13 | |
| 2023-05-05 | tweak "make mut" spans (No. 3) | Ezra Shaw | -10/+10 | |
| 2023-05-05 | tweak "make mut" spans (No. 2) | Ezra Shaw | -5/+5 | |
| 2023-04-27 | Provide RHS type hint when reporting operator error | Michael Goulet | -2/+2 | |
| 2023-04-21 | Evaluate place expression in `PlaceMention`. | Camille GILLOT | -2/+0 | |
| 2023-04-19 | Make missing impl item suggestions more obvious that they're missing | Michael Goulet | -3/+3 | |
| 2023-04-12 | Special-case item attributes in the suggestion output | Esteban Küber | -2/+0 | |
| 2023-04-12 | Tweak output for 'add line' suggestion | Esteban Küber | -2/+5 | |
| 2023-03-08 | may not => cannot | Michael Goulet | -8/+8 | |
| 2023-02-28 | Exit when there are unmatched delims to avoid noisy diagnostics | yukang | -99/+6 | |
| 2023-02-22 | diagnostics: update test cases to refer to assoc fn with `self` as method | Michael Howell | -11/+11 | |
| 2023-02-14 | Make removal suggestion not verbose | Esteban Küber | -12/+8 | |
| 2023-02-14 | rebase and review comments | Esteban Küber | -2/+2 | |
| 2023-02-14 | More accurate spans for arg removal suggestion | Esteban Küber | -4/+6 | |
| 2023-02-11 | Pacify tidy. | Camille GILLOT | -0/+1 | |
| 2023-02-11 | Intern span when length is MAX_LEN with parent. | Camille GILLOT | -0/+8 | |
| 2023-01-30 | Modify primary span label for E0308 | Esteban Küber | -5/+5 | |
| The previous output was unintuitive to users. | ||||
| 2023-01-17 | Account for method call and indexing when looking for inner-most path in ↵ | Esteban Küber | -7/+18 | |
| expression | ||||
| 2023-01-17 | Account for `*` when looking for inner-most path in expression | Esteban Küber | -0/+14 | |
| 2023-01-15 | Tweak E0597 | Esteban Küber | -16/+118 | |
| CC #99430 | ||||
| 2023-01-12 | Point at impl self type for impl wf obligations | Michael Goulet | -4/+4 | |
| 2023-01-11 | Move /src/test to /tests | Albert Larsan | -0/+7833 | |
