| Age | Commit message (Collapse) | Author | Lines |
|---|
|
Rollup of 6 pull requests
Successful merges:
- #106608 (Render missing generics suggestion verbosely)
- #106716 ([RFC 2397] Deny incorrect locations)
- #106754 (Rename `Ty::is_ty_infer` -> `Ty::is_ty_or_numeric_infer`)
- #106782 (Ignore tests move in git blame)
- #106785 (Make blame spans better for impl wfcheck)
- #106791 (Fix ICE formatting)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
Make blame spans better for impl wfcheck
r? types
|
|
[RFC 2397] Deny incorrect locations
cc #51992
As declared in the RFC, `#[do_not_recommend]` should only be applicable on trait implementations.
|
|
Render missing generics suggestion verbosely
It's a bit easier to read like this, especially ones that are appending new generics onto an existing list, like ": `, T`" which render somewhat poorly inline.
Also don't suggest `dyn` as a type parameter to add, even if technically that's valid in edition 2015.
|
|
Add checks for the signature of the `start` lang item
Closes #105963
|
|
Const closures
cc https://github.com/rust-lang/rust/issues/106003
|
|
|
|
|
|
|
|
Revert "Make nested RPITIT inherit the parent opaque's generics."
This reverts commit e2d41f4c974f0cc09e5aafb02883f222487610f9, and adjusts the `tests/ui/async-await/in-trait/nested-rpit.rs` test.
r? `@cjgillot`
fixes #106332, manually verified because it had no minimization :/
reopens #105197
cc #106729
|
|
Fix reexport of `doc(hidden)` item
Part of #59368.
It doesn't fix the `doc(inline)` nor the `doc(hidden)` on macro. I'll do it in a follow-up PR.
r? `@notriddle`
|
|
Adding a hint on iterator type errors
Issue reference https://github.com/rust-lang/rust/issues/106728
- [x] add a case in the attribute
- [x] add a test
closes #106728
|
|
Mark ZST as FFI-safe if all its fields are PhantomData
This presents one possible solution to issue: #106629.
This is my first (tentative) contribution to the compiler itself.
I'm looking forward for comments and feedback
Closes: #106629
|
|
Stabilize `abi_efiapi` feature
Tracking issue: https://github.com/rust-lang/rust/issues/65815
Closes #65815
|
|
|
|
|
|
Rollup of 6 pull requests
Successful merges:
- #105806 (Support eager subdiagnostics again)
- #106322 (Handle inference variables in `CollectAllMismatches` correctly)
- #106579 (Suggest making private tuple struct field public)
- #106714 (remove unreachable error code `E0490`)
- #106751 (Fix rendering 'const' in header for intrinsics)
- #106761 (Add `WaffleLapkin` to compiler reviewers)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
|
|
Fix rendering 'const' in header for intrinsics
Fixes #99398
|
|
Suggest making private tuple struct field public
Fix #52144.
|
|
r=oli-obk
Handle inference variables in `CollectAllMismatches` correctly
1. Fix #106240
2. Treat int/float type variables correctly (see `src/test/ui/iterators/invalid-iterator-chain-with-int-infer.rs`), so we can point out things like "`Iterator::Item` changed to `{integer}` here"
|
|
Support eager subdiagnostics again
See https://github.com/rust-lang/rust/pull/104941#discussion_r1051135746
I'm not sure how to add a test for this. But I did pick some of the diagnostic structs in the mentioned PR and it works with them.
|
|
|
|
Harden the pre-tyctxt query system against accidental recomputation
While the current compiler has no issues where we `take` and then compute the query again, in https://github.com/rust-lang/rust/pull/105462 I accidentally introduced such a case.
I also took the opportunity to remove `peek_mut`, which is only ever used for `global_tcx` to then invoke `enter`. I added an `enter` method directly on the query.
|
|
|
|
Modify the linting behavior and add the corresponding
regression test
|
|
Rollup of 8 pull requests
Successful merges:
- #103236 (doc: rewrite doc for signed int::{carrying_add,borrowing_sub})
- #103800 (Stabilize `::{core,std}::pin::pin!`)
- #106097 (Migrate mir_build diagnostics 2 of 3)
- #106170 (Move autoderef to `rustc_hir_analysis`)
- #106323 (Stabilize f16c_target_feature)
- #106360 (Tweak E0277 `&`-removal suggestions)
- #106524 (Label `struct/enum constructor` instead of `fn item`, mention that it should be called on type mismatch)
- #106739 (Remove `<dyn AstConv<'tcx>>::fun(c, ...)` calls in favour of `c.astconv().fun(...)`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
|
|
Label `struct/enum constructor` instead of `fn item`, mention that it should be called on type mismatch
Fixes #106516
|
|
Tweak E0277 `&`-removal suggestions
Fix #64068, fix #84837.
|
|
Migrate mir_build diagnostics 2 of 3
The first three commits are fairly boring, however I've made some changes to the output of the match checking diagnostics.
|
|
Stabilize `::{core,std}::pin::pin!`
As discussed [over here](https://github.com/rust-lang/rust/issues/93178#issuecomment-1295843548), it looks like a decent time to stabilize the `pin!` macro.
### Public API
```rust
// in module `core::pin`
/// API: `fn pin<T>($value: T) -> Pin<&'local mut T>`
pub macro pin($value:expr $(,)?) {
…
}
```
- Tracking issue: #93178
(now all this needs is an FCP by the proper team?)
|
|
test
This reverts commit e2d41f4c974f0cc09e5aafb02883f222487610f9.
|
|
Conserve cause of `ImplDerivedObligation` in E0599
CC #86377.
|
|
Test that we cannot use trait impl methods arguments as defining uses
Addresses https://github.com/rust-lang/rust/issues/63063#issuecomment-1360053614
r? `@dtolnay`
|
|
Hide more of long types in E0271
Fix #40186.
|
|
Allow codegen to unsize `dyn*` to `dyn`
`dyn* Trait` is just another type that implements `Trait`, so we should be able to unsize `&dyn* Trait` into `&dyn Trait` perfectly fine, same for `Box` and other unsizeable types.
Fixes #106488
|
|
Prefer non-`[type error]` candidates during selection
Fixes #102130
Fixes #106351
r? types
note: Alternatively we could filter out error where-clauses during param-env construction? But we still need to filter out impls with errors during `match_impl`, I think.
|
|
Fix invalid syntax and incomplete suggestion in impl Trait parameter type suggestions for E0311
Fixes #105544
The problems: The suggestion given for E0311 has invalid syntax when the synthetic type parameter is used for Trait type in function declaration:
```rust
fn foo(d: impl Sized) -> impl Sized
```
instead of explicitly specified like the following:
```rust
fn foo<T: Sized>(d: T) -> impl Sized
```
In addition to the syntax error, the suggestions given for E0311 are not complete when multiple elided lifetimes are involved in lifetime bounds, not all involved parameters are given the named lifetime in the suggestions. For the following test case:
```
fn foo(d: impl Sized, p: &mut ()) -> impl Sized + '_ {
(d, p)
}
```
a good suggestion should add the lifetime 'a to both d and p, instead of d only:
```
fn foo<'a>(d: impl Sized + 'a, p: &'a mut ()) -> impl Sized + '_ {
(d, p)
}
```
The Solution: Fix the syntax problem in the suggestions when synthetic type parameter is used, and also add lifetimes for all involved parameters.
|
|
|
|
|
|
|
|
|
|
|
|
fmease:recover-where-clause-before-tuple-struct-body, r=estebank
Recover from where clauses placed before tuple struct bodies
Open to any suggestions regarding the phrasing of the diagnostic.
Fixes #100790.
`@rustbot` label A-diagnostics
r? diagnostics
|
|
Tracking issue: https://github.com/rust-lang/rust/issues/65815
|
|
Rollup of 6 pull requests
Successful merges:
- #106620 (Detect struct literal needing parentheses)
- #106622 (Detect out of bounds range pattern value)
- #106703 (Note predicate span on `ImplDerivedObligation`)
- #106705 (Report fulfillment errors in new trait solver)
- #106726 (Fix some typos in code comments.)
- #106734 (Deny having src/test exisiting in tidy)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
|
|
|
|
|
|
|
