From 90dfa24415d4f29e1970bf215458ccefec60f85f Mon Sep 17 00:00:00 2001 From: Michael Goulet Date: Sat, 30 Sep 2023 19:28:40 +0000 Subject: Only reachable traits --- compiler/rustc_lint/src/async_fn_in_trait.rs | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'compiler') diff --git a/compiler/rustc_lint/src/async_fn_in_trait.rs b/compiler/rustc_lint/src/async_fn_in_trait.rs index 1329ba3d519..9214e04bb8b 100644 --- a/compiler/rustc_lint/src/async_fn_in_trait.rs +++ b/compiler/rustc_lint/src/async_fn_in_trait.rs @@ -93,10 +93,16 @@ impl<'tcx> LateLintPass<'tcx> for AsyncFnInTrait { if let hir::TraitItemKind::Fn(sig, body) = item.kind && let hir::IsAsync::Async(async_span) = sig.header.asyncness { + // RTN can be used to bound `async fn` in traits in a better way than "always" if cx.tcx.features().return_type_notation { return; } + // Only need to think about library implications of reachable traits + if !cx.tcx.effective_visibilities(()).is_reachable(item.owner_id.def_id) { + return; + } + let hir::FnRetTy::Return(hir::Ty { kind: hir::TyKind::OpaqueDef(def, ..), .. }) = sig.decl.output else { -- cgit 1.4.1-3-g733a5