From 8a6f54fc3a4e8cbe71396b1fd51f5dc718e50f08 Mon Sep 17 00:00:00 2001 From: Joshua Nelson Date: Thu, 9 Dec 2021 11:14:49 -0600 Subject: Use more accurate wording in `bootstrap.py` logging --- src/bootstrap/bootstrap.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/bootstrap/bootstrap.py') diff --git a/src/bootstrap/bootstrap.py b/src/bootstrap/bootstrap.py index ca7ad532030..0cd0fabe9b1 100644 --- a/src/bootstrap/bootstrap.py +++ b/src/bootstrap/bootstrap.py @@ -189,11 +189,11 @@ def default_build_triple(verbose): host = next(x for x in version.split('\n') if x.startswith("host: ")) triple = host.split("host: ")[1] if verbose: - print("detected default triple {}".format(triple)) + print("detected default triple {} from pre-installed rustc".format(triple)) return triple except Exception as e: if verbose: - print("rustup not detected: {}".format(e)) + print("pre-installed rustc not detected: {}".format(e)) print("falling back to auto-detect") required = sys.platform != 'win32' @@ -727,11 +727,11 @@ class RustBuild(object): if status != 0: if download_rustc == "if-unchanged": return None - print("warning: `download-rustc` is enabled, but there are changes to \ - compiler/ or library/") + print("warning: `download-rustc` is enabled, but there are changes to " \ + "compiler/ or library/") if self.verbose: - print("using downloaded stage1 artifacts from CI (commit {})".format(commit)) + print("using downloaded stage2 artifacts from CI (commit {})".format(commit)) self.rustc_commit = commit # FIXME: support downloading artifacts from the beta channel self.download_toolchain(False, "nightly") -- cgit 1.4.1-3-g733a5 From ae6f5fbc3f7825c42ade064be3a54f38a143e26b Mon Sep 17 00:00:00 2001 From: Joshua Nelson Date: Thu, 9 Dec 2021 11:15:05 -0600 Subject: If --verbose is passed, print a warning in `bootstrap.py` when download-rustc is ignored --- src/bootstrap/bootstrap.py | 3 +++ 1 file changed, 3 insertions(+) (limited to 'src/bootstrap/bootstrap.py') diff --git a/src/bootstrap/bootstrap.py b/src/bootstrap/bootstrap.py index 0cd0fabe9b1..5df3d0bde6d 100644 --- a/src/bootstrap/bootstrap.py +++ b/src/bootstrap/bootstrap.py @@ -726,6 +726,9 @@ class RustBuild(object): status = subprocess.call(["git", "diff-index", "--quiet", commit, "--", compiler, library]) if status != 0: if download_rustc == "if-unchanged": + if self.verbose: + print("warning: saw changes to compiler/ or library/ since {}; " \ + "ignoring `download-rustc`".format(commit)) return None print("warning: `download-rustc` is enabled, but there are changes to " \ "compiler/ or library/") -- cgit 1.4.1-3-g733a5