From 4bde92c17674ba5ac8de4123e0c1023d1e29a60f Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Mon, 5 Mar 2018 08:12:13 -0800 Subject: rustc: Fix ICE with `#[target_feature]` on module This commit fixes an ICE in rustc when `#[target_feature]` was applied to items other than functions due to the way the feature was validated. --- src/librustc/hir/check_attr.rs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'src/librustc/hir') diff --git a/src/librustc/hir/check_attr.rs b/src/librustc/hir/check_attr.rs index d2270345260..d7194e9c2ca 100644 --- a/src/librustc/hir/check_attr.rs +++ b/src/librustc/hir/check_attr.rs @@ -47,7 +47,13 @@ struct CheckAttrVisitor<'a, 'tcx: 'a> { impl<'a, 'tcx> CheckAttrVisitor<'a, 'tcx> { /// Check any attribute. fn check_attributes(&self, item: &hir::Item, target: Target) { - self.tcx.trans_fn_attrs(self.tcx.hir.local_def_id(item.id)); + if target == Target::Fn { + self.tcx.trans_fn_attrs(self.tcx.hir.local_def_id(item.id)); + } else if let Some(a) = item.attrs.iter().find(|a| a.check_name("target_feature")) { + self.tcx.sess.struct_span_err(a.span, "attribute should be applied to a function") + .span_label(item.span, "not a function") + .emit(); + } for attr in &item.attrs { if let Some(name) = attr.name() { -- cgit 1.4.1-3-g733a5